All of lore.kernel.org
 help / color / mirror / Atom feed
From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: davinci: remove unused davinci-i2s pdata
Date: Fri, 8 Jul 2016 16:35:14 +0530	[thread overview]
Message-ID: <577F88EA.5000602@ti.com> (raw)
In-Reply-To: <5213058.cGsNedsgWG@wuerfel>

On Friday 08 July 2016 03:36 PM, Arnd Bergmann wrote:
> On Friday, June 10, 2016 6:18:27 PM CEST Sekhar Nori wrote:
>> On Monday 09 May 2016 07:29 PM, Petr Kulhavy wrote:
>>> The davinci-i2s driver ("davinci-mcbsp") does not use platform
>>> data any longer. Remove the dummy pdata provided by the board
>>> drivers dm355, dm365, dm644x and neuros-osd2.
>>>
>>> Signed-off-by: Petr Kulhavy <petr@barix.com>
>>> Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>>
>> Applied to v4.8/cleanup
> 
> This caused a randconfig failure:
> 
> arch/arm/mach-davinci/board-dm365-evm.c: In function 'dm365_evm_init':
> arch/arm/mach-davinci/board-dm365-evm.c:764:17: error: 'dm365_evm_snd_data' undeclared (first use in this function)
>   dm365_init_vc(&dm365_evm_snd_data);
>                  ^~~~~~~~~~~~~~~~~~
> arch/arm/mach-davinci/board-dm365-evm.c:764:17: note: each undeclared identifier is reported only once for each function it appears in
> 
> clearly, the dm365_evm_snd_data is still passed as platform_data
> into the voicecodec. However, I cannot see where it gets used,
> my interpretation of the git log is that it never was, so we should
> remove that too.

Arnd, you are right, this was missed. I will send a patch fixing it soonish.

Regards,
Sekhar

      reply	other threads:[~2016-07-08 11:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-09 13:59 [PATCH] ARM: davinci: remove unused davinci-i2s pdata Petr Kulhavy
2016-06-10 12:48 ` Sekhar Nori
2016-07-08 10:06   ` Arnd Bergmann
2016-07-08 11:05     ` Sekhar Nori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577F88EA.5000602@ti.com \
    --to=nsekhar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.