From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from 6.mo53.mail-out.ovh.net ([46.105.58.122]:54968 "EHLO 6.mo53.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755056AbcGHL2b (ORCPT ); Fri, 8 Jul 2016 07:28:31 -0400 Received: from player159.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo53.mail-out.ovh.net (Postfix) with ESMTP id 3CDB7FF9AC3 for ; Fri, 8 Jul 2016 13:28:28 +0200 (CEST) Subject: Re: [PATCH] usb/gadget: fix gadgetfs aio support To: Sergei Shtylyov , linux-usb@vger.kernel.org References: <577F44EE.20504@laurendeau.net> Cc: Felipe Balbi , stable@vger.kernel.org From: Mathieu Laurendeau Message-ID: <577F8E57.604@laurendeau.net> Date: Fri, 8 Jul 2016 13:28:23 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: I'll resend the patch. Sorry for the noise. Le 08/07/2016 13:01, Sergei Shtylyov a écrit : > Hello. > > On 7/8/2016 9:15 AM, Mathieu Laurendeau wrote: > >> Hi, > > Greetings should not be a part of the patch description. > >> Since commit 7fe3976e0f3ab26f8ffd9430d3d2a19a70f2c8d2 ("gadget: switch >> ep_io_operations to ->read_iter/->write_iter") io submissions fail with >> ENODEV. >> >> Fixes: 7fe3976e0f3a ("gadget: switch ep_io_operations to >> ->read_iter/->write_iter") >> Signed-off-by: Mathieu Laurendeau >> --- >> drivers/usb/gadget/legacy/inode.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c >> index aa3707b..120a03a 100644 >> --- a/drivers/usb/gadget/legacy/inode.c >> +++ b/drivers/usb/gadget/legacy/inode.c >> @@ -542,7 +542,7 @@ static ssize_t ep_aio(struct kiocb *iocb, >> */ >> spin_lock_irq(&epdata->dev->lock); >> value = -ENODEV; >> - if (unlikely(epdata->ep)) >> + if (unlikely(epdata->ep) == NULL) > > This placement of the inner parens doesn't make sense, you should enclose the whole comparison. > > [...] > > MBR, Sergei >