Re: [Qemu-devel] [PATCH 1/5] block: Fragment reads to max transfer length

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

On 07/08/2016 04:56 AM, Kevin Wolf wrote:
> Am 21.06.2016 um 01:39 hat Eric Blake geschrieben:
>> Drivers should be able to rely on the block layer honoring the
>> max transfer length, rather than needing to return -EINVAL
>> (iscsi) or manually fragment things (nbd).  This patch adds
>> the fragmentation in the block layer, after requests have been
>> aligned (fragmenting before alignment would lead to multiple
>> unaligned requests, rather than just the head and tail).
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
> 
> Doesn't build for me:
> 
> block/io.c: In function 'bdrv_aligned_preadv':
> block/io.c:1071:5: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>      return ret;

One of those annoying problems detected at -O2 but not at -O0.  I'll respin.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]