From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756064AbcGHSRx (ORCPT ); Fri, 8 Jul 2016 14:17:53 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:46199 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755609AbcGHSRp (ORCPT ); Fri, 8 Jul 2016 14:17:45 -0400 Message-ID: <577FEE45.5070509@osg.samsung.com> Date: Fri, 08 Jul 2016 19:17:41 +0100 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Samuele Baisi , gregkh@linuxfoundation.org CC: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue. References: <1467718439-13271-1-git-send-email-ciccio87@gmail.com> In-Reply-To: <1467718439-13271-1-git-send-email-ciccio87@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/07/16 12:33, Samuele Baisi wrote: > Removed a blankline after an opening bracket. > > Signed-off-by: Samuele Baisi > --- > drivers/staging/gdm724x/gdm_tty.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c > index eb7e252..ae39663 100644 > --- a/drivers/staging/gdm724x/gdm_tty.c > +++ b/drivers/staging/gdm724x/gdm_tty.c > @@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev *tty_dev, struct device *device) > int j; > > for (i = 0; i < TTY_MAX_COUNT; i++) { > - > gdm = kmalloc(sizeof(*gdm), GFP_KERNEL); > if (!gdm) > return -ENOMEM; > Patch applies cleanly and removes the checkpath issue. Acked-by: Luis de Bethencourt Samuele, It is a good idea to include the issue you are solving in the commit message, in this case it would be: Removed a blankline after an opening bracket. CHECK: Blank lines aren't necessary after an open brace '{' #228: FILE: drivers/staging/gdm724x/gdm_tty.c:228: + for (i = 0; i < TTY_MAX_COUNT; i++) { + Signed-off-by: --- Thanks :) Luis