From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masashi Honma Date: Sat, 9 Jul 2016 12:52:16 +0900 Subject: [Cluster-devel] [RFC 0/7] netlink: Add allocation flag to netlink_unicast() In-Reply-To: <20160708160821.GA2048@redhat.com> References: <1467764916-4983-1-git-send-email-masashi.honma@gmail.com> <577DA3E1.6020103@gmail.com> <20160708160821.GA2048@redhat.com> Message-ID: <578074F0.9030809@gmail.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 2016?07?09? 01:08, David Teigland wrote: > On Thu, Jul 07, 2016 at 09:35:45AM +0900, Masashi Honma wrote: >> At the fs/dlm/netlink.c#dlm_timeout_warn(), >> prepare_data allocates buffer with GFP_NOFS >> and send_data() sends the buffer. >> >> But send_data() uses GFP_KERNEL or GFP_ATOMIC inside it. >> Should it be replaced by GFP_NOFS ? > That's old code that's never been used so it doesn't really matter. > I see. Thank you. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masashi Honma Subject: Re: [RFC 0/7] netlink: Add allocation flag to netlink_unicast() Date: Sat, 9 Jul 2016 12:52:16 +0900 Message-ID: <578074F0.9030809@gmail.com> References: <1467764916-4983-1-git-send-email-masashi.honma@gmail.com> <577DA3E1.6020103@gmail.com> <20160708160821.GA2048@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160708160821.GA2048-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Teigland Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-audit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org, pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org, kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org, kadlec-K40Dz/62t/MgiyqX0sVFJYdd74u8MsAO@public.gmane.org, dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, paul-r2n+y4ga6xFZroRs9YW3xA@public.gmane.org, eparis-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, zbr-i6C2adt8DTjR7s880joybQ@public.gmane.org, pshelar-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org, ccaulfie-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: linux-audit@redhat.com On 2016=E5=B9=B407=E6=9C=8809=E6=97=A5 01:08, David Teigland wrote: > On Thu, Jul 07, 2016 at 09:35:45AM +0900, Masashi Honma wrote: >> At the fs/dlm/netlink.c#dlm_timeout_warn(), >> prepare_data allocates buffer with GFP_NOFS >> and send_data() sends the buffer. >> >> But send_data() uses GFP_KERNEL or GFP_ATOMIC inside it. >> Should it be replaced by GFP_NOFS ? > That's old code that's never been used so it doesn't really matter. > I see. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:33650 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932844AbcGIDwX (ORCPT ); Fri, 8 Jul 2016 23:52:23 -0400 Subject: Re: [RFC 0/7] netlink: Add allocation flag to netlink_unicast() To: David Teigland References: <1467764916-4983-1-git-send-email-masashi.honma@gmail.com> <577DA3E1.6020103@gmail.com> <20160708160821.GA2048@redhat.com> Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, linux-wireless@vger.kernel.org, linux-rdma@vger.kernel.org, linux-audit@redhat.com, cluster-devel@redhat.com, johannes@sipsolutions.net, pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu, dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, paul@paul-moore.com, eparis@redhat.com, zbr@ioremap.net, pshelar@nicira.com, ccaulfie@redhat.com, bsingharora@gmail.com From: Masashi Honma Message-ID: <578074F0.9030809@gmail.com> (sfid-20160709_055227_971172_278DD91C) Date: Sat, 9 Jul 2016 12:52:16 +0900 MIME-Version: 1.0 In-Reply-To: <20160708160821.GA2048@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2016年07月09日 01:08, David Teigland wrote: > On Thu, Jul 07, 2016 at 09:35:45AM +0900, Masashi Honma wrote: >> At the fs/dlm/netlink.c#dlm_timeout_warn(), >> prepare_data allocates buffer with GFP_NOFS >> and send_data() sends the buffer. >> >> But send_data() uses GFP_KERNEL or GFP_ATOMIC inside it. >> Should it be replaced by GFP_NOFS ? > That's old code that's never been used so it doesn't really matter. > I see. Thank you.