From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB593E6749C for ; Mon, 22 Dec 2025 12:13:35 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4dZcVj6l9Xz2xSZ; Mon, 22 Dec 2025 23:13:33 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=185.11.138.130 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1766405613; cv=none; b=IH+4AlhDGgO/uHKPPOk/PzRR+DnX45a0AJVTuHxywmVrgMRc7z3vwGdKMGRXsgyxO2tzUzNhhh3gIg8dgtZRA0RN7y9lBalaFpinodgSf1DxzVXvLL5gcz8v00I7mqvCoeEtmIa0qy9qTbw7KqRgtIWvjFaMQTQH6abqlxu0pO/9KaGvq7TfSTyxm3hORxMXLjrBAgTjStMQSTyCoip/vU6+Wp9Ho1UW6ratS5RoO6JgV8Rq8NA4BErXtAgO+2pL4bKn3O+AmoU3osPLLGlM6Ratbsusvhdyiy/Zmj8aH5sPY7NbhCumm0Lw0BcW+oJEMFvXe/SJH+KK0winuPuhkA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1766405613; c=relaxed/relaxed; bh=ruyy63GwboUn7+9s5l67HuCdYOrz3XONvrYdWrJbZr8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gmW3fzLBhrDBzcaTDrTwE4ve4qb5jgoZld1XlSQQREi9MRRoZqVGWp1vUEcLnX4A50HbUfDM3FZvT+qTzPYIJEcI/+xaeVM4gFUJnzJdHRZbs5oJJXMHJeItFdqq/BKklCnfp4aRABdcWbRaRksodeamxAkcaJGX7oEndk77ysqzwg2/VwEZrZYvKodf1vOmLumvC/1oO7AwoEbzKJIuKvpq0MVl9iB0nOcIwPB4YDC71DVuHmFQFTjfqFjrHzhmrF/Y4zKGyepldwmKTe7zvz7WnDG7QcpKW+YVjFmzSBRTbVO2/w3NhZx5aBMvx5G5h75PqUo7h6x4wm/T6iCJsg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=sntech.de; dkim=pass (2048-bit key; secure) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=vARL6LrT; dkim-atps=neutral; spf=pass (client-ip=185.11.138.130; helo=gloria.sntech.de; envelope-from=heiko@sntech.de; receiver=lists.ozlabs.org) smtp.mailfrom=sntech.de Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=vARL6LrT; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sntech.de (client-ip=185.11.138.130; helo=gloria.sntech.de; envelope-from=heiko@sntech.de; receiver=lists.ozlabs.org) X-Greylist: delayed 1373 seconds by postgrey-1.37 at boromir; Mon, 22 Dec 2025 23:13:30 AEDT Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4dZcVf4sL6z2x99 for ; Mon, 22 Dec 2025 23:13:27 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=ruyy63GwboUn7+9s5l67HuCdYOrz3XONvrYdWrJbZr8=; b=vARL6LrT+8uqJV8RIB88I7spsT VcvqJXHZ2ESVBUXH8pmBDr6rSZIyusgktlb9xTjaFrNyB/hP0IW8zYhI19KcMG8Ehy65OagQl2NpD TvOU/srFlHluBlH5fGPr9Q5HTM6c0cwQoTMUXlnRNLZwLLZbv5gR7+7pFsbX1gH7H4D0EDey8RiC+ G4KGL3ST5Evr8aKquQSLsW7cZKzGnoZJc418sSO+RcGMthBaCf76o8PLPjSP49so+VUv53GzEFn64 jlSn2FLqebJcj1lyUNi7AmfUI1VaA9OeuWjOUgqhJfIOWnKlBB974EL1TCGYkXx+5mU3oT4QIiMD/ MYPy1VZw==; Received: from [194.95.143.137] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vXeQT-0004nF-5v; Mon, 22 Dec 2025 12:50:09 +0100 From: Heiko Stuebner To: Jonathan Cameron , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Joel Stanley , Andrew Jeffery , Krzysztof Kozlowski , Alim Akhtar , Philipp Zabel , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski Cc: Krzysztof Kozlowski Subject: Re: [PATCH 3/3] iio: adc: rockchip: Simplify probe() with local 'dev' Date: Mon, 22 Dec 2025 12:50:07 +0100 Message-ID: <5782401.ejJDZkT8p0@phil> In-Reply-To: <20251221142602.47368-6-krzysztof.kozlowski@oss.qualcomm.com> References: <20251221142602.47368-4-krzysztof.kozlowski@oss.qualcomm.com> <20251221142602.47368-6-krzysztof.kozlowski@oss.qualcomm.com> X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Am Sonntag, 21. Dezember 2025, 15:26:05 Mitteleurop=C3=A4ische Normalzeit s= chrieb Krzysztof Kozlowski: > Simplify the probe function by using a local 'dev' variable instead of > full pointer dereference. This makes several lines shorter, which > allows to avoid wrapping making code more readable. >=20 > Signed-off-by: Krzysztof Kozlowski Yep, makes the code definitly nicer to read Reviewed-by: Heiko Stuebner From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91E73E6749C for ; Mon, 22 Dec 2025 11:50:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5tYdYjX0Boxno6jhSdP1Rp12jatTVMeBk3Tq/MFVXsU=; b=Ebf60+Ybo6MwAP Ww122hcw17oNbuAaL2MfC/Wi4HpuNB3KTwDULo9PffMftFSti8yaXaXaCvQVAwmD7nES9/kQQURUN YFBq1WLHCATbmhUEGfhbphjP17aTBJfxMPrKxk6Krpa4WbJpIpcJjz54nEZDWhLs5OTB3CqHjGUM9 oLOSDLwCAb0Z8VCKY29irLlHSr+y5GC0Cvs8sUTAiWclZ6H9mVxe6UCP+5mrk2xHSLRCcI6G5Jsta H2sHV48qlkGVteR44aQxMjTxYdVHzRxwBhI5TLfP0WIUW7D84FVhjDNp0CrfOSzxgzsq0E+GJICVL wHnqrN/F/rgexJ1dyEQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vXeR3-0000000Di5Q-1QOz; Mon, 22 Dec 2025 11:50:45 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vXeR0-0000000Di3D-0gIA; Mon, 22 Dec 2025 11:50:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=ruyy63GwboUn7+9s5l67HuCdYOrz3XONvrYdWrJbZr8=; b=vARL6LrT+8uqJV8RIB88I7spsT VcvqJXHZ2ESVBUXH8pmBDr6rSZIyusgktlb9xTjaFrNyB/hP0IW8zYhI19KcMG8Ehy65OagQl2NpD TvOU/srFlHluBlH5fGPr9Q5HTM6c0cwQoTMUXlnRNLZwLLZbv5gR7+7pFsbX1gH7H4D0EDey8RiC+ G4KGL3ST5Evr8aKquQSLsW7cZKzGnoZJc418sSO+RcGMthBaCf76o8PLPjSP49so+VUv53GzEFn64 jlSn2FLqebJcj1lyUNi7AmfUI1VaA9OeuWjOUgqhJfIOWnKlBB974EL1TCGYkXx+5mU3oT4QIiMD/ MYPy1VZw==; Received: from [194.95.143.137] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vXeQT-0004nF-5v; Mon, 22 Dec 2025 12:50:09 +0100 From: Heiko Stuebner To: Jonathan Cameron , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Joel Stanley , Andrew Jeffery , Krzysztof Kozlowski , Alim Akhtar , Philipp Zabel , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski Cc: Krzysztof Kozlowski Subject: Re: [PATCH 3/3] iio: adc: rockchip: Simplify probe() with local 'dev' Date: Mon, 22 Dec 2025 12:50:07 +0100 Message-ID: <5782401.ejJDZkT8p0@phil> In-Reply-To: <20251221142602.47368-6-krzysztof.kozlowski@oss.qualcomm.com> References: <20251221142602.47368-4-krzysztof.kozlowski@oss.qualcomm.com> <20251221142602.47368-6-krzysztof.kozlowski@oss.qualcomm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251222_035042_410486_DE552F1F X-CRM114-Status: UNSURE ( 7.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org QW0gU29ubnRhZywgMjEuIERlemVtYmVyIDIwMjUsIDE1OjI2OjA1IE1pdHRlbGV1cm9ww6Rpc2No ZSBOb3JtYWx6ZWl0IHNjaHJpZWIgS3J6eXN6dG9mIEtvemxvd3NraToKPiBTaW1wbGlmeSB0aGUg cHJvYmUgZnVuY3Rpb24gYnkgdXNpbmcgYSBsb2NhbCAnZGV2JyB2YXJpYWJsZSBpbnN0ZWFkIG9m Cj4gZnVsbCBwb2ludGVyIGRlcmVmZXJlbmNlLiAgVGhpcyBtYWtlcyBzZXZlcmFsIGxpbmVzIHNo b3J0ZXIsIHdoaWNoCj4gYWxsb3dzIHRvIGF2b2lkIHdyYXBwaW5nIG1ha2luZyBjb2RlIG1vcmUg cmVhZGFibGUuCj4gCj4gU2lnbmVkLW9mZi1ieTogS3J6eXN6dG9mIEtvemxvd3NraSA8a3J6eXN6 dG9mLmtvemxvd3NraUBvc3MucXVhbGNvbW0uY29tPgoKWWVwLCBtYWtlcyB0aGUgY29kZSBkZWZp bml0bHkgbmljZXIgdG8gcmVhZAoKUmV2aWV3ZWQtYnk6IEhlaWtvIFN0dWVibmVyIDxoZWlrb0Bz bnRlY2guZGU+CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtcm9ja2NoaXAK