From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH 5/7] drm/rockchip: dw-mipi: support HPD poll Date: Mon, 11 Jul 2016 08:46:53 +0800 Message-ID: <5782EC7D.3080202@rock-chips.com> References: <1467968701-15620-1-git-send-email-zyw@rock-chips.com> <1467968701-15620-6-git-send-email-zyw@rock-chips.com> <20160708145211.6bf83d8f.john@metanate.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160708145211.6bf83d8f.john@metanate.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Keeping , Chris Zhong Cc: linux-rockchip@lists.infradead.org, yzq@rock-chips.com, dianders@chromium.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, tfiga@chromium.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNuW5tDA35pyIMDjml6UgMjE6NTIsIEpvaG4gS2VlcGluZyB3cm90ZToKPiBPbiBGcmks ICA4IEp1bCAyMDE2IDE3OjA0OjU5ICswODAwLCBDaHJpcyBaaG9uZyB3cm90ZToKPgo+PiBBdCB0 aGUgZmlyc3QgdGltZSBvZiBiaW5kLCB0aGVyZSBpcyBubyBhbnkgcGFuZWwgYXR0YWNoIGluIG1p cGkuIEFkZCBhCj4+IERSTV9DT05ORUNUT1JfUE9MTF9IUEQgcG9ycGVydHkgdG8gZGV0ZWN0IHRo ZSBwYW5lbCBzdGF0dXMsIHdoZW4gcGFuZWwKPj4gcHJvYmUsIHRoZSBkd19taXBpX2RzaV9ob3N0 X2F0dGFjaCB3b3VsZCBiZSBjYWxsZWQsIHRoZW4gbWlwaS1kc2kgd2lsbAo+PiB0cmlnZ2VyIGEg ZXZlbnQgdG8gbm90aWZ5IHRoZSBkcm0gZnJhbWV3b3JrLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBD aHJpcyBaaG9uZyA8enl3QHJvY2stY2hpcHMuY29tPgo+IENhbiB3ZSBkbyBzb21ldGhpbmcgbGlr ZSB0aGlzIGluc3RlYWQ/ICBXZSBrbm93IHRoYXQgdGhlIHBhbmVsIG11c3QKPiBhbHdheXMgYmUg YXR0YWNoZWQgYW5kIHRoaXMgaGFzIHRoZSBhZHZhbnRhZ2UgdGhhdCB0aGUgZGlzcGxheSBzaXpl IHdpbGwKPiBiZSBrbm93biB3aGVuIHRoZSBmcmFtZWJ1ZmZlciBjb25zb2xlIGxvYWRzLgo+Cj4g LS0gPjggLS0KPiBTdWJqZWN0OiBbUEFUQ0hdIGRybS9yb2NrY2hpcDogZHctbWlwaS1kc2k6IGRl ZmVyIHByb2JlIGlmIHBhbmVsIGlzIG5vdCBsb2FkZWQKPgo+IFRoaXMgZW5zdXJlcyB0aGF0IHRo ZSBvdXRwdXQgcmVzb2x1dGlvbiBpcyBrbm93biBiZWZvcmUgZmJjb24gbG9hZHMuCj4KPiBTaWdu ZWQtb2ZmLWJ5OiBKb2huIEtlZXBpbmcgPGpvaG5AbWV0YW5hdGUuY29tPgo+IC0tLQo+ICAgZHJp dmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNpLmMgfCAxMSArKysrKysrKystLQo+ICAg MSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHctbWlwaS1kc2kuYyBiL2RyaXZlcnMv Z3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5jCj4gaW5kZXggNmVmNWYzYmU4NDY4Li5jMDQ5 OTI2NmQxMTYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGkt ZHNpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHctbWlwaS1kc2kuYwo+IEBA IC0xMTU0LDEwICsxMTU0LDE3IEBAIHN0YXRpYyBpbnQgZHdfbWlwaV9kc2lfYmluZChzdHJ1Y3Qg ZGV2aWNlICpkZXYsIHN0cnVjdCBkZXZpY2UgKm1hc3RlciwKPiAgIAo+ICAgCWRzaS0+ZHNpX2hv c3Qub3BzID0gJmR3X21pcGlfZHNpX2hvc3Rfb3BzOwo+ICAgCWRzaS0+ZHNpX2hvc3QuZGV2ID0g ZGV2Owo+IC0JcmV0dXJuIG1pcGlfZHNpX2hvc3RfcmVnaXN0ZXIoJmRzaS0+ZHNpX2hvc3QpOwo+ ICsJcmV0ID0gbWlwaV9kc2lfaG9zdF9yZWdpc3RlcigmZHNpLT5kc2lfaG9zdCk7Cj4gKwlpZiAo IXJldCAmJiAhZHNpLT5wYW5lbCkgewo+ICsJCW1pcGlfZHNpX2hvc3RfdW5yZWdpc3RlcigmZHNp LT5kc2lfaG9zdCk7Cj4gKwkJZHJtX2VuY29kZXJfY2xlYW51cCgmZHNpLT5lbmNvZGVyKTsKPiAr CQlkcm1fY29ubmVjdG9yX2NsZWFudXAoJmRzaS0+Y29ubmVjdG9yKTsKPiArCQlyZXQgPSAtRVBS T0JFX0RFRkVSOwoKSGkgSm9obgoKRG8geW91IHZlcmlmeSB0aGlzIHBhdGNoPyBJIGRvIHRoZSBz aW1pbGFyIGNoYW5nZSBiZWZvcmUsIGJ1dCBmb3VuZCAKcGFuZWwgY2FuJ3QgcHJvYmUuCgptaXBp X2RzaV9ob3N0X3JlZ2lzdGVyIHdpbGwgY2FsbCBkZXZpY2VfYWRkLCBJIHRoaW5rIHRoZSBwYW5l bCBwcm9iZSAKbmVlZCB0aGlzLgoKU2VlbXMgdGhhdCBtaXBpIHBhbmVsIHByb2JlIHJlcXVlc3Qg bWlwaV9kc2lfaG9zdF9yZWdpc3RlciwgCm1pcGlfZHNpX2hvc3RfcmVnaXN0ZXIgcmVxdWVzdCBw YW5lbCBvbiB5b3VyIHBhdGNoLCBlbmRsZXNzIGxvb3AuCgpUaGFua3MuCgo+ICsJfQo+ICAgCj4g ICBlcnJfcGxscmVmOgo+IC0JY2xrX2Rpc2FibGVfdW5wcmVwYXJlKGRzaS0+cGxscmVmX2Nsayk7 Cj4gKwlpZiAocmV0KQo+ICsJCWNsa19kaXNhYmxlX3VucHJlcGFyZShkc2ktPnBsbHJlZl9jbGsp Owo+ICAgCXJldHVybiByZXQ7Cj4gICB9Cj4gICAKPgo+Cj4KCgotLSAK77ytYXJrIFlhbwoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Mon, 11 Jul 2016 08:46:53 +0800 Subject: [PATCH 5/7] drm/rockchip: dw-mipi: support HPD poll In-Reply-To: <20160708145211.6bf83d8f.john@metanate.com> References: <1467968701-15620-1-git-send-email-zyw@rock-chips.com> <1467968701-15620-6-git-send-email-zyw@rock-chips.com> <20160708145211.6bf83d8f.john@metanate.com> Message-ID: <5782EC7D.3080202@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016?07?08? 21:52, John Keeping wrote: > On Fri, 8 Jul 2016 17:04:59 +0800, Chris Zhong wrote: > >> At the first time of bind, there is no any panel attach in mipi. Add a >> DRM_CONNECTOR_POLL_HPD porperty to detect the panel status, when panel >> probe, the dw_mipi_dsi_host_attach would be called, then mipi-dsi will >> trigger a event to notify the drm framework. >> >> Signed-off-by: Chris Zhong > Can we do something like this instead? We know that the panel must > always be attached and this has the advantage that the display size will > be known when the framebuffer console loads. > > -- >8 -- > Subject: [PATCH] drm/rockchip: dw-mipi-dsi: defer probe if panel is not loaded > > This ensures that the output resolution is known before fbcon loads. > > Signed-off-by: John Keeping > --- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index 6ef5f3be8468..c0499266d116 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -1154,10 +1154,17 @@ static int dw_mipi_dsi_bind(struct device *dev, struct device *master, > > dsi->dsi_host.ops = &dw_mipi_dsi_host_ops; > dsi->dsi_host.dev = dev; > - return mipi_dsi_host_register(&dsi->dsi_host); > + ret = mipi_dsi_host_register(&dsi->dsi_host); > + if (!ret && !dsi->panel) { > + mipi_dsi_host_unregister(&dsi->dsi_host); > + drm_encoder_cleanup(&dsi->encoder); > + drm_connector_cleanup(&dsi->connector); > + ret = -EPROBE_DEFER; Hi John Do you verify this patch? I do the similar change before, but found panel can't probe. mipi_dsi_host_register will call device_add, I think the panel probe need this. Seems that mipi panel probe request mipi_dsi_host_register, mipi_dsi_host_register request panel on your patch, endless loop. Thanks. > + } > > err_pllref: > - clk_disable_unprepare(dsi->pllref_clk); > + if (ret) > + clk_disable_unprepare(dsi->pllref_clk); > return ret; > } > > > > -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757408AbcGKArJ (ORCPT ); Sun, 10 Jul 2016 20:47:09 -0400 Received: from regular1.263xmail.com ([211.150.99.136]:43126 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003AbcGKArG (ORCPT ); Sun, 10 Jul 2016 20:47:06 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 5/7] drm/rockchip: dw-mipi: support HPD poll To: John Keeping , Chris Zhong References: <1467968701-15620-1-git-send-email-zyw@rock-chips.com> <1467968701-15620-6-git-send-email-zyw@rock-chips.com> <20160708145211.6bf83d8f.john@metanate.com> Cc: dianders@chromium.org, tfiga@chromium.org, heiko@sntech.de, yzq@rock-chips.com, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Mark yao Message-ID: <5782EC7D.3080202@rock-chips.com> Date: Mon, 11 Jul 2016 08:46:53 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20160708145211.6bf83d8f.john@metanate.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年07月08日 21:52, John Keeping wrote: > On Fri, 8 Jul 2016 17:04:59 +0800, Chris Zhong wrote: > >> At the first time of bind, there is no any panel attach in mipi. Add a >> DRM_CONNECTOR_POLL_HPD porperty to detect the panel status, when panel >> probe, the dw_mipi_dsi_host_attach would be called, then mipi-dsi will >> trigger a event to notify the drm framework. >> >> Signed-off-by: Chris Zhong > Can we do something like this instead? We know that the panel must > always be attached and this has the advantage that the display size will > be known when the framebuffer console loads. > > -- >8 -- > Subject: [PATCH] drm/rockchip: dw-mipi-dsi: defer probe if panel is not loaded > > This ensures that the output resolution is known before fbcon loads. > > Signed-off-by: John Keeping > --- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index 6ef5f3be8468..c0499266d116 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -1154,10 +1154,17 @@ static int dw_mipi_dsi_bind(struct device *dev, struct device *master, > > dsi->dsi_host.ops = &dw_mipi_dsi_host_ops; > dsi->dsi_host.dev = dev; > - return mipi_dsi_host_register(&dsi->dsi_host); > + ret = mipi_dsi_host_register(&dsi->dsi_host); > + if (!ret && !dsi->panel) { > + mipi_dsi_host_unregister(&dsi->dsi_host); > + drm_encoder_cleanup(&dsi->encoder); > + drm_connector_cleanup(&dsi->connector); > + ret = -EPROBE_DEFER; Hi John Do you verify this patch? I do the similar change before, but found panel can't probe. mipi_dsi_host_register will call device_add, I think the panel probe need this. Seems that mipi panel probe request mipi_dsi_host_register, mipi_dsi_host_register request panel on your patch, endless loop. Thanks. > + } > > err_pllref: > - clk_disable_unprepare(dsi->pllref_clk); > + if (ret) > + clk_disable_unprepare(dsi->pllref_clk); > return ret; > } > > > > -- Ｍark Yao