From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Wu Subject: [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed Date: Mon, 11 Jul 2016 10:51:26 +0800 Message-ID: <578309AE.1080704@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Sender: linux-kernel-owner@vger.kernel.org To: boris.ostrovsky@oracle.com, david.vrabel@citrix.com, jgross@suse.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, wu.wubin@huawei.com List-Id: linux-scsi@vger.kernel.org During scsi command queueing, if mapping data fails, we need to reclaim the failed request. Otherwise, the garbage request will be pushed into the ring for the backend to work. Signed-off-by: Bin Wu --- drivers/scsi/xen-scsifront.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c index 9dc8687..655163d 100644 --- a/drivers/scsi/xen-scsifront.c +++ b/drivers/scsi/xen-scsifront.c @@ -565,6 +565,7 @@ static int scsifront_queuecommand(struct Scsi_Host *shost, err = map_data_for_request(info, sc, ring_req, shadow); if (err < 0) { pr_debug("%s: err %d\n", __func__, err); + info->ring.req_prod_pvt--; scsifront_put_rqid(info, rqid); scsifront_return(info); spin_unlock_irqrestore(shost->host_lock, flags); -- 2.3.2 (Apple Git-55) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757576AbcGKCxV (ORCPT ); Sun, 10 Jul 2016 22:53:21 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:11766 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757265AbcGKCxT (ORCPT ); Sun, 10 Jul 2016 22:53:19 -0400 To: , , , , , , , , From: Bin Wu Subject: [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed Message-ID: <578309AE.1080704@huawei.com> Date: Mon, 11 Jul 2016 10:51:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.24.77] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.578309EE.005B,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 819c37a3f5e3ebcd111deb4658397e74 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org During scsi command queueing, if mapping data fails, we need to reclaim the failed request. Otherwise, the garbage request will be pushed into the ring for the backend to work. Signed-off-by: Bin Wu --- drivers/scsi/xen-scsifront.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c index 9dc8687..655163d 100644 --- a/drivers/scsi/xen-scsifront.c +++ b/drivers/scsi/xen-scsifront.c @@ -565,6 +565,7 @@ static int scsifront_queuecommand(struct Scsi_Host *shost, err = map_data_for_request(info, sc, ring_req, shadow); if (err < 0) { pr_debug("%s: err %d\n", __func__, err); + info->ring.req_prod_pvt--; scsifront_put_rqid(info, rqid); scsifront_return(info); spin_unlock_irqrestore(shost->host_lock, flags); -- 2.3.2 (Apple Git-55)