From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com. [210.118.77.13]) by gmr-mx.google.com with ESMTPS id c11si145694pfc.2.2016.07.10.22.48.34 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 10 Jul 2016 22:48:34 -0700 (PDT) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OA400G8DYSU9Q10@mailout3.w1.samsung.com> for rtc-linux@googlegroups.com; Mon, 11 Jul 2016 06:48:31 +0100 (BST) Subject: [rtc-linux] Re: [PATCH 1/3] Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data" To: Randy Li References: <1468056226-19128-1-git-send-email-ayaka@soulik.info> <1468056226-19128-2-git-send-email-ayaka@soulik.info> Cc: alexandre.belloni@free-electrons.com, a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5783332D.7010809@samsung.com> Date: Mon, 11 Jul 2016 07:48:29 +0200 MIME-version: 1.0 In-reply-to: <1468056226-19128-2-git-send-email-ayaka@soulik.info> Content-type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 07/09/2016 11:23 AM, Randy Li wrote: > This reverts commit 8792f7772f4f40ffc68bad5f28311205584b734d. > The s3c6410 rtc don't use rtc_src property, that property is designed > for Exynos5250 and Exynos5440. The problem reported in the commit > I mentioned should be fixed in the other way. ... so you break in this commit all the newer platforms because the rtc_src clock won't be enabled. Does not look right. Best regards, Krzysztof > > Signed-off-by: Randy Li > --- > drivers/rtc/rtc-s3c.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c > index d01ad7e..5dc18ca 100644 > --- a/drivers/rtc/rtc-s3c.c > +++ b/drivers/rtc/rtc-s3c.c > @@ -801,7 +801,6 @@ static struct s3c_rtc_data const s3c2443_rtc_data = { > > static struct s3c_rtc_data const s3c6410_rtc_data = { > .max_user_freq = 32768, > - .needs_src_clk = true, > .irq_handler = s3c6410_rtc_irq, > .set_freq = s3c6410_rtc_setfreq, > .enable_tick = s3c6410_rtc_enable_tick, > -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 1/3] Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data" Date: Mon, 11 Jul 2016 07:48:29 +0200 Message-ID: <5783332D.7010809@samsung.com> References: <1468056226-19128-1-git-send-email-ayaka@soulik.info> <1468056226-19128-2-git-send-email-ayaka@soulik.info> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-reply-to: <1468056226-19128-2-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Randy Li Cc: alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-samsung-soc@vger.kernel.org On 07/09/2016 11:23 AM, Randy Li wrote: > This reverts commit 8792f7772f4f40ffc68bad5f28311205584b734d. > The s3c6410 rtc don't use rtc_src property, that property is designed > for Exynos5250 and Exynos5440. The problem reported in the commit > I mentioned should be fixed in the other way. ... so you break in this commit all the newer platforms because the rtc_src clock won't be enabled. Does not look right. Best regards, Krzysztof > > Signed-off-by: Randy Li > --- > drivers/rtc/rtc-s3c.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c > index d01ad7e..5dc18ca 100644 > --- a/drivers/rtc/rtc-s3c.c > +++ b/drivers/rtc/rtc-s3c.c > @@ -801,7 +801,6 @@ static struct s3c_rtc_data const s3c2443_rtc_data = { > > static struct s3c_rtc_data const s3c6410_rtc_data = { > .max_user_freq = 32768, > - .needs_src_clk = true, > .irq_handler = s3c6410_rtc_irq, > .set_freq = s3c6410_rtc_setfreq, > .enable_tick = s3c6410_rtc_enable_tick, > -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Mon, 11 Jul 2016 07:48:29 +0200 Subject: [PATCH 1/3] Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data" In-Reply-To: <1468056226-19128-2-git-send-email-ayaka@soulik.info> References: <1468056226-19128-1-git-send-email-ayaka@soulik.info> <1468056226-19128-2-git-send-email-ayaka@soulik.info> Message-ID: <5783332D.7010809@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/09/2016 11:23 AM, Randy Li wrote: > This reverts commit 8792f7772f4f40ffc68bad5f28311205584b734d. > The s3c6410 rtc don't use rtc_src property, that property is designed > for Exynos5250 and Exynos5440. The problem reported in the commit > I mentioned should be fixed in the other way. ... so you break in this commit all the newer platforms because the rtc_src clock won't be enabled. Does not look right. Best regards, Krzysztof > > Signed-off-by: Randy Li > --- > drivers/rtc/rtc-s3c.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c > index d01ad7e..5dc18ca 100644 > --- a/drivers/rtc/rtc-s3c.c > +++ b/drivers/rtc/rtc-s3c.c > @@ -801,7 +801,6 @@ static struct s3c_rtc_data const s3c2443_rtc_data = { > > static struct s3c_rtc_data const s3c6410_rtc_data = { > .max_user_freq = 32768, > - .needs_src_clk = true, > .irq_handler = s3c6410_rtc_irq, > .set_freq = s3c6410_rtc_setfreq, > .enable_tick = s3c6410_rtc_enable_tick, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757830AbcGKFsh (ORCPT ); Mon, 11 Jul 2016 01:48:37 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:58920 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750880AbcGKFse (ORCPT ); Mon, 11 Jul 2016 01:48:34 -0400 X-AuditID: cbfec7f5-f792a6d000001302-0b-5783332e7e48 Subject: Re: [PATCH 1/3] Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data" To: Randy Li References: <1468056226-19128-1-git-send-email-ayaka@soulik.info> <1468056226-19128-2-git-send-email-ayaka@soulik.info> Cc: alexandre.belloni@free-electrons.com, a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5783332D.7010809@samsung.com> Date: Mon, 11 Jul 2016 07:48:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1468056226-19128-2-git-send-email-ayaka@soulik.info> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmkeLIzCtJLcpLzFFi42I5/e/4NV094+ZwgyPLzSyWXLzKbtFxbTGT xau7vxgt5h85x2rx+oWhxabH11gtLu+aw2Yx4/w+JotDU/cyWiy9fpHJonXvEXaL/Z0djA48 HmvmrWH0uHztIrPHk00XGT32TDzJ5rFpVSebx+Yl9R59W1YxejTfnc7qMX3eTyaPz5vkArii uGxSUnMyy1KL9O0SuDL2vn/GVLCKo2JK/2vWBsY7bF2MnBwSAiYSHcensUDYYhIX7q0HinNx CAksZZQ4+X81E4TzjFHi6s8ljCBVwgKJEp82PGIGsUUEFCSWL9jOBGILCVRKnL9/jgWkgVlg CZPEn5udYEVsAsYSm5cvAVvHK6Alsf1gK9g6FgFViUfNz8GGigpESMza/oMJokZQ4sfke2A1 nAJOEg+ezgfq5QAaqidx/6IWSJhZQF5i85q3zBMYBWYh6ZiFUDULSdUCRuZVjKKppckFxUnp uUZ6xYm5xaV56XrJ+bmbGCFR9HUH49JjVocYBTgYlXh4A7Y3hQuxJpYVV+YeYpTgYFYS4T0q 3xwuxJuSWFmVWpQfX1Sak1p8iFGag0VJnHfmrvchQgLpiSWp2ampBalFMFkmDk6pBkZuwy5J P1NhfxmPb7a8b6NXfV019e4h1eum72YtWCXBWrlyukeHl+/mX75zLttw683n3FdbP01wxZI3 aqcKvsqIrnpiyWx+QrlBhcNk6UqLEu2FifM25r/assp36bNI9qtOnD0dVaKaU5mvtDrz64ZV /3Gf38H0fEfWa84NwQf2Rdc7Xz7pJazEUpyRaKjFXFScCABgWPx1ngIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/09/2016 11:23 AM, Randy Li wrote: > This reverts commit 8792f7772f4f40ffc68bad5f28311205584b734d. > The s3c6410 rtc don't use rtc_src property, that property is designed > for Exynos5250 and Exynos5440. The problem reported in the commit > I mentioned should be fixed in the other way. ... so you break in this commit all the newer platforms because the rtc_src clock won't be enabled. Does not look right. Best regards, Krzysztof > > Signed-off-by: Randy Li > --- > drivers/rtc/rtc-s3c.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c > index d01ad7e..5dc18ca 100644 > --- a/drivers/rtc/rtc-s3c.c > +++ b/drivers/rtc/rtc-s3c.c > @@ -801,7 +801,6 @@ static struct s3c_rtc_data const s3c2443_rtc_data = { > > static struct s3c_rtc_data const s3c6410_rtc_data = { > .max_user_freq = 32768, > - .needs_src_clk = true, > .irq_handler = s3c6410_rtc_irq, > .set_freq = s3c6410_rtc_setfreq, > .enable_tick = s3c6410_rtc_enable_tick, >