From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keerthy Subject: Re: [PATCH 3/3] arm: dts: thermal: add thermal/auxadc node. Date: Mon, 11 Jul 2016 14:39:26 +0530 Message-ID: <57836246.3010800@ti.com> References: <1467882386-40544-1-git-send-email-dawei.chien@mediatek.com> <1467882386-40544-4-git-send-email-dawei.chien@mediatek.com> <577E465D.8070004@ti.com> <1468227415.15776.34.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1468227415.15776.34.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: dawei chien Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Pawel Moll , Ian Campbell , Erin Lo , linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Eduardo Valentin , Fan Chen , Rob Herring , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sascha Hauer , Kumar Gala , Matthias Brugger , Yingjoe Chen , Zhang Rui , Eddie Huang , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mediatek@lists.infradead.org On Monday 11 July 2016 02:26 PM, dawei chien wrote: > Dear Keerthy, > > On Thu, 2016-07-07 at 17:39 +0530, Keerthy wrote: >> >> On Thursday 07 July 2016 02:36 PM, Dawei Chien wrote: >>> This adds the thermal controller and auxadc nodes >>> to the Mediatek MT2701 dtsi file. >>> >>> Signed-off-by: Dawei Chien >>> --- >>> This patch depned on: >>> https://patchwork.kernel.org/patch/9213545/ >>> --- >>> arch/arm/boot/dts/mt2701.dtsi | 43 +++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 43 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi >>> index 2ac8b50..0834a23 100644 >>> --- a/arch/arm/boot/dts/mt2701.dtsi >>> +++ b/arch/arm/boot/dts/mt2701.dtsi >>> @@ -77,6 +77,36 @@ >>> #clock-cells = <0>; >>> }; >>> >>> + thermal-zones { >>> + cpu_thermal: cpu_thermal { >>> + polling-delay-passive = <1000>; /* milliseconds */ >>> + polling-delay = <1000>; /* milliseconds */ >>> + >>> + thermal-sensors = <&thermal 0>; >>> + sustainable-power = <1000>; >>> + >>> + trips { >>> + threshold: trip-point@0 { >>> + temperature = <68000>; >>> + hysteresis = <2000>; >>> + type = "passive"; >>> + }; >>> + >>> + target: trip-point@1 { >>> + temperature = <85000>; >>> + hysteresis = <2000>; >>> + type = "passive"; >>> + }; >>> + >>> + cpu_crit: cpu_crit@0 { >>> + temperature = <115000>; >>> + hysteresis = <2000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + }; >>> + >> >> are there any corresponding cooling-maps? > > Since MT2701 does not register CPUFREQ cooling device and its' own > device node, I could not add cooling-maps so far. > Could we add cooling map after CPUFREQ ready, thank you. Okay. I was curious to know about the cooling agents. > >> >>> timer { >>> compatible = "arm,armv7-timer"; >>> interrupt-parent = <&gic>; >>> @@ -183,4 +213,17 @@ >>> clocks = <&uart_clk>; >>> status = "disabled"; >>> }; >>> + >>> + thermal: thermal@1100b000 { >>> + #thermal-sensor-cells = <0>; >>> + compatible = "mediatek,mt2701-thermal"; >>> + reg = <0 0x1100b000 0 0x1000>; >>> + interrupts = ; >>> + clocks = <&pericfg CLK_PERI_THERM>, <&pericfg CLK_PERI_AUXADC>; >>> + clock-names = "therm", "auxadc"; >>> + resets = <&pericfg 0x10>; >>> + reset-names = "therm"; >>> + mediatek,auxadc = <&auxadc>; >>> + mediatek,apmixedsys = <&apmixedsys>; >>> + }; >>> }; >>> > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: a0393675@ti.com (Keerthy) Date: Mon, 11 Jul 2016 14:39:26 +0530 Subject: [PATCH 3/3] arm: dts: thermal: add thermal/auxadc node. In-Reply-To: <1468227415.15776.34.camel@mtksdaap41> References: <1467882386-40544-1-git-send-email-dawei.chien@mediatek.com> <1467882386-40544-4-git-send-email-dawei.chien@mediatek.com> <577E465D.8070004@ti.com> <1468227415.15776.34.camel@mtksdaap41> Message-ID: <57836246.3010800@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 11 July 2016 02:26 PM, dawei chien wrote: > Dear Keerthy, > > On Thu, 2016-07-07 at 17:39 +0530, Keerthy wrote: >> >> On Thursday 07 July 2016 02:36 PM, Dawei Chien wrote: >>> This adds the thermal controller and auxadc nodes >>> to the Mediatek MT2701 dtsi file. >>> >>> Signed-off-by: Dawei Chien >>> --- >>> This patch depned on: >>> https://patchwork.kernel.org/patch/9213545/ >>> --- >>> arch/arm/boot/dts/mt2701.dtsi | 43 +++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 43 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi >>> index 2ac8b50..0834a23 100644 >>> --- a/arch/arm/boot/dts/mt2701.dtsi >>> +++ b/arch/arm/boot/dts/mt2701.dtsi >>> @@ -77,6 +77,36 @@ >>> #clock-cells = <0>; >>> }; >>> >>> + thermal-zones { >>> + cpu_thermal: cpu_thermal { >>> + polling-delay-passive = <1000>; /* milliseconds */ >>> + polling-delay = <1000>; /* milliseconds */ >>> + >>> + thermal-sensors = <&thermal 0>; >>> + sustainable-power = <1000>; >>> + >>> + trips { >>> + threshold: trip-point at 0 { >>> + temperature = <68000>; >>> + hysteresis = <2000>; >>> + type = "passive"; >>> + }; >>> + >>> + target: trip-point at 1 { >>> + temperature = <85000>; >>> + hysteresis = <2000>; >>> + type = "passive"; >>> + }; >>> + >>> + cpu_crit: cpu_crit at 0 { >>> + temperature = <115000>; >>> + hysteresis = <2000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + }; >>> + >> >> are there any corresponding cooling-maps? > > Since MT2701 does not register CPUFREQ cooling device and its' own > device node, I could not add cooling-maps so far. > Could we add cooling map after CPUFREQ ready, thank you. Okay. I was curious to know about the cooling agents. > >> >>> timer { >>> compatible = "arm,armv7-timer"; >>> interrupt-parent = <&gic>; >>> @@ -183,4 +213,17 @@ >>> clocks = <&uart_clk>; >>> status = "disabled"; >>> }; >>> + >>> + thermal: thermal at 1100b000 { >>> + #thermal-sensor-cells = <0>; >>> + compatible = "mediatek,mt2701-thermal"; >>> + reg = <0 0x1100b000 0 0x1000>; >>> + interrupts = ; >>> + clocks = <&pericfg CLK_PERI_THERM>, <&pericfg CLK_PERI_AUXADC>; >>> + clock-names = "therm", "auxadc"; >>> + resets = <&pericfg 0x10>; >>> + reset-names = "therm"; >>> + mediatek,auxadc = <&auxadc>; >>> + mediatek,apmixedsys = <&apmixedsys>; >>> + }; >>> }; >>> > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753742AbcGKJLB (ORCPT ); Mon, 11 Jul 2016 05:11:01 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:37413 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753296AbcGKJK7 (ORCPT ); Mon, 11 Jul 2016 05:10:59 -0400 Subject: Re: [PATCH 3/3] arm: dts: thermal: add thermal/auxadc node. To: dawei chien References: <1467882386-40544-1-git-send-email-dawei.chien@mediatek.com> <1467882386-40544-4-git-send-email-dawei.chien@mediatek.com> <577E465D.8070004@ti.com> <1468227415.15776.34.camel@mtksdaap41> CC: Zhang Rui , Eduardo Valentin , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Matthias Brugger , , , , , , , Sascha Hauer , Fan Chen , Eddie Huang , Yingjoe Chen , Erin Lo From: Keerthy Message-ID: <57836246.3010800@ti.com> Date: Mon, 11 Jul 2016 14:39:26 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1468227415.15776.34.camel@mtksdaap41> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 11 July 2016 02:26 PM, dawei chien wrote: > Dear Keerthy, > > On Thu, 2016-07-07 at 17:39 +0530, Keerthy wrote: >> >> On Thursday 07 July 2016 02:36 PM, Dawei Chien wrote: >>> This adds the thermal controller and auxadc nodes >>> to the Mediatek MT2701 dtsi file. >>> >>> Signed-off-by: Dawei Chien >>> --- >>> This patch depned on: >>> https://patchwork.kernel.org/patch/9213545/ >>> --- >>> arch/arm/boot/dts/mt2701.dtsi | 43 +++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 43 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi >>> index 2ac8b50..0834a23 100644 >>> --- a/arch/arm/boot/dts/mt2701.dtsi >>> +++ b/arch/arm/boot/dts/mt2701.dtsi >>> @@ -77,6 +77,36 @@ >>> #clock-cells = <0>; >>> }; >>> >>> + thermal-zones { >>> + cpu_thermal: cpu_thermal { >>> + polling-delay-passive = <1000>; /* milliseconds */ >>> + polling-delay = <1000>; /* milliseconds */ >>> + >>> + thermal-sensors = <&thermal 0>; >>> + sustainable-power = <1000>; >>> + >>> + trips { >>> + threshold: trip-point@0 { >>> + temperature = <68000>; >>> + hysteresis = <2000>; >>> + type = "passive"; >>> + }; >>> + >>> + target: trip-point@1 { >>> + temperature = <85000>; >>> + hysteresis = <2000>; >>> + type = "passive"; >>> + }; >>> + >>> + cpu_crit: cpu_crit@0 { >>> + temperature = <115000>; >>> + hysteresis = <2000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + }; >>> + >> >> are there any corresponding cooling-maps? > > Since MT2701 does not register CPUFREQ cooling device and its' own > device node, I could not add cooling-maps so far. > Could we add cooling map after CPUFREQ ready, thank you. Okay. I was curious to know about the cooling agents. > >> >>> timer { >>> compatible = "arm,armv7-timer"; >>> interrupt-parent = <&gic>; >>> @@ -183,4 +213,17 @@ >>> clocks = <&uart_clk>; >>> status = "disabled"; >>> }; >>> + >>> + thermal: thermal@1100b000 { >>> + #thermal-sensor-cells = <0>; >>> + compatible = "mediatek,mt2701-thermal"; >>> + reg = <0 0x1100b000 0 0x1000>; >>> + interrupts = ; >>> + clocks = <&pericfg CLK_PERI_THERM>, <&pericfg CLK_PERI_AUXADC>; >>> + clock-names = "therm", "auxadc"; >>> + resets = <&pericfg 0x10>; >>> + reset-names = "therm"; >>> + mediatek,auxadc = <&auxadc>; >>> + mediatek,apmixedsys = <&apmixedsys>; >>> + }; >>> }; >>> > >