From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [Xen-devel] [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed Date: Mon, 11 Jul 2016 10:50:44 +0100 Message-ID: <57836BF4.9090000@citrix.com> References: <578309AE.1080704@huawei.com> <578367E8.2050601@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <578367E8.2050601@suse.com> Sender: linux-kernel-owner@vger.kernel.org To: Juergen Gross , Bin Wu , boris.ostrovsky@oracle.com, david.vrabel@citrix.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On 11/07/16 10:33, Juergen Gross wrote: > On 11/07/16 04:51, Bin Wu wrote: >> During scsi command queueing, if mapping data fails, we need to >> reclaim the failed request. Otherwise, the garbage request will >> be pushed into the ring for the backend to work. > > Well spotted. There is another instance of this problem in > scsifront_action_handler(). Would you mind correcting this one, too? Would it make more sense to advance req_prod_pvt only if the request has been successfully created? David >> Signed-off-by: Bin Wu >> --- >> drivers/scsi/xen-scsifront.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c >> index 9dc8687..655163d 100644 >> --- a/drivers/scsi/xen-scsifront.c >> +++ b/drivers/scsi/xen-scsifront.c >> @@ -565,6 +565,7 @@ static int scsifront_queuecommand(struct Scsi_Host >> *shost, >> err = map_data_for_request(info, sc, ring_req, shadow); >> if (err < 0) { >> pr_debug("%s: err %d\n", __func__, err); >> + info->ring.req_prod_pvt--; >> scsifront_put_rqid(info, rqid); >> scsifront_return(info); >> spin_unlock_irqrestore(shost->host_lock, flags); > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757883AbcGKJvO (ORCPT ); Mon, 11 Jul 2016 05:51:14 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:12423 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847AbcGKJvN (ORCPT ); Mon, 11 Jul 2016 05:51:13 -0400 X-IronPort-AV: E=Sophos;i="5.28,345,1464652800"; d="scan'208";a="372388281" Subject: Re: [Xen-devel] [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed To: Juergen Gross , Bin Wu , , , , , , , References: <578309AE.1080704@huawei.com> <578367E8.2050601@suse.com> From: David Vrabel Message-ID: <57836BF4.9090000@citrix.com> Date: Mon, 11 Jul 2016 10:50:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <578367E8.2050601@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/16 10:33, Juergen Gross wrote: > On 11/07/16 04:51, Bin Wu wrote: >> During scsi command queueing, if mapping data fails, we need to >> reclaim the failed request. Otherwise, the garbage request will >> be pushed into the ring for the backend to work. > > Well spotted. There is another instance of this problem in > scsifront_action_handler(). Would you mind correcting this one, too? Would it make more sense to advance req_prod_pvt only if the request has been successfully created? David >> Signed-off-by: Bin Wu >> --- >> drivers/scsi/xen-scsifront.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c >> index 9dc8687..655163d 100644 >> --- a/drivers/scsi/xen-scsifront.c >> +++ b/drivers/scsi/xen-scsifront.c >> @@ -565,6 +565,7 @@ static int scsifront_queuecommand(struct Scsi_Host >> *shost, >> err = map_data_for_request(info, sc, ring_req, shadow); >> if (err < 0) { >> pr_debug("%s: err %d\n", __func__, err); >> + info->ring.req_prod_pvt--; >> scsifront_put_rqid(info, rqid); >> scsifront_return(info); >> spin_unlock_irqrestore(shost->host_lock, flags); > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel >