From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, davem@davemloft.net, jcmvbkbc@gmail.com,
colin.king@canonical.com, tklauser@distanz.ch,
thierry.reding@gmail.com
Subject: Re: [PATCH net 1/2] net: ethoc: Fix early error paths
Date: Mon, 11 Jul 2016 10:15:05 -0700 [thread overview]
Message-ID: <5783D419.5070702@gmail.com> (raw)
In-Reply-To: <20160711171143.GB8540@lunn.ch>
Hi Andrew,
On 07/11/2016 10:11 AM, Andrew Lunn wrote:
> On Mon, Jul 11, 2016 at 10:04:10AM -0700, Florian Fainelli wrote:
>> In case any operation fails before we can successfully go the point
>> where we would register a MDIO bus, we would be going to an error label
>> which involves unregistering then freeing this yet to be created MDIO
>> bus. Update all error paths to go to label free which is the only one
>> valid until either the clock is enabled, or the MDIO bus is allocated
>> and registered. This fixes kernel panics such as this one:
>>
>> Fixes: a1702857724f ("net: Add support for the OpenCores 10/100 Mbps Ethernet MAC.")
>
> Hi Florian
>
> Did you intend to paste a panic here?
I did, and then realized this was not so helpful since the NULL pointer
de-reference was fairly obvious, the driver is also not widely used
(AFAICT), I will respin the commit message to remove the last sentence,
thanks!
--
Florian
next prev parent reply other threads:[~2016-07-11 17:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 17:04 [PATCH net 0/2] net: ethoc: Error path and transmit fixes Florian Fainelli
2016-07-11 17:04 ` [PATCH net 1/2] net: ethoc: Fix early error paths Florian Fainelli
2016-07-11 17:11 ` Andrew Lunn
2016-07-11 17:15 ` Florian Fainelli [this message]
2016-07-11 17:04 ` [PATCH net 2/2] net: ethoc: Correctly pad short packets Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5783D419.5070702@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=jcmvbkbc@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.