From: Wan Zongshun <vw@iommu.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: devicetree@vger.kernel.org, jason@lakedaemon.net,
Wan Zongshun <mcuos.com@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
Thomas Gleixner <tglx@linutronix.de>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 02/10] irqchip: add irqchip driver for nuc900
Date: Tue, 12 Jul 2016 15:04:42 +0800 [thread overview]
Message-ID: <5784968A.7080007@iommu.org> (raw)
In-Reply-To: <1761342.TGgYi16yul@wuerfel>
On 2016年07月11日 23:46, Arnd Bergmann wrote:
> On Sunday, July 10, 2016 3:27:22 PM CEST Wan Zongshun wrote:
>> +
>> +#if !defined(CONFIG_SOC_NUC900)
>> #define NR_IRQS (IRQ_ADC+1)
>> +#else
>> +#define NR_IRQS 62
>> +#endif
>>
>
> The Kconfig symbols are a bit confusing here: CONFIG_SOC_NUC900
> controls the compilation of the soc_device driver, but I guess
> what you actually mean here is CONFIG_SOC_NUC970, which is the
> support for the actual chip.
>
> Maybe rename the former to something less confusing and change
> this to CONFIG_SOC_NUC970?
You are right, it should _NUC970. Many thanks!
>
> Ideally, this should just go away once we use SPARSE_IRQ.
This platform also can use SPARSE_IRQ? this just a simple irq map and no
more irq number in this Soc.
>
> Arnd
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
WARNING: multiple messages have this Message-ID (diff)
From: vw@iommu.org (Wan Zongshun)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 02/10] irqchip: add irqchip driver for nuc900
Date: Tue, 12 Jul 2016 15:04:42 +0800 [thread overview]
Message-ID: <5784968A.7080007@iommu.org> (raw)
In-Reply-To: <1761342.TGgYi16yul@wuerfel>
On 2016?07?11? 23:46, Arnd Bergmann wrote:
> On Sunday, July 10, 2016 3:27:22 PM CEST Wan Zongshun wrote:
>> +
>> +#if !defined(CONFIG_SOC_NUC900)
>> #define NR_IRQS (IRQ_ADC+1)
>> +#else
>> +#define NR_IRQS 62
>> +#endif
>>
>
> The Kconfig symbols are a bit confusing here: CONFIG_SOC_NUC900
> controls the compilation of the soc_device driver, but I guess
> what you actually mean here is CONFIG_SOC_NUC970, which is the
> support for the actual chip.
>
> Maybe rename the former to something less confusing and change
> this to CONFIG_SOC_NUC970?
You are right, it should _NUC970. Many thanks!
>
> Ideally, this should just go away once we use SPARSE_IRQ.
This platform also can use SPARSE_IRQ? this just a simple irq map and no
more irq number in this Soc.
>
> Arnd
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
next prev parent reply other threads:[~2016-07-12 7:04 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-10 7:27 [PATCH v2 00/10] ARM: NUC900: Add NUC970 SoC support Wan Zongshun
2016-07-10 7:27 ` Wan Zongshun
2016-07-10 7:27 ` Wan Zongshun
2016-07-10 7:27 ` [PATCH v2 01/10] ARM: NUC900: Add nuc970 machine support Wan Zongshun
2016-07-10 7:27 ` Wan Zongshun
2016-07-10 22:11 ` Arnd Bergmann
2016-07-10 22:11 ` Arnd Bergmann
2016-07-11 16:04 ` Arnd Bergmann
2016-07-11 16:04 ` Arnd Bergmann
2016-07-11 16:04 ` Arnd Bergmann
2016-07-12 4:30 ` Wan Zongshun
2016-07-12 4:30 ` Wan Zongshun
2016-07-12 7:14 ` Wan Zongshun
2016-07-12 7:14 ` Wan Zongshun
2016-07-12 8:23 ` Arnd Bergmann
2016-07-12 8:23 ` Arnd Bergmann
2016-07-10 7:27 ` [PATCH v2 02/10] irqchip: add irqchip driver for nuc900 Wan Zongshun
2016-07-10 7:27 ` Wan Zongshun
2016-07-10 7:27 ` Wan Zongshun
2016-07-10 21:51 ` Paul Gortmaker
2016-07-10 21:51 ` Paul Gortmaker
2016-07-11 2:19 ` Wan Zongshun
2016-07-11 2:19 ` Wan Zongshun
2016-07-11 15:46 ` Arnd Bergmann
2016-07-11 15:46 ` Arnd Bergmann
2016-07-12 7:04 ` Wan Zongshun [this message]
2016-07-12 7:04 ` Wan Zongshun
2016-07-12 8:26 ` Arnd Bergmann
2016-07-12 8:26 ` Arnd Bergmann
2016-07-12 8:26 ` Arnd Bergmann
2016-07-14 8:52 ` Wan Zongshun
2016-07-14 8:52 ` Wan Zongshun
2016-07-14 11:09 ` Arnd Bergmann
2016-07-14 11:09 ` Arnd Bergmann
2016-07-13 20:09 ` Jason Cooper
2016-07-13 20:09 ` Jason Cooper
2016-07-13 20:09 ` Jason Cooper
2016-07-13 20:09 ` Jason Cooper
2016-07-14 3:36 ` Wan Zongshun
2016-07-14 3:36 ` Wan Zongshun
2016-07-14 13:54 ` Jason Cooper
2016-07-14 13:54 ` Jason Cooper
2016-07-15 5:15 ` Wan Zongshun
2016-07-15 5:15 ` Wan Zongshun
2016-07-15 7:00 ` Arnd Bergmann
2016-07-15 7:00 ` Arnd Bergmann
2016-07-15 9:44 ` Wan ZongShun
2016-07-15 9:44 ` Wan ZongShun
2016-07-15 10:02 ` Arnd Bergmann
2016-07-15 10:02 ` Arnd Bergmann
2016-07-21 18:45 ` Jason Cooper
2016-07-21 18:45 ` Jason Cooper
2016-07-15 15:45 ` Jason Cooper
2016-07-15 15:45 ` Jason Cooper
2016-07-10 7:27 ` [PATCH v2 03/10] Clocksource: add nuc970 clocksource driver Wan Zongshun
2016-07-10 7:27 ` Wan Zongshun
2016-07-11 15:36 ` Arnd Bergmann
2016-07-11 15:36 ` Arnd Bergmann
2016-07-12 7:32 ` Wan Zongshun
2016-07-12 7:32 ` Wan Zongshun
2016-07-12 7:32 ` Wan Zongshun
2016-07-12 8:28 ` Arnd Bergmann
2016-07-12 8:28 ` Arnd Bergmann
2016-07-21 12:52 ` Daniel Lezcano
2016-07-21 12:52 ` Daniel Lezcano
2016-07-21 12:54 ` Arnd Bergmann
2016-07-21 12:54 ` Arnd Bergmann
2016-07-21 12:54 ` Arnd Bergmann
2016-07-10 7:27 ` [PATCH v2 04/10] clk: add Clock driver for nuc970 Wan Zongshun
2016-07-10 7:27 ` Wan Zongshun
2016-07-11 22:14 ` Michael Turquette
2016-07-11 22:14 ` Michael Turquette
2016-07-11 22:14 ` Michael Turquette
2016-07-11 22:14 ` Michael Turquette
2016-07-10 7:27 ` [PATCH v2 05/10] power/reset: Add reset driver support for nuc900 Wan Zongshun
2016-07-10 7:27 ` Wan Zongshun
2016-07-10 21:56 ` Paul Gortmaker
2016-07-10 21:56 ` Paul Gortmaker
2016-07-11 2:30 ` Wan Zongshun
2016-07-11 2:30 ` Wan Zongshun
2016-07-11 2:58 ` Paul Gortmaker
2016-07-11 2:58 ` Paul Gortmaker
2016-07-11 2:58 ` Paul Gortmaker
2016-07-10 7:27 ` [PATCH v2 06/10] soc: Add SoC specific " Wan Zongshun
2016-07-10 7:27 ` Wan Zongshun
2016-07-11 8:03 ` Arnd Bergmann
2016-07-11 8:03 ` Arnd Bergmann
2016-07-11 9:07 ` Wan Zongshun
2016-07-11 9:07 ` Wan Zongshun
2016-07-11 10:24 ` Arnd Bergmann
2016-07-11 10:24 ` Arnd Bergmann
2016-07-11 10:28 ` Wan ZongShun
2016-07-11 10:28 ` Wan ZongShun
2016-07-11 10:36 ` Arnd Bergmann
2016-07-11 10:36 ` Arnd Bergmann
2016-07-11 10:36 ` Arnd Bergmann
2016-07-12 9:06 ` Wan Zongshun
2016-07-12 9:06 ` Wan Zongshun
2016-07-12 9:50 ` Arnd Bergmann
2016-07-12 9:50 ` Arnd Bergmann
2016-07-10 7:27 ` [PATCH v2 07/10] ARM: dts: Add clock header file into dt-bindings Wan Zongshun
2016-07-10 7:27 ` Wan Zongshun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5784968A.7080007@iommu.org \
--to=vw@iommu.org \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mcuos.com@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.