From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH] virtio: don't warn if we can't allocate indirect sglist Date: Tue, 12 Jul 2016 09:30:55 +0200 Message-ID: <57849CAF.9040907@de.ibm.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Mikulas Patocka , "Michael S. Tsirkin" Cc: virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On 07/11/2016 07:22 PM, Mikulas Patocka wrote: > Don't print warning if memory allocation fails. The virtio driver can > handle allocation failure (it falls back to direct sglist), so there is > no functionality degradation. > > This warning was observed when swapping to virtio scsi device because > there may be not enough free memory during swapping. > > Signed-off-by: Mikulas Patocka Reviewed-by: Christian Borntraeger > > --- > drivers/virtio/virtio_ring.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > Index: linux-4.7-rc7/drivers/virtio/virtio_ring.c > =================================================================== > --- linux-4.7-rc7.orig/drivers/virtio/virtio_ring.c 2016-05-09 17:45:04.000000000 +0200 > +++ linux-4.7-rc7/drivers/virtio/virtio_ring.c 2016-07-11 17:30:20.000000000 +0200 > @@ -237,6 +237,12 @@ static struct vring_desc *alloc_indirect > */ > gfp &= ~__GFP_HIGHMEM; > > + /* > + * Don't warn if the allocation fails, because the driver > + * handles allocation failures gracefully. > + */ > + gfp |= __GFP_NOWARN; > + > desc = kmalloc(total_sg * sizeof(struct vring_desc), gfp); > if (!desc) > return NULL; > _______________________________________________ > Virtualization mailing list > Virtualization@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/virtualization >