All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
	kbuild-all@01.org, Stephen Boyd <sboyd@codeaurora.org>,
	Mike Turquette <mturquette@baylibre.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [devfreq:testing/kozlowski 12/12] warning: (ARM_EXYNOS_BUS_DEVFREQ) selects DEVFREQ_EVENT_EXYNOS_PPMU which has unmet direct dependencies (PM_DEVFREQ && ..)
Date: Tue, 12 Jul 2016 14:30:42 +0200	[thread overview]
Message-ID: <5784E2F2.8060103@samsung.com> (raw)
In-Reply-To: <201607121927.xX0821td%fengguang.wu@intel.com>

On 07/12/2016 01:45 PM, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git testing/kozlowski
> head:   dacb9d6e4946a56f550f706ee4361a6d68dc513a
> commit: dacb9d6e4946a56f550f706ee4361a6d68dc513a [12/12] PM / devfreq: Add COMPILE_TEST for build coverage
> config: sparc64-allyesconfig (attached as .config)
> compiler: sparc64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout dacb9d6e4946a56f550f706ee4361a6d68dc513a
>         # save the attached .config to linux build tree
>         make.cross ARCH=sparc64 
> 
> All warnings (new ones prefixed by >>):
> 
> warning: (ARM_EXYNOS_BUS_DEVFREQ) selects DEVFREQ_EVENT_EXYNOS_PPMU which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_EXYNOS)

Hi MyungJoo,

Thanks for applying the patch.

The commit
https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=testing/kozlowski&id=dacb9d6e4946a56f550f706ee4361a6d68dc513a
looks wrong. It contains only half of necessary changes. It is missing
defreq/event changes:
https://patchwork.kernel.org/patch/9200657/
This is the reason behind this kbuild warning.

Additionally I see you cherry-picked dependency ("clk: Provide notifier
stubs when !COMMON_CLK") but:
1. There is no signed-off-by of yours,
2. It should be merged (pulled), not cherry-picked, because otherwise
the commit will appear twice - both from clk tree and from yours. This
is why Stephen provided a stable branch so just:
$ git pull git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git
clk-notify

Best regards,
Krzysztof

       reply	other threads:[~2016-07-12 12:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201607121927.xX0821td%fengguang.wu@intel.com>
2016-07-12 12:30 ` Krzysztof Kozlowski [this message]
2016-07-14  6:03   ` [devfreq:testing/kozlowski 12/12] warning: (ARM_EXYNOS_BUS_DEVFREQ) selects DEVFREQ_EVENT_EXYNOS_PPMU which has unmet direct dependencies (PM_DEVFREQ && ..) MyungJoo Ham
2016-07-14  8:00     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5784E2F2.8060103@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.