From: axboe@fb.com (Jens Axboe)
Subject: [PATCH] nvme: Limit command retries
Date: Tue, 12 Jul 2016 16:21:24 -0700 [thread overview]
Message-ID: <57857B74.2040003@fb.com> (raw)
In-Reply-To: <1466444691-29448-1-git-send-email-keith.busch@intel.com>
On 06/20/2016 10:44 AM, Keith Busch wrote:
> Many controller implementations will return errors to commands that will
> not succeed, but without the DNR bit set. The driver previously retried
> these commands an unlimited number of times until the command timeout
> has exceeded, which takes an unnecessarilly long period of time.
>
> This patch limits the number of retries a command can have, defaulting
> to 5, but is user tunable at load or runtime.
>
> The struct request's 'retries' field is used to track the number of
> retries attempted. This is in contrast with scsi's use of this field,
> which indicates how many retries are allowed.
Added for 4.8, thanks.
--
Jens Axboe
prev parent reply other threads:[~2016-07-12 23:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 17:44 [PATCH] nvme: Limit command retries Keith Busch
2016-06-22 10:30 ` Sagi Grimberg
2016-06-22 14:40 ` Keith Busch
2016-06-22 16:14 ` Christoph Hellwig
2016-06-22 17:01 ` Keith Busch
2016-07-10 9:47 ` Christoph Hellwig
2016-07-12 23:21 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57857B74.2040003@fb.com \
--to=axboe@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.