From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [v5 PATCH 1/5] extcon: Add Type-C and DP support Date: Wed, 13 Jul 2016 10:11:14 +0900 Message-ID: <57859532.1010002@samsung.com> References: <1468336188-565-1-git-send-email-zyw@rock-chips.com> <1468336188-565-2-git-send-email-zyw@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1468336188-565-2-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Chris Zhong , dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, yzq-TNX95d0MmH7DzftRWevZcw@public.gmane.org, groeck-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, wulf-TNX95d0MmH7DzftRWevZcw@public.gmane.org, marcheu-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rockchip.vger.kernel.org SGkgQ2hyaXMsCgpJJ20gbm93IGRldmVsb3BpbmcgdGhlIGV4dGNvbiBwcm9wZXJ0eSBvbiBleHRj b24tdGVzdCBicmFuY2guCkJ1dCwgaXQgaGFzIG5vdCBiZWVuIGNvbXBsZXRlZC4KCk9uIG5leHQg dmVyc2lvbiwgSSdsbCByZW1vdmUgdGhlIG5vdGlmaWNhdGlvbiBhYm91dCBleHRjb24gcHJvcGVy dHkKYW5kIG9ubHkgc3VwcG9ydCB0aGUgZm9sbG93aW5nIHR3byBmdW5jdGlvbnMuCi0gZXh0Y29u X3NldF9jYWJsZV9wcm9wZXJ0eSgpCi0gZXh0Y29uX2dldF9jYWJsZV9wcm9wZXJ0eSgpCgpCZWNh dXNlIHRoZSBudW1iZXIgb2YgcHJvcGVydGllcyB3b3VsZCBiZSByaXNlbiBhbmQgdGhlIGFsbCBw cm9wZXJ0aWVzCmRlcGVuZCBvbiB0aGUgc3BlY2lmaWMgZXh0ZXJuYWwgY29ubmVjdG9yKGUuZy4s IEVYVENPTl9QUk9QX1VTQl9WQlVTCmRlcGVuZCBvbiB0aGUgRVhUQ09OX1RZUEVfVVNCIHR5cGUp LiBXaGVuIHRoZSBzcGVjaWZpYyBleHRlcm5hbCBjb25uZWN0b3IKaXMgZGV0YWNoZWQsIGV4dGNv biBmcmFtZXdvcmsgc2hvdWxkIG1ha2UgdGhlIHByb3BlcnR5IHN0YXRlIGFzIGRlZmF1bHQgc3Rh dGUuCgpJdCBtYXkgc2VuZCB0aGUgdG9vIG1hbnkgbm90aWZpY2F0aW9uIGZvciBleHRjb24gcHJv cGVydHkuCkZvciBleGFtcGxlLCBBc3N1bWUgdGhhdCBFWFRDT05fVFlQRV9VU0IgaGFzIHRoZSBv dmVyIDIwIHByb3BlcnRpZXMsCndoZW4gRVhUQ09OX1VTQiBvciBFWFRDT05fVVNCX0hPU1QgaXMg ZGV0YWNoZWQsIGV4dGNvbiBzaG91bGQgc2VuZAp0aGUgbm90aWZpY2F0aW9uIGZvciB0aGUgb3Zl ciAyMCBwcm9wZXJ0aWVzIGFuZCBvbmUgbW9yZSBub3RpZmljYWl0b24KZm9yIHN0YXRlIG9mIGV4 dGVybmFsIGNvbm5lY3Rvci4KClNvLCBJJ2xsIHNlbmQgdGhlIFJGQyBwYXRjaHNldCB3aXRob3V0 IHRoZSBub3RpZmljYXRpb24gb2YgcHJvZXJ0eS4KCkxhc3RseSwKSSBoYXZlIGEgY29tbWVudCBv biBiZWxvdy4KClRoYW5rcywKQ2hhbndvbyBDaG9pCgpPbiAyMDE264WEIDA37JuUIDEz7J28IDAw OjA5LCBDaHJpcyBaaG9uZyB3cm90ZToKPiBBZGQgRVhUQ09OX0RJU1BfRFAgZm9yIHRoZSBEaXNw bGF5IGV4dGVybmFsIGNvbm5lY3Rvci4gRm9yIFR5cGUtQwo+IGNvbm5lY3RvciB0aGUgRGlzcGxh eVBvcnQgY2FuIHdvcmsgYXMgYW4gQWx0ZXJuYXRlIE1vZGUoVkVTQSBEaXNwbGF5UG9ydAo+IEFs dCBNb2RlIG9uIFVTQiBUeXBlLUMgU3RhbmRhcmQpLiBUaGUgVHlwZS1DIHN1cHBvcnQgYm90aCBu b3JtYWwgYW5kCj4gZmxpcHBlZCBvcmllbnRhdGlvbiwgc28gYWRkIGEgcHJvcGVydHkgdG8gZXh0 Y29uLgo+IAo+IFNpZ25lLW9mZi1ieTogQ2hyaXMgWmhvbmcgPHp5d0Byb2NrLWNoaXBzLmNvbT4K PiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBaaG9uZyA8enl3QHJvY2stY2hpcHMuY29tPgo+IC0t LQo+IAo+IENoYW5nZXMgaW4gdjU6Cj4gLSBzdXBwb3J0IGdldCBwcm9wZXJ0eQo+IAo+IENoYW5n ZXMgaW4gdjQ6IE5vbmUKPiBDaGFuZ2VzIGluIHYzOiBOb25lCj4gQ2hhbmdlcyBpbiB2MjogTm9u ZQo+IENoYW5nZXMgaW4gdjE6IE5vbmUKPiAKPiAgZHJpdmVycy9leHRjb24vZXh0Y29uLmMgfCAy OCArKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIGluY2x1ZGUvbGludXgvZXh0Y29uLmgg IHwgMTMgKysrKysrKysrKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDQxIGluc2VydGlvbnMoKykK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9leHRjb24vZXh0Y29uLmMgYi9kcml2ZXJzL2V4dGNv bi9leHRjb24uYwo+IGluZGV4IGExMTE3ZGIuLjI1OTFiMjggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9leHRjb24vZXh0Y29uLmMKPiArKysgYi9kcml2ZXJzL2V4dGNvbi9leHRjb24uYwo+IEBAIC0x NTcsNiArMTU3LDExIEBAIHN0cnVjdCBfX2V4dGNvbl9pbmZvIHsKPiAgCQkuaWQgPSBFWFRDT05f RElTUF9WR0EsCj4gIAkJLm5hbWUgPSAiVkdBIiwKPiAgCX0sCj4gKwlbRVhUQ09OX0RJU1BfRFBd ID0gewo+ICsJCS50eXBlID0gRVhUQ09OX1RZUEVfRElTUCwKPiArCQkuaWQgPSBFWFRDT05fRElT UF9EUCwKPiArCQkubmFtZSA9ICJEUCIsCj4gKwl9LAo+ICAKPiAgCS8qIE1pc2NlbGxhbmVvdXMg ZXh0ZXJuYWwgY29ubmVjdG9yICovCj4gIAlbRVhUQ09OX0RPQ0tdID0gewo+IEBAIC0yNzAsNiAr Mjc1LDcgQEAgc3RhdGljIGJvb2wgaXNfZXh0Y29uX3Byb3BlcnR5X3N1cHBvcnRlZCh1bnNpZ25l ZCBpbnQgaWQsCj4gIAkJc3dpdGNoIChwcm9wKSB7Cj4gIAkJY2FzZSBFWFRDT05fUFJPUF9VU0Jf SUQ6Cj4gIAkJY2FzZSBFWFRDT05fUFJPUF9VU0JfVkJVUzoKPiArCQljYXNlIEVYVENPTl9QUk9Q X1RZUEVDX1BPTEFSSVRZOgo+ICAJCQlyZXR1cm4gdHJ1ZTsKPiAgCQlkZWZhdWx0Ogo+ICAJCQli cmVhazsKPiBAQCAtMjg2LDYgKzI5Miw4IEBAIHN0YXRpYyBib29sIGlzX2V4dGNvbl9wcm9wZXJ0 eV9zdXBwb3J0ZWQodW5zaWduZWQgaW50IGlkLAo+ICAJCX0KPiAgCWNhc2UgRVhUQ09OX1RZUEVf RElTUDoKPiAgCQlzd2l0Y2ggKHByb3ApIHsKPiArCQljYXNlIEVYVENPTl9QUk9QX1RZUEVDX1BP TEFSSVRZOgoKU2hvdWxkIEVYVENPTl9QUk9QX1RZUEVDX1BPTEFSSVRZIHByb3BlcnR5IGFkZCB0 byBib3RoIEVYVENPTl9UWVBFX1VTQiBhbmQgRVhUQ09OX1RZUF9ESVNQPwpFWFRDT05fUFJPUF9U WVBFQ19QT0xBUklUWSBpcyB0aGUgcHJvcGVydHkgb2YgVVNCIEMtdHlwZT8KCj4gKwkJCXJldHVy biB0cnVlOwo+ICAJCWRlZmF1bHQ6Cj4gIAkJCWJyZWFrOwo+ICAJCX0KPiBAQCAtNTQ3LDYgKzU1 NSwyNiBAQCBpbnQgZXh0Y29uX2dldF9jYWJsZV9wcm9wZXJ0eShzdHJ1Y3QgZXh0Y29uX2RldiAq ZWRldiwgdW5zaWduZWQgaW50IGlkLAo+ICAJCQkJZW51bSBleHRjb25fcHJvcGVydHkgcHJvcCwK PiAgCQkJCXVuaW9uIGV4dGNvbl9wcm9wZXJ0eV92YWx1ZSAqdmFsKQo+ICB7Cj4gKwlzdHJ1Y3Qg ZXh0Y29uX2NhYmxlICpjYWJsZTsKPiArCWludCBpbmRleDsKPiArCj4gKwlpZiAoIWVkZXYpCj4g KwkJcmV0dXJuIC1FSU5WQUw7Cj4gKwo+ICsJLyogQ2hlY2sgdGhlIHByb3BlcnR5IHdoZXRoZXIg aXMgc3VwcG9ydGVkIG9yIG5vdCAqLwo+ICsJaWYgKCFpc19leHRjb25fcHJvcGVydHlfc3VwcG9y dGVkKGlkLCBwcm9wKSkKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCj4gKwkvKiBGaW5kIHRoZSBj YWJsZSBpbmRleCBvZiBleHRlcm5hbCBjb25uZWN0b3IgYnkgdXNpbmcgaWQgKi8KPiArCWluZGV4 ID0gZmluZF9jYWJsZV9pbmRleF9ieV9pZChlZGV2LCBpZCk7Cj4gKwlpZiAoaW5kZXggPCAwKQo+ ICsJCXJldHVybiBpbmRleDsKPiArCj4gKwkvKiBTdG9yZSB0aGUgcHJvcGVydHkgdmFsdWUgKi8K PiArCWNhYmxlID0gJmVkZXYtPmNhYmxlc1tpbmRleF07Cj4gKwo+ICsJdmFsLT5pbnR2YWwgPSBj YWJsZS0+cHJvcHZhbFtwcm9wXS5pbnR2YWw7Cj4gKwo+ICAJcmV0dXJuIDA7Cj4gIH0KCkFmdGVy IEkgZGV2ZWxvcCBpdCBhYm91dCBnZXRfY2FibGVfcHJvcGVydHksIEknbGwgc2VuZCBSRkMgcGF0 Y2hzZXQuCgo+ICAKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9leHRjb24uaCBiL2luY2x1 ZGUvbGludXgvZXh0Y29uLmgKPiBpbmRleCBmNmYwYThkLi41MGVmODdmIDEwMDY0NAo+IC0tLSBh L2luY2x1ZGUvbGludXgvZXh0Y29uLmgKPiArKysgYi9pbmNsdWRlL2xpbnV4L2V4dGNvbi5oCj4g QEAgLTc3LDYgKzc3LDcgQEAgZW51bSBleHRjb25fdHlwZSB7Cj4gICNkZWZpbmUgRVhUQ09OX0RJ U1BfTUhMCQk0MQkvKiBNb2JpbGUgSGlnaC1EZWZpbml0aW9uIExpbmsgKi8KPiAgI2RlZmluZSBF WFRDT05fRElTUF9EVkkJCTQyCS8qIERpZ2l0YWwgVmlzdWFsIEludGVyZmFjZSAqLwo+ICAjZGVm aW5lIEVYVENPTl9ESVNQX1ZHQQkJNDMJLyogVmlkZW8gR3JhcGhpY3MgQXJyYXkgKi8KPiArI2Rl ZmluZSBFWFRDT05fRElTUF9EUAkJNDQJLyogRGlzcGxheVBvcnQgKi8KPiAgCj4gIC8qIE1pc2Nl bGxhbmVvdXMgZXh0ZXJuYWwgY29ubmVjdG9yICovCj4gICNkZWZpbmUgRVhUQ09OX0RPQ0sJCTYw Cj4gQEAgLTEwOCw5ICsxMDksMTMgQEAgZW51bSBleHRjb25fcHJvcGVydHkgewo+ICAJICogLSBF WFRDT05fUFJPUF9VU0JfVVNCCj4gIAkgKiBAdHlwZToJaW50ZWdlciAoaW50IHZhbHVlKQo+ICAJ ICogQHZhbHVlOgkwIChsb3cpIG9yIDEgKGhpZ2gpCj4gKwkgKiAtIEVYVENPTl9QUk9QX1RZUEVD X1BPTEFSSVRZLAo+ICsJICogQHR5cGU6CWludGVnZXIgKGludCB2YWx1ZSkKPiArCSAqIEB2YWx1 ZToJMCAobm9ybWFsKSBvciAxIChmbGlwKQo+ICAJICovCj4gIAlFWFRDT05fUFJPUF9VU0JfSUQg PSAwLAo+ICAJRVhUQ09OX1BST1BfVVNCX1ZCVVMsCj4gKwlFWFRDT05fUFJPUF9UWVBFQ19QT0xB UklUWSwKPiAgCj4gIAkvKiBQcm9wZXJ0aWVzIG9mIEVYVENPTl9UWVBFX0NIRy4gKi8KPiAgCS8q IFByb3BlcnRpZXMgb2YgRVhUQ09OX1RZUEVfSkFDSy4gKi8KPiBAQCAtMjI1LDYgKzIzMCwxNCBA QCBleHRlcm4gaW50IGV4dGNvbl9nZXRfY2FibGVfc3RhdGVfKHN0cnVjdCBleHRjb25fZGV2ICpl ZGV2LCB1bnNpZ25lZCBpbnQgaWQpOwo+ICBleHRlcm4gaW50IGV4dGNvbl9zZXRfY2FibGVfc3Rh dGVfKHN0cnVjdCBleHRjb25fZGV2ICplZGV2LCB1bnNpZ25lZCBpbnQgaWQsCj4gIAkJCQkgICBi b29sIGNhYmxlX3N0YXRlKTsKPiAgCj4gK2V4dGVybiBpbnQgZXh0Y29uX2dldF9jYWJsZV9wcm9w ZXJ0eShzdHJ1Y3QgZXh0Y29uX2RldiAqZWRldiwgdW5zaWduZWQgaW50IGlkLAo+ICsJCQkJICAg ICBlbnVtIGV4dGNvbl9wcm9wZXJ0eSBwcm9wLAo+ICsJCQkJICAgICB1bmlvbiBleHRjb25fcHJv cGVydHlfdmFsdWUgKnZhbCk7Cj4gKwo+ICtleHRlcm4gaW50IGV4dGNvbl9zZXRfY2FibGVfcHJv cGVydHkoc3RydWN0IGV4dGNvbl9kZXYgKmVkZXYsIHVuc2lnbmVkIGludCBpZCwKPiArCQkJCSAg ICAgZW51bSBleHRjb25fcHJvcGVydHkgcHJvcCwKPiArCQkJCSAgICAgdW5pb24gZXh0Y29uX3By b3BlcnR5X3ZhbHVlIHZhbCk7Cj4gKwoKZGl0dG8uCgpUaGFua3MsCkNoYW53b28gQ2hvaQoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2No aXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752090AbcGMBLx (ORCPT ); Tue, 12 Jul 2016 21:11:53 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:34555 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbcGMBLo (ORCPT ); Tue, 12 Jul 2016 21:11:44 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68f-f79476d000001429-1d-5785953338f9 Content-transfer-encoding: 8BIT Message-id: <57859532.1010002@samsung.com> Date: Wed, 13 Jul 2016 10:11:14 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Chris Zhong , dianders@chromium.org, tfiga@chromium.org, heiko@sntech.de, yzq@rock-chips.com, groeck@chromium.org, myungjoo.ham@samsung.com, wulf@rock-chips.com, marcheu@chromium.org Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [v5 PATCH 1/5] extcon: Add Type-C and DP support References: <1468336188-565-1-git-send-email-zyw@rock-chips.com> <1468336188-565-2-git-send-email-zyw@rock-chips.com> In-reply-to: <1468336188-565-2-git-send-email-zyw@rock-chips.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBIsWRmVeSWpSXmKPExsWyRsSkUNd4amu4wZZbwhZnlx1kszj1ahmz xf9Hr1ktLu+aw2bx6cF/Zot5h34zWtxuXMFm8bn1H5vFqrXHmS3mrlvCZjH/wQ5mB26P2Q0X WTw2L6n3+DtrP4tH35ZVjB7br81j9vi8SS6ALYrLJiU1J7MstUjfLoEr4+h684L3GhW7+iYz NzAuU+hi5OSQEDCReP70CDuELSZx4d56ti5GLg4hgRWMEv/OLGeBKVr3ZDEzRGIpo0RTxwWw BK+AoMSPyfeAbA4OZgF5iSOXskHCzALqEpPmLYKqf8AocXN9NzNEvZZE3+fLrCA2i4CqRO/r C2BxNqD4/hc32EDmiApESHSfqATpFRG4xCix9GELO8R8F4kpH7lBTGEBW4mj78ogxp9mlGhd NIkRZAyngKPEpys9YA9ICHxll9i/uo0ZYpeAxLfJh8DulBCQldh0gBniL0mJgytusExgFJuF 5JtZCN/MQvLNAkbmVYyiqQXJBcVJ6UXGesWJucWleel6yfm5mxiBEXr637P+HYx3D1gfYhTg YFTi4dVoag0XYk0sK67MPcRoCnTERGYp0eR8YBrIK4k3NDYzsjA1MTU2Mrc0UxLnXSj1M1hI ID2xJDU7NbUgtSi+qDQntfgQIxMHp1QDo6rznMmu2m/2ys1w/jr77Un7hbJftupMuPR/lxDf ClPWV0u+7i3kKq1Tnf3V5Se7ROwKy+8Pj8kL3Nef+bXu6I8Aw0VNL9bYqBSH5sS8PvHVzPWj dkdOa0Db18/X4u/8761ccDytqm7jWeHYyaeWK69I/x5z+YvRHNsNnw6z1ibeyZ4V89/l2T4l luKMREMt5qLiRADoLo7vywIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplleLIzCtJLcpLzFFi42I5/e+xgK7x1NZwg/1reC3OLjvIZnHq1TJm i/+PXrNaXN41h83i04P/zBbzDv1mtLjduILN4nPrPzaLVWuPM1vMXbeEzWL+gx3MDtwesxsu snhsXlLv8XfWfhaPvi2rGD22X5vH7PF5k1wAW1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8 qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0H1KCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1D guB6jAzQQMIaxoyj680L3mtU7OqbzNzAuEyhi5GTQ0LARGLdk8XMELaYxIV769m6GLk4hASW Mko0dVxgAUnwCghK/Jh8D8jm4GAWkJc4cikbJMwsoC4xad4iZoj6B4wSN9d3M0PUa0n0fb7M CmKzCKhK9L6+ABZnA4rvf3GDDWSOqECERPeJSpBeEYFLjBJLH7awQ8x3kZjykRvEFBawlTj6 rgxi/GlGidZFkxhBxnAKOEp8utLDNoFRYBaS62YhXDcLyXULGJlXMUqkFiQXFCel5xrmpZbr FSfmFpfmpesl5+duYgQngWdSOxgP7nI/xCjAwajEw2tg1xouxJpYVlyZe4hRgoNZSYT3yESg EG9KYmVValF+fFFpTmrxIUZToPcmMkuJJucDE1ReSbyhsYmZkaWRuaGFkbG5kjjv4//rwoQE 0hNLUrNTUwtSi2D6mDg4pRoY06sK3x/fYqzwNoLVY0JdW/UF5tdfuHfLbNLUfLbocpnXjP/N 3RsuNYV17nvis6CL+5L2Eae9CetEcw9Mjwp6vubW/uptSb7yHc65q/QuXdv5VSUnefPfXwae biyx0na132+Hzc2xilsmsje5aXVArfVzx2cSbcWrdwVf+th6/K5Z0TOOFo4sJZbijERDLeai 4kQAOiCpkBgDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chris, I'm now developing the extcon property on extcon-test branch. But, it has not been completed. On next version, I'll remove the notification about extcon property and only support the following two functions. - extcon_set_cable_property() - extcon_get_cable_property() Because the number of properties would be risen and the all properties depend on the specific external connector(e.g., EXTCON_PROP_USB_VBUS depend on the EXTCON_TYPE_USB type). When the specific external connector is detached, extcon framework should make the property state as default state. It may send the too many notification for extcon property. For example, Assume that EXTCON_TYPE_USB has the over 20 properties, when EXTCON_USB or EXTCON_USB_HOST is detached, extcon should send the notification for the over 20 properties and one more notificaiton for state of external connector. So, I'll send the RFC patchset without the notification of proerty. Lastly, I have a comment on below. Thanks, Chanwoo Choi On 2016년 07월 13일 00:09, Chris Zhong wrote: > Add EXTCON_DISP_DP for the Display external connector. For Type-C > connector the DisplayPort can work as an Alternate Mode(VESA DisplayPort > Alt Mode on USB Type-C Standard). The Type-C support both normal and > flipped orientation, so add a property to extcon. > > Signe-off-by: Chris Zhong > > Signed-off-by: Chris Zhong > --- > > Changes in v5: > - support get property > > Changes in v4: None > Changes in v3: None > Changes in v2: None > Changes in v1: None > > drivers/extcon/extcon.c | 28 ++++++++++++++++++++++++++++ > include/linux/extcon.h | 13 +++++++++++++ > 2 files changed, 41 insertions(+) > > diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c > index a1117db..2591b28 100644 > --- a/drivers/extcon/extcon.c > +++ b/drivers/extcon/extcon.c > @@ -157,6 +157,11 @@ struct __extcon_info { > .id = EXTCON_DISP_VGA, > .name = "VGA", > }, > + [EXTCON_DISP_DP] = { > + .type = EXTCON_TYPE_DISP, > + .id = EXTCON_DISP_DP, > + .name = "DP", > + }, > > /* Miscellaneous external connector */ > [EXTCON_DOCK] = { > @@ -270,6 +275,7 @@ static bool is_extcon_property_supported(unsigned int id, > switch (prop) { > case EXTCON_PROP_USB_ID: > case EXTCON_PROP_USB_VBUS: > + case EXTCON_PROP_TYPEC_POLARITY: > return true; > default: > break; > @@ -286,6 +292,8 @@ static bool is_extcon_property_supported(unsigned int id, > } > case EXTCON_TYPE_DISP: > switch (prop) { > + case EXTCON_PROP_TYPEC_POLARITY: Should EXTCON_PROP_TYPEC_POLARITY property add to both EXTCON_TYPE_USB and EXTCON_TYP_DISP? EXTCON_PROP_TYPEC_POLARITY is the property of USB C-type? > + return true; > default: > break; > } > @@ -547,6 +555,26 @@ int extcon_get_cable_property(struct extcon_dev *edev, unsigned int id, > enum extcon_property prop, > union extcon_property_value *val) > { > + struct extcon_cable *cable; > + int index; > + > + if (!edev) > + return -EINVAL; > + > + /* Check the property whether is supported or not */ > + if (!is_extcon_property_supported(id, prop)) > + return -EINVAL; > + > + /* Find the cable index of external connector by using id */ > + index = find_cable_index_by_id(edev, id); > + if (index < 0) > + return index; > + > + /* Store the property value */ > + cable = &edev->cables[index]; > + > + val->intval = cable->propval[prop].intval; > + > return 0; > } After I develop it about get_cable_property, I'll send RFC patchset. > > diff --git a/include/linux/extcon.h b/include/linux/extcon.h > index f6f0a8d..50ef87f 100644 > --- a/include/linux/extcon.h > +++ b/include/linux/extcon.h > @@ -77,6 +77,7 @@ enum extcon_type { > #define EXTCON_DISP_MHL 41 /* Mobile High-Definition Link */ > #define EXTCON_DISP_DVI 42 /* Digital Visual Interface */ > #define EXTCON_DISP_VGA 43 /* Video Graphics Array */ > +#define EXTCON_DISP_DP 44 /* DisplayPort */ > > /* Miscellaneous external connector */ > #define EXTCON_DOCK 60 > @@ -108,9 +109,13 @@ enum extcon_property { > * - EXTCON_PROP_USB_USB > * @type: integer (int value) > * @value: 0 (low) or 1 (high) > + * - EXTCON_PROP_TYPEC_POLARITY, > + * @type: integer (int value) > + * @value: 0 (normal) or 1 (flip) > */ > EXTCON_PROP_USB_ID = 0, > EXTCON_PROP_USB_VBUS, > + EXTCON_PROP_TYPEC_POLARITY, > > /* Properties of EXTCON_TYPE_CHG. */ > /* Properties of EXTCON_TYPE_JACK. */ > @@ -225,6 +230,14 @@ extern int extcon_get_cable_state_(struct extcon_dev *edev, unsigned int id); > extern int extcon_set_cable_state_(struct extcon_dev *edev, unsigned int id, > bool cable_state); > > +extern int extcon_get_cable_property(struct extcon_dev *edev, unsigned int id, > + enum extcon_property prop, > + union extcon_property_value *val); > + > +extern int extcon_set_cable_property(struct extcon_dev *edev, unsigned int id, > + enum extcon_property prop, > + union extcon_property_value val); > + ditto. Thanks, Chanwoo Choi