From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 2/2] mmc: dw_mmc: Print proper voltage on error
Date: Wed, 13 Jul 2016 09:55:35 +0200 [thread overview]
Message-ID: <5785F3F7.6060708@samsung.com> (raw)
In-Reply-To: <57859AF4.1020204@samsung.com>
On 07/13/2016 03:35 AM, Jaehoon Chung wrote:
> Hi Krzysztof,
>
> On 07/12/2016 11:08 PM, Krzysztof Kozlowski wrote:
>> The commit 97f659a2e972 ("mmc: dw_mmc: prevent to set the wrong
>> value") reordered the code so the 'uhs' variable used in
>> mmc_regulator_set_vqmmc() error message is always 0 at that time thus
>> always printing 3.3 voltage. Instead use value obtained from ios in
>> printed error message.
>
> The commit 97f659a2e972 was dropped because some board didn't work fine.
> Some boards didn't use the vqmmc suppy and not defined into device-tree.
>
> It's short time to fix. I will re-send the patch on next.
> At that time, i will check this patch.
Ah, okay. If 97f659a2e972 is dropped, there is no need for this patchset.
Best regards,
Krzysztof
prev parent reply other threads:[~2016-07-13 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 14:08 [PATCH 1/2] mmc: core: Add helper for mapping IOS voltage to string Krzysztof Kozlowski
2016-07-12 14:08 ` [PATCH 2/2] mmc: dw_mmc: Print proper voltage on error Krzysztof Kozlowski
2016-07-12 20:23 ` kbuild test robot
2016-07-12 20:23 ` kbuild test robot
2016-07-13 1:35 ` Jaehoon Chung
2016-07-13 7:55 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5785F3F7.6060708@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.