Re: [PATCH v3 0/2] Toshiba TC358767 eDP bridge driver

From: Archit Taneja <architt@codeaurora.org>
To: Philipp Zabel <p.zabel@pengutronix.de>,
	dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Andrey Gusakov <andrey.gusakov@cogentembedded.com>,
	Chris Healy <Chris.Healy@zii.aero>,
	Kumar Gala <galak@codeaurora.org>,
	Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH v3 0/2] Toshiba TC358767 eDP bridge driver
Date: Wed, 13 Jul 2016 13:51:49 +0530	[thread overview]
Message-ID: <5785FA1D.6060002@codeaurora.org> (raw)
In-Reply-To: <1468393631-12042-1-git-send-email-p.zabel@pengutronix.de>

Hi,

On 07/13/2016 12:37 PM, Philipp Zabel wrote:
> Hi,
>
> this patchset adds DT binding docs and a drm_bridge driver for the
> Toshiba TC358767 eDP bridge, currently supporting only 24-bit DPI input
> and control via I2C. The chip is also capable to act as a DSI sink, but
> the driver doesn't support that yet.
> It is based on Andrey's initial driver, which can be found at
> https://github.com/CogentEmbedded/linux-zodiac.git, commit 4abb1d0a9a1c
> ("drm/i2c: tc358767 eDP encoder initial commit"). I have turned it into
> a drm_bridge driver and changed it to use regmap and the drm_dp helpers.

The patchset looks good. We just need an ack for the DT bindings from
Rob.

Thanks,
Archit

>
> Changes since v2:
>   - Let DRM_TOSHIBA_TC358767 depend on OF
>   - Add a module parameter "test" to enable the color bar test pattern
>   - Provide mode clock to tc_pxl_pll_en
>   - Remove now otherwise unused struct tc_data members "pll_clk",
>     "pll_clk_real" and "test_pattern".
>
> regards
> Philipp
>
> Andrey Gusakov (1):
>    drm/bridge: tc358767: Add DPI to eDP bridge driver
>
> Philipp Zabel (1):
>    dt-bindings: tc358767: add DT documentation
>
>   .../bindings/display/bridge/toshiba,tc358767.txt   |   51 +
>   drivers/gpu/drm/bridge/Kconfig                     |    9 +
>   drivers/gpu/drm/bridge/Makefile                    |    1 +
>   drivers/gpu/drm/bridge/tc358767.c                  | 1413 ++++++++++++++++++++
>   4 files changed, 1474 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.txt
>   create mode 100644 drivers/gpu/drm/bridge/tc358767.c
>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel