From: Eric Blake <eblake@redhat.com>
To: Roman Pen <roman.penyaev@profitbricks.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V2 1/1] linux-aio: prevent submitting more than MAX_EVENTS
Date: Wed, 13 Jul 2016 06:22:30 -0600 [thread overview]
Message-ID: <57863286.9080009@redhat.com> (raw)
In-Reply-To: <1468396629-26094-1-git-send-email-roman.penyaev@profitbricks.com>
[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]
On 07/13/2016 01:57 AM, Roman Pen wrote:
> v1..v2:
>
> o comment tweaks.
> o fix QEMU coding style.
The above comments should be delayed...
>
> Invoking io_setup(MAX_EVENTS) we ask kernel to create ring buffer for us
> with specified number of events. But kernel ring buffer allocation logic
> is a bit tricky (ring buffer is page size aligned + some percpu allocation
> are required) so eventually more than requested events number is allocated.
>
...
> Signed-off-by: Roman Pen <roman.penyaev@profitbricks.com>
> Reviewed-by: Fam Zheng <famz@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
...until here, after the --- separator. They are useful to reviewers,
but won't make much sense a year from now in qemu.git (when we don't
care what other versions were on list, only the version that got committed).
Also, if you use 'git send-email -v2' (or 'git format-patch -v2'), your
subject line will resemble most other versioned patches (which use
[PATCH v2] rather than [PATCH V2]). We also recommend that v2 patches
be sent as top-level threads, rather than in-reply to v1.
More submission hints at http://wiki.qemu.org/Contribute/SubmitAPatch
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-07-13 12:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 17:51 [Qemu-devel] [PATCH 1/1] linux-aio: prevent submitting more than MAX_EVENTS Roman Pen
2016-07-13 2:23 ` Fam Zheng
2016-07-13 7:57 ` [Qemu-devel] [PATCH V2 " Roman Pen
2016-07-13 10:31 ` Paolo Bonzini
2016-07-13 11:33 ` Roman Penyaev
2016-07-13 11:45 ` Kevin Wolf
2016-07-13 14:53 ` Roman Penyaev
2016-07-15 9:18 ` Roman Penyaev
2016-07-15 9:58 ` Paolo Bonzini
2016-07-15 10:17 ` Roman Penyaev
2016-07-15 10:37 ` Paolo Bonzini
2016-07-15 11:35 ` Roman Penyaev
2016-07-15 12:57 ` Paolo Bonzini
2016-07-15 15:03 ` Roman Penyaev
2016-07-13 12:22 ` Eric Blake [this message]
2016-07-13 12:57 ` Roman Penyaev
2016-07-14 12:18 ` Stefan Hajnoczi
2016-07-13 7:43 ` [Qemu-devel] [PATCH " Paolo Bonzini
2016-07-13 7:50 ` Roman Penyaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57863286.9080009@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=roman.penyaev@profitbricks.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.