From: Juergen Gross <jgross@suse.com>
To: David Vrabel <david.vrabel@citrix.com>, Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
David Scott <dave@recoil.org>
Subject: Re: xenstored memory leak
Date: Wed, 13 Jul 2016 15:32:30 +0200 [thread overview]
Message-ID: <578642EE.2090103@suse.com> (raw)
In-Reply-To: <57863F58.2030800@citrix.com>
On 13/07/16 15:17, David Vrabel wrote:
> On 13/07/16 14:07, Wei Liu wrote:
>>
>> My gut feeling is that xenstored shouldn't have the knowledge to
>> associate a watch with a "process". The concept of a process is only
>> meaningful to OS, which wouldn't work on cross-domain xenstored setup.
>> Maybe the OS xenbus driver should reap all watches on behalf the dead
>> process. This would also avoid a crashed QEMU leaking resources.
>
> The Linux driver already cleans up open transactions and removes watches
> when the file handle is released.
Hmm, does this work reliably? I observed a memory leak of about 5kB per
create/destroy domain pair with xenstored _and_ with xenstore domain.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-13 13:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 7:31 xenstored memory leak Juergen Gross
2016-07-06 13:48 ` Andrew Cooper
2016-07-06 13:55 ` Juergen Gross
2016-07-06 13:59 ` Andrew Cooper
2016-07-07 16:22 ` Wei Liu
2016-07-13 12:21 ` Juergen Gross
2016-07-13 12:40 ` Andrew Cooper
2016-07-13 13:21 ` Juergen Gross
2016-07-13 13:30 ` Ian Jackson
2016-07-13 13:07 ` Wei Liu
2016-07-13 13:17 ` David Vrabel
2016-07-13 13:32 ` Juergen Gross [this message]
2016-07-13 13:37 ` David Vrabel
2016-07-13 14:28 ` Ian Jackson
2016-07-13 14:50 ` Juergen Gross
2016-07-13 13:20 ` Ian Jackson
2016-07-13 13:47 ` Wei Liu
2016-07-13 13:25 ` Juergen Gross
2016-07-13 13:52 ` Wei Liu
2016-07-13 14:09 ` Juergen Gross
2016-07-13 14:18 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578642EE.2090103@suse.com \
--to=jgross@suse.com \
--cc=dave@recoil.org \
--cc=david.vrabel@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.