Re: [PATCH v2 0/3] support of v4l2 encoder for STMicroelectronics SOC

[Jean Christophe TROTIN <jean-christophe.trotin@st.com>]

On 07/11/2016 08:57 PM, Javier Martinez Canillas wrote:
> On Mon, Jul 11, 2016 at 1:48 PM, Nicolas Dufresne
> <nicolas.dufresne@gmail.com> wrote:
>> Le lundi 11 juillet 2016 à 17:14 +0200, Jean-Christophe Trotin a
>> écrit :
>
> [snip]
>
>>>
>>> Below is the v4l2-compliance report for the version 2 of the sti hva
>>> driver:
>>>
>>>
>>> root@sti-next:/home/video_test# v4l2-compliance -d /dev/video0
>>> Driver Info:
>>>        Driver name   : 8c85000.hva
>>
>> I think it would be nice to set a driver name that means something.
>>
>>>        Card type     : 8c85000.hva
>
> Agreed, same for Card type. The VIDIOC_QUERYCAP ioctl documentation
> explains what information these fields should contain:
>
> https://linuxtv.org/downloads/v4l-dvb-apis/vidioc-querycap.html
>
> For example https://git.linuxtv.org/media_tree.git/commit/?id=e0d80c8acca0f221b9dedb2eab7a5184848b99b7
>
> Best regards,
> Javier
>

Nicolas and Javier,

Thank you for the remarks.
I will modify the code in version 3 so that "driver" contains the name of the 
encoder ("hva"), "card" identifies the hardware version ("hva<hw_ip_version>" 
with <hw_ip_version> equal to 400 here, which leads to "hva400"), and "bus_info" 
indicates the location of the device ("platform:8c85000.hva").

Before the modification:
Driver Info:
        Driver name   : 8c85000.hva
        Card type     : 8c85000.hva
        Bus info      : platform:hva
        Driver version: 4.7.0

After the modification:
Driver Info:
	Driver name   : hva
	Card type     : hva400
	Bus info      : platform:8c85000.hva
	Driver version: 4.7.0

Best regards,
Jean-Christophe.