All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: Damien Le Moal <damien.lemoal@hgst.com>,
	<linux-block@vger.kernel.org>, <hch@lst.de>, <hare@suse.de>
Subject: Re: [PATCH] block: Fix front merge check
Date: Wed, 13 Jul 2016 09:19:55 -0700	[thread overview]
Message-ID: <57866A2B.5000403@fb.com> (raw)
In-Reply-To: <1468387413-2754-1-git-send-email-damien.lemoal@hgst.com>

On 07/12/2016 10:23 PM, Damien Le Moal wrote:
> For a front merge, the maximum number of sectors of the
> request must be checked against the front merge BIO sector,
> not the current sector of the request.

Why does this matter? The merging should only happen before we start the 
request, hence rq pos and first bio should be one and the same.

-- 
Jens Axboe


  parent reply	other threads:[~2016-07-13 16:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13  5:23 [PATCH] block: Fix front merge check Damien Le Moal
2016-07-13  5:42 ` Hannes Reinecke
2016-07-13 16:19 ` Jens Axboe [this message]
2016-07-14  1:23   ` Damien Le Moal
2016-07-21  3:38     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57866A2B.5000403@fb.com \
    --to=axboe@fb.com \
    --cc=damien.lemoal@hgst.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.