From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Longerbeam Subject: Re: [PATCH 02/16] gpu: ipu-cpmem: Add ipu_cpmem_set_uv_offset() Date: Wed, 13 Jul 2016 15:54:18 -0700 Message-ID: <5786C69A.3070301@mentor.com> References: <1467932621-358-1-git-send-email-steve_longerbeam@mentor.com> <1467932621-358-3-git-send-email-steve_longerbeam@mentor.com> <1467999263.2365.72.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1467999263.2365.72.camel@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Philipp Zabel , Steve Longerbeam Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Hi Philipp, On 07/08/2016 10:34 AM, Philipp Zabel wrote: > Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: >> Adds ipu_cpmem_set_uv_offset(), to set planar U/V offsets. >> >> Signed-off-by: Steve Longerbeam >> --- >> drivers/gpu/ipu-v3/ipu-cpmem.c | 7 +++++++ >> include/video/imx-ipu-v3.h | 1 + >> 2 files changed, 8 insertions(+) >> >> diff --git a/drivers/gpu/ipu-v3/ipu-cpmem.c b/drivers/gpu/ipu-v3/ipu-cpmem.c >> index 6494a4d..a36c35e 100644 >> --- a/drivers/gpu/ipu-v3/ipu-cpmem.c >> +++ b/drivers/gpu/ipu-v3/ipu-cpmem.c >> @@ -253,6 +253,13 @@ void ipu_cpmem_set_buffer(struct ipuv3_channel *ch, int bufnum, dma_addr_t buf) >> } >> EXPORT_SYMBOL_GPL(ipu_cpmem_set_buffer); >> >> +void ipu_cpmem_set_uv_offset(struct ipuv3_channel *ch, u32 u_off, u32 v_off) >> +{ >> + ipu_ch_param_write_field(ch, IPU_FIELD_UBO, u_off / 8); >> + ipu_ch_param_write_field(ch, IPU_FIELD_VBO, v_off / 8); >> +} >> +EXPORT_SYMBOL_GPL(ipu_cpmem_set_uv_offset); >> + > I'd prefer to avoid too much duplication in the API. Is there a reason > you can't use ipu_cpmem_set_yuv_planar_full? I could, but it would be cumbersome. ipu_cpmem_set_uv_offset() is being called when kicking off a new tile conversion, and the stride length would have to be calculated all over again if I were to use ipu_cpmem_set_yuv_planar_ful(). When kicking off a new tile conversion, the stride doesn't change, only the tile's buffer address, and U/V offsets for planar, need to be updated. Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751402AbcGMWy3 (ORCPT ); Wed, 13 Jul 2016 18:54:29 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:62680 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400AbcGMWyW (ORCPT ); Wed, 13 Jul 2016 18:54:22 -0400 Subject: Re: [PATCH 02/16] gpu: ipu-cpmem: Add ipu_cpmem_set_uv_offset() To: Philipp Zabel , Steve Longerbeam References: <1467932621-358-1-git-send-email-steve_longerbeam@mentor.com> <1467932621-358-3-git-send-email-steve_longerbeam@mentor.com> <1467999263.2365.72.camel@pengutronix.de> CC: , From: Steve Longerbeam Message-ID: <5786C69A.3070301@mentor.com> Date: Wed, 13 Jul 2016 15:54:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1467999263.2365.72.camel@pengutronix.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philipp, On 07/08/2016 10:34 AM, Philipp Zabel wrote: > Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: >> Adds ipu_cpmem_set_uv_offset(), to set planar U/V offsets. >> >> Signed-off-by: Steve Longerbeam >> --- >> drivers/gpu/ipu-v3/ipu-cpmem.c | 7 +++++++ >> include/video/imx-ipu-v3.h | 1 + >> 2 files changed, 8 insertions(+) >> >> diff --git a/drivers/gpu/ipu-v3/ipu-cpmem.c b/drivers/gpu/ipu-v3/ipu-cpmem.c >> index 6494a4d..a36c35e 100644 >> --- a/drivers/gpu/ipu-v3/ipu-cpmem.c >> +++ b/drivers/gpu/ipu-v3/ipu-cpmem.c >> @@ -253,6 +253,13 @@ void ipu_cpmem_set_buffer(struct ipuv3_channel *ch, int bufnum, dma_addr_t buf) >> } >> EXPORT_SYMBOL_GPL(ipu_cpmem_set_buffer); >> >> +void ipu_cpmem_set_uv_offset(struct ipuv3_channel *ch, u32 u_off, u32 v_off) >> +{ >> + ipu_ch_param_write_field(ch, IPU_FIELD_UBO, u_off / 8); >> + ipu_ch_param_write_field(ch, IPU_FIELD_VBO, v_off / 8); >> +} >> +EXPORT_SYMBOL_GPL(ipu_cpmem_set_uv_offset); >> + > I'd prefer to avoid too much duplication in the API. Is there a reason > you can't use ipu_cpmem_set_yuv_planar_full? I could, but it would be cumbersome. ipu_cpmem_set_uv_offset() is being called when kicking off a new tile conversion, and the stride length would have to be calculated all over again if I were to use ipu_cpmem_set_yuv_planar_ful(). When kicking off a new tile conversion, the stride doesn't change, only the tile's buffer address, and U/V offsets for planar, need to be updated. Steve