From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNVXj-000452-Ry for qemu-devel@nongnu.org; Wed, 13 Jul 2016 21:34:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNVXh-0007xv-PP for qemu-devel@nongnu.org; Wed, 13 Jul 2016 21:34:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33800) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNVXh-0007xp-HK for qemu-devel@nongnu.org; Wed, 13 Jul 2016 21:34:21 -0400 References: <1467724312-9378-1-git-send-email-berrange@redhat.com> <1467724312-9378-4-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <5786EC1C.4090804@redhat.com> Date: Wed, 13 Jul 2016 19:34:20 -0600 MIME-Version: 1.0 In-Reply-To: <1467724312-9378-4-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4Kmdln807OD5con6g4KliVxhq2pXEd0Kf" Subject: Re: [Qemu-devel] [PATCH v7 3/7] qapi: add a QmpInputVisitor that does string conversion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Markus Armbruster , Max Reitz , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Paolo Bonzini , =?UTF-8?Q?Andreas_F=c3=a4rber?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4Kmdln807OD5con6g4KliVxhq2pXEd0Kf From: Eric Blake To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Markus Armbruster , Max Reitz , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Paolo Bonzini , =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <5786EC1C.4090804@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 3/7] qapi: add a QmpInputVisitor that does string conversion References: <1467724312-9378-1-git-send-email-berrange@redhat.com> <1467724312-9378-4-git-send-email-berrange@redhat.com> In-Reply-To: <1467724312-9378-4-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/05/2016 07:11 AM, Daniel P. Berrange wrote: > Currently the QmpInputVisitor assumes that all scalar > values are directly represented as their final types. > ie it assumes an 'int' is using QInt, and a 'bool' is > using QBool. >=20 > This adds an alternative constructor for QmpInputVisitor > that will set it up such that it expects a QString for > all scalar types instead. >=20 > This makes it possible to use QmpInputVisitor with a > QDict produced from QemuOpts, where everything is in > string format. This is almost what I need for my netdev_add fallback on my qapi subset F series, except that I want to have a hybrid mode that accepts BOTH native type and string. I'll take this patch and tweak it for my series, and we can compare the difference. >=20 > Reviewed-by: Marc-Andr=C3=A9 Lureau > Signed-off-by: Daniel P. Berrange > --- --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4Kmdln807OD5con6g4KliVxhq2pXEd0Kf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXhuwcAAoJEKeha0olJ0NqRskIAJbb7BA32mqHvGZ4CrNhA+9d UafS6DolU46WIawOwZVm6cVzzQSSC9axPuPs5VebUyHMiNERYQevGgPalizd9vy0 tojuq/7dFYQD1OD4RGgkbmmfAiHz+UVfHk5qqL5kdjnviVApPHgLu+/dXgSuK/gN 4lEoepFuqEXbPL10QUJ1oF8UX8zWbcR8t4HhJ8xJpR4BYB4r3sDQ4yZCUgj4dtH3 TkgSOG+j34LZbkWZa5TkyNw61elK7E4A9NFVCBK981zM5FF57Y1kCwuMIBFz1Hxs h/jbCAeQnG8bRQlqxYl3NZQdcqJiJvB1HBHQVinoWUfo28HkS76bjXJIltNsyOo= =s2ru -----END PGP SIGNATURE----- --4Kmdln807OD5con6g4KliVxhq2pXEd0Kf--