From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] ppc/mmu-hash64: Remove duplicated #include statement
Date: Thu, 14 Jul 2016 08:32:27 -0600 [thread overview]
Message-ID: <5787A27B.8020703@redhat.com> (raw)
In-Reply-To: <1468484058-8719-1-git-send-email-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
On 07/14/2016 02:14 AM, Thomas Huth wrote:
> No need to include error-report.h twice here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> target-ppc/mmu-hash64.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
Markus, do your header cleanup scripts detect any other situations like
this?
>
> diff --git a/target-ppc/mmu-hash64.c b/target-ppc/mmu-hash64.c
> index 82c2186..f6ffe35 100644
> --- a/target-ppc/mmu-hash64.c
> +++ b/target-ppc/mmu-hash64.c
> @@ -24,7 +24,6 @@
> #include "exec/helper-proto.h"
> #include "qemu/error-report.h"
> #include "sysemu/kvm.h"
> -#include "qemu/error-report.h"
> #include "kvm_ppc.h"
> #include "mmu-hash64.h"
> #include "exec/log.h"
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-07-14 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 8:14 [Qemu-devel] [PATCH] ppc/mmu-hash64: Remove duplicated #include statement Thomas Huth
2016-07-14 14:32 ` Eric Blake [this message]
2016-07-14 15:11 ` Thomas Huth
2016-07-14 16:32 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5787A27B.8020703@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.