From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751375AbcGNO4p (ORCPT ); Thu, 14 Jul 2016 10:56:45 -0400 Received: from mail-bl2nam02on0133.outbound.protection.outlook.com ([104.47.38.133]:63029 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750897AbcGNO4n (ORCPT ); Thu, 14 Jul 2016 10:56:43 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=waiman.long@hpe.com; Message-ID: <5787A81E.7080700@hpe.com> Date: Thu, 14 Jul 2016 10:56:30 -0400 From: Waiman Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12 MIME-Version: 1.0 To: Peter Zijlstra CC: Wanpeng Li , , Wanpeng Li , Ingo Molnar , Davidlohr Bueso Subject: Re: [PATCH v2] locking/pvqspinlock: restore/set vcpu_hashed state after failing adaptive locking spinning References: <1468484156-4521-1-git-send-email-wanpeng.li@hotmail.com> <20160714112648.GG30909@twins.programming.kicks-ass.net> In-Reply-To: <20160714112648.GG30909@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [72.71.243.160] X-ClientProxiedBy: SN1PR17CA0005.namprd17.prod.outlook.com (10.169.33.143) To CS1PR84MB0312.NAMPRD84.PROD.OUTLOOK.COM (10.162.190.30) X-MS-Office365-Filtering-Correlation-Id: 1ec56e0c-bd95-4a77-5255-08d3abf7104e X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0312;2:vLHI2wh6EqOUu6W4D2CfaVjhAU6iLFnRvHSgy+gzA7AZUnMVGVqkf2hy28rDX0fp9Z7MbUIP4Alxyt5SLW+RTl1ga4BmK0wUXtL/OpmNnwBviisfeAv4lHeqG08IQRlX8Xyzgbtj7L10qayq94rouSad+GKVLnyKa/mnEef3sBBQhvjUV91zVt3Zii+ZLSoN;3:OOoK8QXVeHmPXII8BCB9bvCVo3DESzO3AR6FpmsdUey7pDd9DP1onfBVmEqwf1lX8Qs3F6OSgaK6FLSwNkdvkZOFT4DOTCo7Zup5hpjxkoPfPsuxLXvQ8oZszXR4NU5L;25:q012LIIdMSc7KYmVnB+s9bAR8PgUFyuNvJSmRh2aw6sFliiUux0Wo390wLf6Q2weA6RrfNEAqrLriIW+zoqao3m3229Sy3/w1bzTGyMjHKTjatc6l51pDuHP1rYftv1Ox6/cCr4UL86FTZxqI61NMi4mGGmPCyEzTnxWGy0wwLdhb8XZ9p/EQVoB1JPv0tNyXamt77khwOle7fTqh1llc9o8je4xCVYawuxEX1W2FkzkylTt2040Q87rA+RBsrCxAc8KscjocHs8SlLbJW/r7nJuy4tpFVkd5gV7Ex1PWMhbTBGlx6xLXQ2/8f2rpViEBwiWZ1Komd3jsr7OXmBou443sqz7LMZN9lWNi95YJaQSxJ703/f/l/SergcSvOEr08LkXI8hkr3XXTfHnI4oyzw5jPexGLW61KlwC786g0w=;31:TwV5uOFvB5oT5kXUIh+KKTKSR8erz4bBQLcnDBkLG9oXDykD4mRyZKA8uEkpHIa9Kyxjbyn38GIFNUnJ7bm6MHsSYHkJl6i3rpDBy1JnDviIFuP87x/Hahxx86rY2LLPSJhv4Bw8XVGnahwPp5Acrq5ocMKcm7Vqko2NY35gDU2EkG4GzSnnzDTPszs1FWqFy0f0+3vsKXBhQIXNPADY4A== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0312; X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0312;20:xuiY/rA2jaRylSMuqWWRCRV87WUXBZSbfNYZgb3WYl/ug/o/OMBC0Gjr9TYxOTbnqpaTssI0z0LhCjHer1FvQ8EXPKqgvwNF9y/TMyN3DQGgQkiKhVRiR5GJkIUx05TqoJv2Fi+IF9BUYRMEDlxbenck34kXhFi99RDyCgvDpY3vmiBd2f79OpaSsPM8RUnsUKdEBzVdzHiEjYQTYTQX1FMYVDKqhT1xzhTPmK1NLR4LLXQXr6Kd0HgLVp69FZStGKGypLfEQ3oQt+vgdmkaKutSnO3os0VwascLambzmU/nXza/EHcudeM2NbQafd8zKXzs491Jsu6t6yC3RHboLyGnTc4R5rCWAVikKP2fSw3kadBHb62Ylu9MHqMzEtmbRtzYcowxkEttzOIrRsOG3DxKPKDxALLK0Ex0g+6/RJMrldeq6Q8ZdWQjp765zCz5Im1kvtrrdG+LPIuAkLQEz8Xq3ftBvloXytLDvkGgks4X/Y3opVHj/j/mFnUGg/tq;4:Sjd6+niMg1RuTOH/hoRXzavbAMl9rm3WjwoFYexHJUP0UrolVBan5jiW+S8yPF3oMN8wxnl3w3yWspKT8QyzY+eN7cdKDhGSXvb4d1l6/aFbWpmV1IZlDaZEUfKynekxq4uNo931YAGIFRKs4EYuWWTWR92y07IaB84JOtmyGJADOFIuanEFVLl9zs9hibLftuQvOXdm3gRbEwUtnirkapA3sKN/M+rIkUAaJ+kiKrBYnfcFr/H7vck05M/KdNsOhDIFd0zHmqLEp58r/GmX5QB9EcuS3jGksz5pNfilWugRcFwZLL614nXpsJLprFCPjTk73yfX08UTIP1h3ywmVvWnoMIMHhiokB2iT5TDmaHgaYffhzbVLEGCatMe1AHB X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:CS1PR84MB0312;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0312; X-Forefront-PRVS: 00032065B2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(199003)(189002)(377454003)(54534003)(24454002)(105586002)(50466002)(8676002)(4001350100001)(64126003)(97736004)(189998001)(33656002)(7846002)(305945005)(230700001)(7736002)(36756003)(65806001)(15975445007)(65956001)(77096005)(66066001)(47776003)(2950100001)(23756003)(81156014)(81166006)(101416001)(76176999)(80316001)(19580395003)(59896002)(4326007)(586003)(42186005)(65816999)(110136002)(117156001)(50986999)(3846002)(87266999)(106356001)(86362001)(2906002)(92566002)(83506001)(68736007)(54356999)(6116002);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0312;H:[192.168.142.167];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;CS1PR84MB0312;23:2/OL0WZl6IwHCkwhOgcjDzUtow9tsiWdtq9tVXH?= =?iso-8859-1?Q?C40D6/KvgnoNxnHj11Fqbu6G6RVTRDz3Te0pIba0wSFwzKAP/3BfBj6xPF?= =?iso-8859-1?Q?CDzoG1zEV8ubO80iCIj1K1aEqmvQrU/o7a0n6KIlfMXtjUcI7xGEWKv2ud?= =?iso-8859-1?Q?UWVTgk6Qmx5kql1nTXHrdff7d4qYSguBfBo1wV0tZY5vUbmuLNZjyMK71+?= =?iso-8859-1?Q?gL+jeL5JugbG6tY/2t3TCHhDX/SDOqLQJchyJtvMGQLc60qTRBgeoeCUm8?= =?iso-8859-1?Q?HU0v3MA4snUMd40TXqGdEn5FMotlJQgWyLcuQxGkhiBxZjJYuVGf8tvJKj?= =?iso-8859-1?Q?EpY9nPRYhgMiN7Xqqw6qjjXggTTPXbnIbTtq08QY3j5LTTFxlIrpbBXIQa?= =?iso-8859-1?Q?oXzFdjovjc05EbSoTbisl5/Og+8FzZQOwpRtTYnbZpbv9FtUiA4YTM+vFi?= =?iso-8859-1?Q?/p7BjoGmco0c5bnyDL6Yr1h+FivDjOQhJpuOnaI2OhORIrDogIrAPz9iF7?= =?iso-8859-1?Q?FGDLKAekfazjeXBYaZ22Y6hBYwm62M+yTzwk/5hJW9rVXBT/opvEwWMid+?= =?iso-8859-1?Q?2meHcR1hQalg+qMwf0/JY3hEJfZ9JCDkAyvkwlrkjcCMjt1o42tHh+2v6B?= =?iso-8859-1?Q?jzTWS8IXouzWG4lBEBZZq/Q0cPHTtEo/10fQyQoIKididIA/pGFIra+8OM?= =?iso-8859-1?Q?67n17s4GiRSd3AxYu8AcfOV2nErpuELqA2II3tbK5BCYSEOicFJSwoODPI?= =?iso-8859-1?Q?Cf4526doSlWKWvWQ2D51GA+VDfTFw+xvAh21yCiDxzyrYhX6pEiXcVitiv?= =?iso-8859-1?Q?k0V4Zym5KfF3mueP1oi/9FYmTgnoKjFHUHh4Uw2KoDGh0xtPyQUTMcENcb?= =?iso-8859-1?Q?VkU3cokODEjDo2ClUT2MI/6uPklVxMyNCj8aBHL/YqhUKC+vn6CUeFN2YD?= =?iso-8859-1?Q?NTHHl+SgkBYjtDf1v+vvTVQTx/qpL6K3y5mGfjHDblZCkXDztvkwNxcxDG?= =?iso-8859-1?Q?Or2ddNaacpcVMzK923JW6T31Se7oE8yxUU1BhlmgTJvPeKKpGee15Roxb0?= =?iso-8859-1?Q?z1jiK2PP3DvOenyAZxz5iYn01kuVmZzl4EnzjvBD3vEz7eN0Q44j5Hz6yN?= =?iso-8859-1?Q?FENRA0AnfiLxoLf4PNSyz0/yFbb0zrWOIT3cRMcUv43c8mSQ/uU9bMmPs7?= =?iso-8859-1?Q?4pk2WeRKcbFCsmO+jW+Hi9OjEIHcdoSMl5PWIFajKNds6A9E3Syk5VWdzf?= =?iso-8859-1?Q?aJoV2+DZ6or3hpMiKfeR0gAQSdTZ3PGdUFiKdt12ilr4tXttJTyEL3r4Oz?= =?iso-8859-1?Q?EKzSoc9wSEDowNwMQMdQsiG8qDM8H2jXfRhJcf+S4Y+W+GUwbz9KeUr/8S?= =?iso-8859-1?Q?StfUpNRbDK47TuGf0PJPgdTSPrpqJ?= X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0312;6:e1CvTCMu16wvrC6P+NOLtqwHWXAIVL+aDSdGYDxGwz5uuZ7C5KFKcbEBkEcbNpr3CtHOO8ZELOJNDKxf8JWTLwkYkiNtmaCAODCAziuvHnkq8EEvuq/EXrt01B+PVZ3/0wsWqgW45ogY9WQX4DzBA6tlBef/DIhtqwGGwpbTdo4Nd7bkMPI9UuTiHu54QkVnCjs+amjgMQJd9DkwHUPaHSQwq0e7Avn+h+VD146gzLyjsPdF0mGSI03LCtu63/4StpHSoTOcGUmRwtU/zEdZidxmeGEa4Z5tp8zwxMls4J8Fv77rBv5CEEm1pUYgVxxJzN+opGoLLFd7VR8L/tfbMQ==;5:5ahhzQsHkxCUiVLzqbqdSu7EnptqgCc6A1cE6WZZnrkkKdft3MWTV/P/K5iZFErxulvWZmnz/JpRYW7z6w9Wus7wxSDLuefDHc4QIuUwvCEDMuI8zP0l5a44NJvTTICoiqChWz0ACjEfVBrWJgt0jw==;24:nns4NESFNiyt9UuJy+2WFG/s38asUT/JNJ+NCXWsSXe7QCWof+/WuRlnV8JJbWhyuABI/2HzfeICn6riZhnqVEvxOqEC5ShcBuSUa6GOkLE=;7:036X6CttV61r+adcVQTRCZrFG1NTij9sMVF0Io+BR653DFmtrXs6gY6daU4JeLF4VmuzvSgPUdbwuxghMs3FzgWNC6SJr0E0j/zIzVRCfirYR+TwRcyt2jYXI2jH2NvgD4TWC+71Zxn7brzSU3QNNsdn8Kt2R9JoNcokTrnUUWeuzLz8yWE1l370uOFfUhCrYF6oLb2j7d6KjHOzPdWR7seq6Ak5Jy5XtBgr2beYc1uhPwKtACZuXkmqDnNfp30A SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2016 14:56:38.0980 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0312 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/14/2016 07:26 AM, Peter Zijlstra wrote: > On Thu, Jul 14, 2016 at 04:15:56PM +0800, Wanpeng Li wrote: >> In this case, lock holder inserts the pv_node of queue head into the >> hash table and set _Q_SLOW_VAL unnecessary. This patch avoids it by >> restoring/setting vcpu_halted state after failing adaptive locking > ^^^^^^ >> spinning. >> >> - WRITE_ONCE(pn->state, vcpu_halted); >> + WRITE_ONCE(pn->state, vcpu_hashed); > ^^^^^^ > > The Changelog meant so say vcpu_hashed, surely? Do you have chance to review the "Fix missed PV wakeup & support PPC" patch (https://lkml.org/lkml/2016/5/31/677) that I had sent out a while ago? That patch addressed a similar pv_hash leakage and collision problem. Cheers, Longman