From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNjA2-0000ZG-JY for qemu-devel@nongnu.org; Thu, 14 Jul 2016 12:06:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNjA0-0005aA-6C for qemu-devel@nongnu.org; Thu, 14 Jul 2016 12:06:49 -0400 References: <1468499383-17840-1-git-send-email-den@openvz.org> <1468499383-17840-6-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <5787B88F.5050600@redhat.com> Date: Thu, 14 Jul 2016 10:06:39 -0600 MIME-Version: 1.0 In-Reply-To: <1468499383-17840-6-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LNKJpchevUJPgl2dj32kXAtD1iBRen4IQ" Subject: Re: [Qemu-devel] [PATCH v6 5/6] tests: removed skipped flushes from block test traces List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Evgeny Yakovlev , Max Reitz , Stefan Hajnoczi , John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LNKJpchevUJPgl2dj32kXAtD1iBRen4IQ From: Eric Blake To: "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Evgeny Yakovlev , Max Reitz , Stefan Hajnoczi , John Snow Message-ID: <5787B88F.5050600@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 5/6] tests: removed skipped flushes from block test traces References: <1468499383-17840-1-git-send-email-den@openvz.org> <1468499383-17840-6-git-send-email-den@openvz.org> In-Reply-To: <1468499383-17840-6-git-send-email-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/14/2016 06:29 AM, Denis V. Lunev wrote: > From: Evgeny Yakovlev >=20 > bdrv_co_flush is now skipping flushes in case underlying media has no > actual changes. This affected some blkdebug testcases that were > expecting error logs from failure-injected flushes which are now > skipped entirely. >=20 > This change removes expected flush error logs from block tests 026 071 = 089 >=20 > Signed-off-by: Evgeny Yakovlev > Signed-off-by: Denis V. Lunev > CC: Kevin Wolf > CC: Max Reitz > CC: Stefan Hajnoczi > CC: Fam Zheng > CC: John Snow > --- > tests/qemu-iotests/026.out.nocache | 50 ------------------------------= -------- > tests/qemu-iotests/071.out | 8 ------ > tests/qemu-iotests/089.out | 2 -- > 3 files changed, 60 deletions(-) If the previous patch broke the testsuite, then this should be squashed in with that patch so that bisection doesn't land on a broken testsuite. Seeing the testsuite change alongside code change is just fine; it proves what impact the code change has. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LNKJpchevUJPgl2dj32kXAtD1iBRen4IQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXh7iPAAoJEKeha0olJ0Nqd1YIAJuWr57U7VX4IZX60sNGiVIn BzDjx3B4HqMSuU71uAVZ5+tjrqMLMMPjCqW0XeBNZjZSg/gvqZfp2J2yy02rRuYH yOJf1wXj3Fs5r5CH2PHzfA+2gU2d0S3j/sa5ZLWnVr8z0pkm3roTz4564u1tc53a VzWBAk0+SS4x6rnDlnR/zyACRUS/aVV1XY9bxmw5D6aeCLX8LIsWtQ7SGb9nW0fI xxulMmfk+Lw/iyvya7y7YEKXW7xYb9NzIQahZoPPBUAfMDczmSM7s36C1MiPBsBH CpEwzASzBRvzfvJdQGKfse+W4PfBydPbrlPcYRQ5wWqIaNZ2/ykwNhgm/b87op4= =iwNo -----END PGP SIGNATURE----- --LNKJpchevUJPgl2dj32kXAtD1iBRen4IQ--