Re: [Qemu-devel] [PATCH v9 09/17] qapi: Implement boxed types for commands/events

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1839 bytes --]

On 07/14/2016 08:26 AM, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
> 
>> Turn on the ability to pass command and event arguments in
>> a single boxed parameter, which must name a non-empty type
>> (although the type can be a struct with all optional members).
>> For structs, it makes it possible to pass a single qapi type
>> instead of a breakout of all struct members (useful if the
>> arguments are already in a struct or if the number of members
>> is large); for other complex types, it is now possible to use
>> a union or alternate as the data for a command or event.
>>
...
>>  create mode 100644 tests/qapi-schema/args-box-string.json
>>  create mode 100644 tests/qapi-schema/args-box-string.out
>>  create mode 100644 tests/qapi-schema/event-box-empty.err
>>  create mode 100644 tests/qapi-schema/event-box-empty.exit
>>  create mode 100644 tests/qapi-schema/event-box-empty.json
>>  create mode 100644 tests/qapi-schema/event-box-empty.out
> 
> I'm inclined to change box to boxed in the test file names on commit.
> What do you think?
> 

Fine by me ('git mv' is up to the task; you'll have to tweak the
Makefile, but that's not too onerous).

> [...]
>> diff --git a/tests/qapi-schema/args-union.json b/tests/qapi-schema/args-union.json
>> index 7bdcbb7..c0ce091 100644
>> --- a/tests/qapi-schema/args-union.json
>> +++ b/tests/qapi-schema/args-union.json
>> @@ -1,4 +1,3 @@
>> -# we do not allow union arguments
>> -# TODO should we support this?
>> +# use of union arguments requires 'box':true
> 
> You missed a box here.  Can touch up on commit.

Thanks for spotting them all.  Yeah, the stragglers are trivial enough
that you can fix on commit.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]