From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNjPr-0001wn-SM for qemu-devel@nongnu.org; Thu, 14 Jul 2016 12:23:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNjPn-0000uY-OJ for qemu-devel@nongnu.org; Thu, 14 Jul 2016 12:23:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNjPn-0000uF-G6 for qemu-devel@nongnu.org; Thu, 14 Jul 2016 12:23:07 -0400 References: <1468468228-27827-1-git-send-email-eblake@redhat.com> <1468468228-27827-10-git-send-email-eblake@redhat.com> <87lh14pa6w.fsf@dusky.pond.sub.org> From: Eric Blake Message-ID: <5787BC6A.1080806@redhat.com> Date: Thu, 14 Jul 2016 10:23:06 -0600 MIME-Version: 1.0 In-Reply-To: <87lh14pa6w.fsf@dusky.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QgKAbWsUS0Lj0l7wjsbPHb9bDJUIdSXbF" Subject: Re: [Qemu-devel] [PATCH v9 09/17] qapi: Implement boxed types for commands/events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QgKAbWsUS0Lj0l7wjsbPHb9bDJUIdSXbF From: Eric Blake To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth Message-ID: <5787BC6A.1080806@redhat.com> Subject: Re: [Qemu-devel] [PATCH v9 09/17] qapi: Implement boxed types for commands/events References: <1468468228-27827-1-git-send-email-eblake@redhat.com> <1468468228-27827-10-git-send-email-eblake@redhat.com> <87lh14pa6w.fsf@dusky.pond.sub.org> In-Reply-To: <87lh14pa6w.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/14/2016 08:26 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> Turn on the ability to pass command and event arguments in >> a single boxed parameter, which must name a non-empty type >> (although the type can be a struct with all optional members). >> For structs, it makes it possible to pass a single qapi type >> instead of a breakout of all struct members (useful if the >> arguments are already in a struct or if the number of members >> is large); for other complex types, it is now possible to use >> a union or alternate as the data for a command or event. >> =2E.. >> create mode 100644 tests/qapi-schema/args-box-string.json >> create mode 100644 tests/qapi-schema/args-box-string.out >> create mode 100644 tests/qapi-schema/event-box-empty.err >> create mode 100644 tests/qapi-schema/event-box-empty.exit >> create mode 100644 tests/qapi-schema/event-box-empty.json >> create mode 100644 tests/qapi-schema/event-box-empty.out >=20 > I'm inclined to change box to boxed in the test file names on commit. > What do you think? >=20 Fine by me ('git mv' is up to the task; you'll have to tweak the Makefile, but that's not too onerous). > [...] >> diff --git a/tests/qapi-schema/args-union.json b/tests/qapi-schema/arg= s-union.json >> index 7bdcbb7..c0ce091 100644 >> --- a/tests/qapi-schema/args-union.json >> +++ b/tests/qapi-schema/args-union.json >> @@ -1,4 +1,3 @@ >> -# we do not allow union arguments >> -# TODO should we support this? >> +# use of union arguments requires 'box':true >=20 > You missed a box here. Can touch up on commit. Thanks for spotting them all. Yeah, the stragglers are trivial enough that you can fix on commit. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QgKAbWsUS0Lj0l7wjsbPHb9bDJUIdSXbF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXh7xqAAoJEKeha0olJ0NqDtEH/AzOR5MInhSxDrDUxlRshPOy t0+tx09YjL8dHXovRk7oWF6ulUWKWi+xD9vNhgu2KVmUh0cw6xgtwGHa+a2yjET4 E/ZOX8Mv8OwslAfhUwtddMtKUdFBDXJ1aAkPhDKtXpo6LQ5HB7du0YkZLD3AWJof B/Ypqpfm5rMFaWxqY7wAcAMMNWmM6H4mtNHK3ab9BwxVuyrf9xy57j5RQzH7DD0V YGcFWvS2xjslz/u3cPqjYxnsqFbSdg3HmWrm1RWwxBc15hAOFaFA+Gk2p+oDs5c7 hSW9zQFZwlES3PU7siDr+8XREwgpihY6NCOswwbOqwKC+7HPEB1JhYBomDawhhA= =FPjW -----END PGP SIGNATURE----- --QgKAbWsUS0Lj0l7wjsbPHb9bDJUIdSXbF--