From: "Denis V. Lunev" <den@openvz.org>
To: Eric Blake <eblake@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
Jeff Cody <jcody@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 4/8] mirror: create mirror_dirty_init helper for mirror_run
Date: Thu, 14 Jul 2016 19:48:36 +0300 [thread overview]
Message-ID: <5787C264.9010804@openvz.org> (raw)
In-Reply-To: <5787BB8E.5050003@redhat.com>
On 07/14/2016 07:19 PM, Eric Blake wrote:
> On 07/14/2016 07:33 AM, Denis V. Lunev wrote:
>> The code inside the helper will be extended in the next patch. mirror_run
>> itself is overbloated at the moment.
>>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> Reviewed-by: Vladimir Sementsov-Ogievskiy<vsementsov@virtuozzo.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
> I did NOT give R-b on v2 3/7. In particular, this patch has semantic
> changes that I requested on v2, and so you want to make sure I re-review
> it (I often skip re-reviewing a patch that has my R-b listed, on the
> grounds that I'm trusting your judgment that it hasn't substantially
> changed since my last time through it; but here, you have changed it
> since last time).
>
sorry :(
next prev parent reply other threads:[~2016-07-14 19:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 13:33 [Qemu-devel] [PATCH v3 0/8] drive-mirror improvements Denis V. Lunev
2016-07-14 13:33 ` [Qemu-devel] [PATCH v3 1/8] dirty-bitmap: operate with int64_t amount Denis V. Lunev
2016-07-14 13:33 ` [Qemu-devel] [PATCH v3 2/8] mirror: make sectors_in_flight int64_t Denis V. Lunev
2016-07-14 13:33 ` [Qemu-devel] [PATCH v3 3/8] mirror: create mirror_throttle helper Denis V. Lunev
2016-07-14 15:21 ` Eric Blake
2016-07-14 13:33 ` [Qemu-devel] [PATCH v3 4/8] mirror: create mirror_dirty_init helper for mirror_run Denis V. Lunev
2016-07-14 16:19 ` Eric Blake
2016-07-14 16:48 ` Denis V. Lunev [this message]
2016-07-14 13:33 ` [Qemu-devel] [PATCH v3 5/8] block: remove extra condition in bdrv_can_write_zeroes_with_unmap Denis V. Lunev
2016-07-14 13:33 ` [Qemu-devel] [PATCH v3 6/8] mirror: optimize dirty bitmap filling in mirror_run a bit Denis V. Lunev
2016-07-14 13:33 ` [Qemu-devel] [PATCH v3 7/8] mirror: efficiently zero out target Denis V. Lunev
2016-07-14 13:33 ` [Qemu-devel] [PATCH v3 8/8] mirror: improve performance of mirroring of empty disk Denis V. Lunev
2016-07-18 15:37 ` [Qemu-devel] [PATCH v3 0/8] drive-mirror improvements Denis V. Lunev
2016-07-19 8:43 ` Stefan Hajnoczi
2016-07-19 21:07 ` Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5787C264.9010804@openvz.org \
--to=den@openvz.org \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.