From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNmLV-0004Tn-2N for qemu-devel@nongnu.org; Thu, 14 Jul 2016 15:30:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNmLS-00089W-TD for qemu-devel@nongnu.org; Thu, 14 Jul 2016 15:30:52 -0400 References: <1468414241-13119-1-git-send-email-kwolf@redhat.com> <1468414241-13119-12-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5787E864.1070304@redhat.com> Date: Thu, 14 Jul 2016 13:30:44 -0600 MIME-Version: 1.0 In-Reply-To: <1468414241-13119-12-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="elUPkUr4sixD8rwdOn3XLIIux1LBKIWxE" Subject: Re: [Qemu-devel] [PULL v2 11/34] blockjob: Update description of the 'device' field in the QMP API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --elUPkUr4sixD8rwdOn3XLIIux1LBKIWxE From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org Message-ID: <5787E864.1070304@redhat.com> Subject: Re: [Qemu-devel] [PULL v2 11/34] blockjob: Update description of the 'device' field in the QMP API References: <1468414241-13119-1-git-send-email-kwolf@redhat.com> <1468414241-13119-12-git-send-email-kwolf@redhat.com> In-Reply-To: <1468414241-13119-12-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/13/2016 06:50 AM, Kevin Wolf wrote: > From: Alberto Garcia >=20 > The 'device' field in all BLOCK_JOB_* events and 'block-job-*' command > is no longer the device name, but the ID of the job. This patch > updates the documentation to clarify that. >=20 > Signed-off-by: Alberto Garcia > Reviewed-by: Max Reitz > Reviewed-by: Kevin Wolf > Signed-off-by: Kevin Wolf > --- > docs/qmp-events.txt | 12 ++++++++---- > qapi/block-core.json | 35 +++++++++++++++++++++++++---------- > 2 files changed, 33 insertions(+), 14 deletions(-) >=20 > +++ b/qapi/block-core.json > @@ -713,7 +713,8 @@ > # > # @type: the job type ('stream' for image streaming) > # > -# @device: the block device name > +# @device: The job identifier. Originally the device name but other > +# values are allowed since QEMU 2.7 > # > # @len: the maximum progress value > # > @@ -1475,7 +1476,9 @@ > # > # Throttling can be disabled by setting the speed to 0. > # > -# @device: the device name > +# @device: The job identifier. This used to be a device name (hence > +# the name of the parameter), but since QEMU 2.7 it can have > +# other values. It might have been nice to use the same wording everywhere, instead of writing two different things, but it's not the end of the world, and I'm fine if we keep it as committed. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --elUPkUr4sixD8rwdOn3XLIIux1LBKIWxE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXh+hkAAoJEKeha0olJ0NqtH0IAIk6zuDIMBRQXp7vpoMDTQ/i y+qYPnAAfUCl/cg/MaVUioWA543++/6frP22GdUjyIe23wDQsgmdNzGvm9NtLlGN uGKx+IFsWBjBJFeyyWJPmbfs2IOoIP9rk7rrW5PRIcsisX9zFax6/eKeGqF0HJgc TK53XPxi49I+QnADgWSeAQDYEv/eXKw7sYaC+ZBbPi3gi5YfyT3cj/ct0iLjbejE DAPo61jdiTI89thPJHhtAn7ge3bwn3W/ttBdioLP04NxQFZWNDqGgFIaouU60pzp upb+/LNdVN6bJbhXsKAORKy0R0XUJQrs/HuBHnSQdS+Tjdbj5yh3IEJV9dZLH7U= =pFWD -----END PGP SIGNATURE----- --elUPkUr4sixD8rwdOn3XLIIux1LBKIWxE--