From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: mreitz@redhat.com, berto@igalia.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 05/11] block: Accept node-name for blockdev-snapshot-delete-internal-sync
Date: Thu, 14 Jul 2016 14:32:35 -0600 [thread overview]
Message-ID: <5787F6E3.2060501@redhat.com> (raw)
In-Reply-To: <1468502894-18098-6-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
On 07/14/2016 07:28 AM, Kevin Wolf wrote:
> In order to remove the necessity to use BlockBackend names in the
> external API, we want to allow node-names everywhere. This converts
> blockdev-snapshot-delete-internal-sync to accept a node-name without
> lifting the restriction that we're operating at a root node.
>
> In case of an invalid device name, the command returns the GenericError
> error class now instead of DeviceNotFound, because this is what
> qmp_get_root_bs() returns.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> blockdev.c | 16 +++-------------
> qapi/block.json | 5 +++--
> qmp-commands.hx | 2 +-
> tests/qemu-iotests/057 | 2 +-
> 4 files changed, 8 insertions(+), 17 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-07-14 20:32 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 13:28 [Qemu-devel] [PATCH v4 00/11] block: Accept node-name in all node level QMP commands Kevin Wolf
2016-07-14 13:28 ` [Qemu-devel] [PATCH v4 01/11] block: Accept node-name for block-stream Kevin Wolf
2016-07-14 14:16 ` Eric Blake
2016-08-01 13:23 ` Alberto Garcia
2016-07-14 13:28 ` [Qemu-devel] [PATCH v4 02/11] block: Accept node-name for block-commit Kevin Wolf
2016-07-14 15:14 ` Eric Blake
2016-07-18 13:38 ` Max Reitz
2016-07-18 16:13 ` Eric Blake
2016-07-18 16:16 ` Max Reitz
2016-08-01 13:35 ` Alberto Garcia
2016-08-02 16:22 ` Kevin Wolf
2016-07-14 13:28 ` [Qemu-devel] [PATCH v4 03/11] block: Accept node-name for blockdev-backup Kevin Wolf
2016-07-14 16:14 ` Eric Blake
2016-07-18 13:59 ` Max Reitz
2016-08-02 16:58 ` Kevin Wolf
2016-07-14 13:28 ` [Qemu-devel] [PATCH v4 04/11] block: Accept node-name for blockdev-mirror Kevin Wolf
2016-07-14 20:24 ` Eric Blake
2016-08-01 13:42 ` Alberto Garcia
2016-07-14 13:28 ` [Qemu-devel] [PATCH v4 05/11] block: Accept node-name for blockdev-snapshot-delete-internal-sync Kevin Wolf
2016-07-14 20:32 ` Eric Blake [this message]
2016-08-01 13:43 ` Alberto Garcia
2016-07-14 13:28 ` [Qemu-devel] [PATCH v4 06/11] block: Accept node-name for blockdev-snapshot-internal-sync Kevin Wolf
2016-07-14 20:40 ` Eric Blake
2016-08-01 13:54 ` Alberto Garcia
2016-07-14 13:28 ` [Qemu-devel] [PATCH v4 07/11] block: Accept node-name for change-backing-file Kevin Wolf
2016-07-14 20:44 ` Eric Blake
2016-07-18 14:15 ` Max Reitz
2016-08-01 14:04 ` Alberto Garcia
2016-07-14 13:28 ` [Qemu-devel] [PATCH v4 08/11] block: Accept node-name for drive-backup Kevin Wolf
2016-07-14 20:48 ` Eric Blake
2016-07-18 14:24 ` Max Reitz
2016-08-01 14:02 ` Alberto Garcia
2016-07-14 13:28 ` [Qemu-devel] [PATCH v4 09/11] block: Accept node-name for drive-mirror Kevin Wolf
2016-07-14 20:54 ` Eric Blake
2016-07-18 14:30 ` Max Reitz
2016-08-02 16:19 ` Kevin Wolf
2016-08-03 11:16 ` Max Reitz
2016-07-14 13:28 ` [Qemu-devel] [PATCH v4 10/11] nbd-server: Use a separate BlockBackend Kevin Wolf
2016-07-14 21:30 ` Eric Blake
2016-07-14 13:28 ` [Qemu-devel] [PATCH v4 11/11] nbd-server: Allow node name for nbd-server-add Kevin Wolf
2016-07-14 21:36 ` Eric Blake
2016-07-15 13:36 ` Max Reitz
2016-07-15 15:18 ` Eric Blake
2016-07-15 15:22 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5787F6E3.2060501@redhat.com \
--to=eblake@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.