From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNnJK-0006Dd-Es for qemu-devel@nongnu.org; Thu, 14 Jul 2016 16:32:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNnJJ-0003iP-Bi for qemu-devel@nongnu.org; Thu, 14 Jul 2016 16:32:42 -0400 References: <1468502894-18098-1-git-send-email-kwolf@redhat.com> <1468502894-18098-6-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5787F6E3.2060501@redhat.com> Date: Thu, 14 Jul 2016 14:32:35 -0600 MIME-Version: 1.0 In-Reply-To: <1468502894-18098-6-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Gi5AF7fh4If6nRp7kKrICammM3EX9lSS0" Subject: Re: [Qemu-devel] [PATCH v4 05/11] block: Accept node-name for blockdev-snapshot-delete-internal-sync List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, berto@igalia.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Gi5AF7fh4If6nRp7kKrICammM3EX9lSS0 From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, berto@igalia.com, qemu-devel@nongnu.org Message-ID: <5787F6E3.2060501@redhat.com> Subject: Re: [PATCH v4 05/11] block: Accept node-name for blockdev-snapshot-delete-internal-sync References: <1468502894-18098-1-git-send-email-kwolf@redhat.com> <1468502894-18098-6-git-send-email-kwolf@redhat.com> In-Reply-To: <1468502894-18098-6-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/14/2016 07:28 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > blockdev-snapshot-delete-internal-sync to accept a node-name without > lifting the restriction that we're operating at a root node. >=20 > In case of an invalid device name, the command returns the GenericError= > error class now instead of DeviceNotFound, because this is what > qmp_get_root_bs() returns. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 16 +++------------- > qapi/block.json | 5 +++-- > qmp-commands.hx | 2 +- > tests/qemu-iotests/057 | 2 +- > 4 files changed, 8 insertions(+), 17 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Gi5AF7fh4If6nRp7kKrICammM3EX9lSS0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXh/bjAAoJEKeha0olJ0NqKtUH/2H5e1yIrCp+xX+Q3YNJXkBA Xd+um3hjErmp+DZuWcHRvlYl7QuwQFFSMLyjYITaojsmYiCX1+Zn/7+uO/BIRnik DiR5R4HayUXSqX6bvg8q+7tAMYd0ujg+MEEQecQYs6lvUR0J3jmnxD8OX3KIddD6 XCFi95/jI8K5q2TchBp7w6I/xHpZ4AcS7RRdtbCHDiwUNYjowqKU3U1JXv43y6ca xAm9WzdRbx8/8bKPZ8LmOr7VWoi31qg36P5h3LfAYbZdACYRjpBhO1YFqrD8/2ha yg06u5i91EPIUsuLD6eRDdgJmVQ2plz2NspDWljQ+WNI7C4Afhv5zwuUneEsGjE= =ECc9 -----END PGP SIGNATURE----- --Gi5AF7fh4If6nRp7kKrICammM3EX9lSS0--