From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNnRQ-0000Is-5v for qemu-devel@nongnu.org; Thu, 14 Jul 2016 16:41:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNnRP-0005P3-7s for qemu-devel@nongnu.org; Thu, 14 Jul 2016 16:41:04 -0400 References: <1468502894-18098-1-git-send-email-kwolf@redhat.com> <1468502894-18098-7-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5787F8DB.6010901@redhat.com> Date: Thu, 14 Jul 2016 14:40:59 -0600 MIME-Version: 1.0 In-Reply-To: <1468502894-18098-7-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5TaiEmLDW8N749mPncXQsdXLmiupFXrgt" Subject: Re: [Qemu-devel] [PATCH v4 06/11] block: Accept node-name for blockdev-snapshot-internal-sync List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, berto@igalia.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5TaiEmLDW8N749mPncXQsdXLmiupFXrgt From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, berto@igalia.com, qemu-devel@nongnu.org Message-ID: <5787F8DB.6010901@redhat.com> Subject: Re: [PATCH v4 06/11] block: Accept node-name for blockdev-snapshot-internal-sync References: <1468502894-18098-1-git-send-email-kwolf@redhat.com> <1468502894-18098-7-git-send-email-kwolf@redhat.com> In-Reply-To: <1468502894-18098-7-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/14/2016 07:28 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > blockdev-snapshot-internal-sync to accept a node-name without lifting > the restriction that we're operating at a root node. >=20 > In case of an invalid device name, the command returns the GenericError= > error class now instead of DeviceNotFound, because this is what > qmp_get_root_bs() returns. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 15 +++------------ > qapi/block.json | 5 +++-- > qmp-commands.hx | 6 ++++-- > tests/qemu-iotests/057 | 2 +- > 4 files changed, 11 insertions(+), 17 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5TaiEmLDW8N749mPncXQsdXLmiupFXrgt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXh/jbAAoJEKeha0olJ0NqTukH/i5Erts4nq3Oo2oNxy6oYN6+ afEdVr75m7mxKJXLa6FI1xxbedGk/iSJQoAlo040PydHJj59E337dwBQgdnhBZ7+ ngnZpJGEFMz5U4/NrtDEzbgjEmfa4EvFmWWKExasDBuM7miaFcFBZj13tW1ucnBP BYeMpiHzC5OX2QYsz/7rWcTkMK+fULpbmTPkOb91tGsfx24tiO+1gKaXcfCruyNE W3bt/fhiiJxxP1FZRwhwlZL5vvF56V0YNrtKk8QaHIVUVgJdQsCKZXqgJnldv3L5 hxxqcikK918uYEq/+XYJ1Ab5XfztR1jawVu8awxUNJXuva6JSV7fdSpcEG1uxG0= =z5u2 -----END PGP SIGNATURE----- --5TaiEmLDW8N749mPncXQsdXLmiupFXrgt--