From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNnVE-0005Uk-31 for qemu-devel@nongnu.org; Thu, 14 Jul 2016 16:45:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNnVD-00069Y-2Y for qemu-devel@nongnu.org; Thu, 14 Jul 2016 16:45:00 -0400 References: <1468502894-18098-1-git-send-email-kwolf@redhat.com> <1468502894-18098-8-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5787F9C2.4040000@redhat.com> Date: Thu, 14 Jul 2016 14:44:50 -0600 MIME-Version: 1.0 In-Reply-To: <1468502894-18098-8-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FTU4ix5Pal0G07mXborEN3w44HCLbHXiW" Subject: Re: [Qemu-devel] [PATCH v4 07/11] block: Accept node-name for change-backing-file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, berto@igalia.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FTU4ix5Pal0G07mXborEN3w44HCLbHXiW From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, berto@igalia.com, qemu-devel@nongnu.org Message-ID: <5787F9C2.4040000@redhat.com> Subject: Re: [PATCH v4 07/11] block: Accept node-name for change-backing-file References: <1468502894-18098-1-git-send-email-kwolf@redhat.com> <1468502894-18098-8-git-send-email-kwolf@redhat.com> In-Reply-To: <1468502894-18098-8-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/14/2016 07:28 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > change-backing-file to accept a node-name without lifting the > restriction that we're operating at a root node. >=20 > In case of an invalid device name, the command returns the GenericError= > error class now instead of DeviceNotFound, because this is what > qmp_get_root_bs() returns. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 15 +++------------ > qapi/block-core.json | 3 ++- > qmp-commands.hx | 3 ++- > 3 files changed, 7 insertions(+), 14 deletions(-) >=20 Reviewed-by: Eric Blake Sometimes I wonder why this command is limited to only the root node - it seems like tweaking the backing file text of an intermediate node in a chain would be useful to someone. But that's not the problem for this series. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --FTU4ix5Pal0G07mXborEN3w44HCLbHXiW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXh/nCAAoJEKeha0olJ0Nq/p8IAKhFS1L7cxf+dsyER3V4OB2j 30ExcZO2uoApsyFBMP6tQMCsbJ4EJlYcUb6Hbn88/6iKAK2xyWM0Fge2tsrbrQlo jcXvM6F+uHDAvGQPFiSghxQebta1G1t7ZgIp1dstuy2ZD9MSUzebjYJneWRzu8Vk cfUKQI8VRPGSRZ5BxHM/wjxKBlq0yeQ1xP7PvJ1BqutHriPXCuVUD/Kj8RDIYNt2 QYp+LcowHXrW/LBRzNS9r+m+9AG9f4X7rMWQF2kPHnXtFevSQjjE6Hvs6R5qQxZJ yOBRMy/BvgQyTslxgqtmKCKoV2so4R11Dprw+BBaFjVhJCc3AVHLETls/If4Pd0= =kwNr -----END PGP SIGNATURE----- --FTU4ix5Pal0G07mXborEN3w44HCLbHXiW--