From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNnYS-0000PS-Px for qemu-devel@nongnu.org; Thu, 14 Jul 2016 16:48:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNnYR-0006n5-QN for qemu-devel@nongnu.org; Thu, 14 Jul 2016 16:48:20 -0400 References: <1468502894-18098-1-git-send-email-kwolf@redhat.com> <1468502894-18098-9-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5787FA8B.9060204@redhat.com> Date: Thu, 14 Jul 2016 14:48:11 -0600 MIME-Version: 1.0 In-Reply-To: <1468502894-18098-9-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="o88Xqmn0oTKG2Lhor2i3F5E0ihfRFqqAO" Subject: Re: [Qemu-devel] [PATCH v4 08/11] block: Accept node-name for drive-backup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, berto@igalia.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --o88Xqmn0oTKG2Lhor2i3F5E0ihfRFqqAO From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, berto@igalia.com, qemu-devel@nongnu.org Message-ID: <5787FA8B.9060204@redhat.com> Subject: Re: [PATCH v4 08/11] block: Accept node-name for drive-backup References: <1468502894-18098-1-git-send-email-kwolf@redhat.com> <1468502894-18098-9-git-send-email-kwolf@redhat.com> In-Reply-To: <1468502894-18098-9-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/14/2016 07:28 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > drive-backup and the corresponding transaction action to accept a > node-name without lifting the restriction that we're operating at a roo= t > node. >=20 > In case of an invalid device name, the command returns the GenericError= > error class now instead of DeviceNotFound, because this is what > qmp_get_root_bs() returns. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 36 +++++++++--------------------------- > qapi/block-core.json | 4 ++-- > qmp-commands.hx | 2 +- > tests/qemu-iotests/055 | 7 ++----- > 4 files changed, 14 insertions(+), 35 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --o88Xqmn0oTKG2Lhor2i3F5E0ihfRFqqAO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXh/qLAAoJEKeha0olJ0NqGXgH/2kGMgYyuOpfGQ8SWuz5Rqbl szOIlM7JEeJi4fyjsGAhRGcouqACCW/Ai2Vxy4rHtZiKWgIg8CNirFzsrhrjk/dv izM3Dj5uqN9Vh3ATB+neRYPXiSe1ZxeMjp/9PCFRwLbJxvNgXN2T04iIsQ9Bl/1a JtwPTn8zxQ3RCupHR0238yiv5Z6GtOOBfdxwRfd6ZkTrhbRN2s4WXcrA+ttKKLSD pt/9O4ZIecW0reqhK4JJlFijL41c7p6GyMqXn7owxxDd8IFXq1V+DBs6P+lV74/Q 2F+vVV/Y5Tb7w1pcfHNE3pTjBNkO9/Gl9UvrdFfmM+YGCLcuIHhYCpCD5eRpyoc= =cXRb -----END PGP SIGNATURE----- --o88Xqmn0oTKG2Lhor2i3F5E0ihfRFqqAO--