From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNneG-0006bg-6g for qemu-devel@nongnu.org; Thu, 14 Jul 2016 16:54:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNneF-00086k-5j for qemu-devel@nongnu.org; Thu, 14 Jul 2016 16:54:20 -0400 References: <1468502894-18098-1-git-send-email-kwolf@redhat.com> <1468502894-18098-10-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5787FBF2.6040502@redhat.com> Date: Thu, 14 Jul 2016 14:54:10 -0600 MIME-Version: 1.0 In-Reply-To: <1468502894-18098-10-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oiDd7u5IxwIquiIMeAlVHoQ7E37ApxcsM" Subject: Re: [Qemu-devel] [PATCH v4 09/11] block: Accept node-name for drive-mirror List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, berto@igalia.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oiDd7u5IxwIquiIMeAlVHoQ7E37ApxcsM From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, berto@igalia.com, qemu-devel@nongnu.org Message-ID: <5787FBF2.6040502@redhat.com> Subject: Re: [PATCH v4 09/11] block: Accept node-name for drive-mirror References: <1468502894-18098-1-git-send-email-kwolf@redhat.com> <1468502894-18098-10-git-send-email-kwolf@redhat.com> In-Reply-To: <1468502894-18098-10-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/14/2016 07:28 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > drive-mirror to accept a node-name without lifting the restriction that= > we're operating at a root node. >=20 > In case of an invalid device name, the command returns the GenericError= > error class now instead of DeviceNotFound, because this is what > qmp_get_root_bs() returns. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 14 +++----------- > qapi/block-core.json | 5 +++-- > qmp-commands.hx | 3 ++- > tests/qemu-iotests/041 | 8 +++----- > 4 files changed, 11 insertions(+), 19 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --oiDd7u5IxwIquiIMeAlVHoQ7E37ApxcsM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXh/vzAAoJEKeha0olJ0Nqu70H/jy19vrPOae/9io9QVWdBBtl hOFvjORyxnI38t/4rx6n5SFaxnzhBxiXhDrf/maXbygCBGWxAm5i1LuONqMDnLsu qowbXE+pf2iF2ODyXEo8+q0WNNYkrofsKGRRELCX+XBNBhNpaajG4KhUI4+a8Fvn pnUPis6ogaUShqQ8tpr5SRmzMAR//6W+OElB51/MLypLE1iczBWFDQD6DviqwoCF r75IUY11DZ8I/0VVAuUvTCDy4cE178xY5RDX13RH1PQAyd+tII3b5Wk4hFkRX4bK Y3/nU1furmte7leilVDmz8aW6HDIyjG9HDqSBUWGpqfiABHgUA6LAf1R/e40RWU= =vQ84 -----END PGP SIGNATURE----- --oiDd7u5IxwIquiIMeAlVHoQ7E37ApxcsM--