From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNoDN-00032U-Fo for qemu-devel@nongnu.org; Thu, 14 Jul 2016 17:30:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNoDL-0007rJ-EH for qemu-devel@nongnu.org; Thu, 14 Jul 2016 17:30:36 -0400 References: <1468502894-18098-1-git-send-email-kwolf@redhat.com> <1468502894-18098-11-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <57880472.6050305@redhat.com> Date: Thu, 14 Jul 2016 15:30:26 -0600 MIME-Version: 1.0 In-Reply-To: <1468502894-18098-11-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nhm2TJDEOp2ncISt42F6rmiHPnKweDtjO" Subject: Re: [Qemu-devel] [PATCH v4 10/11] nbd-server: Use a separate BlockBackend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, berto@igalia.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nhm2TJDEOp2ncISt42F6rmiHPnKweDtjO From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, berto@igalia.com, qemu-devel@nongnu.org Message-ID: <57880472.6050305@redhat.com> Subject: Re: [PATCH v4 10/11] nbd-server: Use a separate BlockBackend References: <1468502894-18098-1-git-send-email-kwolf@redhat.com> <1468502894-18098-11-git-send-email-kwolf@redhat.com> In-Reply-To: <1468502894-18098-11-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/14/2016 07:28 AM, Kevin Wolf wrote: > The builtin NBD server uses its own BlockBackend now instead of reusing= > the monitor/guest device one. >=20 > This means that it has its own writethrough setting now. The builtin > NBD server always uses writeback caching now regardless of whether the > guest device has WCE enabled. qemu-nbd respects the cache mode given on= > the command line. >=20 > We still need to keep a reference to the monitor BB because we put an > eject notifier on it, but we don't use it for any I/O. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 2 ++ > blockdev-nbd.c | 4 ++-- > include/block/nbd.h | 3 ++- > nbd/server.c | 25 ++++++++++++++++++++----- > qemu-nbd.c | 4 ++-- > 5 files changed, 28 insertions(+), 10 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nhm2TJDEOp2ncISt42F6rmiHPnKweDtjO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXiARyAAoJEKeha0olJ0NqvbMIAIl1XjYTNOLftLeeod3jhu3x ndR3nicQYgjuKl7xmZrAljvcpOZ1KZQzEl9fL83EtkdR6NH0wS9K2b9JqSuI2ZxU 5uZ7qngIznJm3gITGhk8MJT4evYJLinhFjB6Z4H0TnpLGnlvkz/ViZm43Z5qZrQn IG4z6Oi/Yv7xpZPPURrV+njhODjNJumNKoQm/F4eC+xcTzEcA4euNPlQ2QFIe7sa yZ+s5nYCGebrhpA1aeew8x0p6Dz8RK2JIaKQ0YUW3Ud5G5Fa9z5DXTZeiXyD3zhS FAnCGrJABymDdbE/3XvcT9hSASy3cBuINr7h0iaZTieB6CDf/ZV8ncXMhI4FFEo= =t3mS -----END PGP SIGNATURE----- --nhm2TJDEOp2ncISt42F6rmiHPnKweDtjO--