From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49492)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eyakovlev@virtuozzo.com>) id 1bNySk-0000V5-BZ
	for qemu-devel@nongnu.org; Fri, 15 Jul 2016 04:27:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eyakovlev@virtuozzo.com>) id 1bNySf-0006GX-9H
	for qemu-devel@nongnu.org; Fri, 15 Jul 2016 04:27:09 -0400
References: <1468499383-17840-1-git-send-email-den@openvz.org>
	<1468499383-17840-6-git-send-email-den@openvz.org>
	<5787B88F.5050600@redhat.com>
From: Evgeny Yakovlev <eyakovlev@virtuozzo.com>
Message-ID: <57889AC1.5040300@virtuozzo.com>
Date: Fri, 15 Jul 2016 11:11:45 +0300
MIME-Version: 1.0
In-Reply-To: <5787B88F.5050600@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 5/6] tests: removed skipped flushes from
 block test traces
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, "Denis V. Lunev" <den@openvz.org>, qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Max Reitz <mreitz@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, John Snow <jsnow@redhat.com>



On 14.07.2016 19:06, Eric Blake wrote:
> On 07/14/2016 06:29 AM, Denis V. Lunev wrote:
>> From: Evgeny Yakovlev <eyakovlev@virtuozzo.com>
>>
>> bdrv_co_flush is now skipping flushes in case underlying media has no
>> actual changes. This affected some blkdebug testcases that were
>> expecting error logs from failure-injected flushes which are now
>> skipped entirely.
>>
>> This change removes expected flush error logs from block tests 026 071 089
>>
>> Signed-off-by: Evgeny Yakovlev <eyakovlev@virtuozzo.com>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Kevin Wolf <kwolf@redhat.com>
>> CC: Max Reitz <mreitz@redhat.com>
>> CC: Stefan Hajnoczi <stefanha@redhat.com>
>> CC: Fam Zheng <famz@redhat.com>
>> CC: John Snow <jsnow@redhat.com>
>> ---
>>   tests/qemu-iotests/026.out.nocache | 50 --------------------------------------
>>   tests/qemu-iotests/071.out         |  8 ------
>>   tests/qemu-iotests/089.out         |  2 --
>>   3 files changed, 60 deletions(-)
> If the previous patch broke the testsuite, then this should be squashed
> in with that patch so that bisection doesn't land on a broken testsuite.
>
> Seeing the testsuite change alongside code change is just fine; it
> proves what impact the code change has.
>

Will do.