From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO03y-0003mI-KK for qemu-devel@nongnu.org; Fri, 15 Jul 2016 06:09:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bO03u-0000uc-Ec for qemu-devel@nongnu.org; Fri, 15 Jul 2016 06:09:41 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:40858 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO03u-0000uV-3N for qemu-devel@nongnu.org; Fri, 15 Jul 2016 06:09:38 -0400 Message-ID: <5788B660.2060001@kamp.de> Date: Fri, 15 Jul 2016 12:09:36 +0200 From: Peter Lieven MIME-Version: 1.0 References: <577A6955.6020603@kamp.de> <577B130A.3040205@redhat.com> <3221d3d3-37ee-9752-396e-379792445ee0@redhat.com> <577BCB35.6060103@redhat.com> <1a6cbf2d-ff64-0994-23b4-eb305d5ce35f@redhat.com> In-Reply-To: <1a6cbf2d-ff64-0994-23b4-eb305d5ce35f@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Eric Blake , "qemu-devel@nongnu.org" Cc: Kevin Wolf Am 05.07.2016 um 17:09 schrieb Paolo Bonzini: > > On 05/07/2016 16:59, Eric Blake wrote: >> And yes, we could probably switch to (potentially slower) / % * instead >> of bit operations in block/io.c to accommodate a non-power-of-2 optimal >> size, but it would require a careful audit to make sure we don't have >> even more bit-wise operations lurking that were assuming a power of 2. > Yes, it would require some auditing but it has always worked. Regarding > speed, I'm sure that / % * are not slower than a system call! :) Eric, whats the status of this? Will you send a follow-up to your series restoring the old behaviour? Thanks, Peter