From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO5RX-0001xT-8a for qemu-devel@nongnu.org; Fri, 15 Jul 2016 11:54:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bO5RV-0003ff-BE for qemu-devel@nongnu.org; Fri, 15 Jul 2016 11:54:22 -0400 References: <1465921477-9005-1-git-send-email-berrange@redhat.com> <1465921477-9005-2-git-send-email-berrange@redhat.com> <28a76640-3127-ca17-ed86-c375e60f4567@redhat.com> From: Eric Blake Message-ID: <57890725.1050707@redhat.com> Date: Fri, 15 Jul 2016 09:54:13 -0600 MIME-Version: 1.0 In-Reply-To: <28a76640-3127-ca17-ed86-c375e60f4567@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aVdWl2okhHdAL0wShLm4AfUP5Foja7VxG" Subject: Re: [Qemu-devel] [PATCH v3 1/2] crypto: add support for querying parameters for block encryption List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aVdWl2okhHdAL0wShLm4AfUP5Foja7VxG From: Eric Blake To: Max Reitz , "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf Message-ID: <57890725.1050707@redhat.com> Subject: Re: [PATCH v3 1/2] crypto: add support for querying parameters for block encryption References: <1465921477-9005-1-git-send-email-berrange@redhat.com> <1465921477-9005-2-git-send-email-berrange@redhat.com> <28a76640-3127-ca17-ed86-c375e60f4567@redhat.com> In-Reply-To: <28a76640-3127-ca17-ed86-c375e60f4567@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/14/2016 10:33 AM, Max Reitz wrote: > On 14.06.2016 18:24, Daniel P. Berrange wrote: >> When creating new block encryption volumes, we accept a list of >> parameters to control the formatting process. It is useful to >> be able to query what those parameters were for existing block >> devices. Add a qcrypto_block_get_info() method which returns a >> QCryptoBlockInfo instance to report this data. >> >> Signed-off-by: Daniel P. Berrange >> --- >> crypto/block-luks.c | 67 +++++++++++++++++++++++++++++++++++++++++= +++ >> crypto/block.c | 17 +++++++++++ >> crypto/blockpriv.h | 4 +++ >> include/crypto/block.h | 16 +++++++++++ >> qapi/crypto.json | 76 +++++++++++++++++++++++++++++++++++++++++= +++++++++ >> 5 files changed, 180 insertions(+) >=20 > Reviewed-by: Max Reitz >=20 > (I'll be waiting whether Eric wants to comment) Looks good to me as well; if you'd like you can add Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --aVdWl2okhHdAL0wShLm4AfUP5Foja7VxG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXiQclAAoJEKeha0olJ0NqK2oH/3PgnSynllxMlRc4aewQuUCX V0Z5B2Mc+RBCraRMpf82Ra28+9/3jx1iaihVDp2/pTC1MmLUas3Yx/1oTxyVRGNU qpCKrhzB0ClskWhx1wVeNnJwPeMbijTRh7y0iChSRtUljLEwQjNVEkBHzxgl0P/h 5MtmBbsYwWE3zDBsQm4Ul9Nd8Jn0ry+R4PpplKCfyDXBBPc+4gJP0boznCfGgIIt PzD8sz++gBHoM4jG8ykL6sfdnRXuem/ooBzzguiDmeDhe86j+GLVYrfd5P60onU4 hrEDu0RkSUxTHcpGeULsM3mldQvOXCBb5IQO4TptXo/Dq7VRK9vPLCEyjQ6PgU4= =C+zd -----END PGP SIGNATURE----- --aVdWl2okhHdAL0wShLm4AfUP5Foja7VxG--