All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kandziora <jjj@gmx.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org
Subject: Re: Introducing a kernel driver for the DS28E17 Onewire to I2C master bridge; Feature request: introduce I2C_FUNC_STOP
Date: Fri, 15 Jul 2016 19:27:16 +0200	[thread overview]
Message-ID: <57891CF4.9010605@gmx.de> (raw)
In-Reply-To: <20160715112559.GA1695@tetsubishi>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 15.07.2016 um 13:26 schrieb Wolfram Sang:
> 
> I would say no, since it is not generic.
> 
> You should also populate an i2c_adapter_quirks structure and limit
> reads to 256 (and maybe other stuff), if not done already.
> 
Done.


Next quirk with the DS28E17: It can do an arbitrary number of write
messages, followed by ONE read message in one transfer. As there is no
"Read Without Stop Condition".

My driver code just ignores the fact there always is a Stop Condition
after a read. As the DS28E17 is hardly ever used in a multi-master
setup, that should be okay.

For the combined transfer the DS28E17 also supports, my driver code
checks if all of the conditions are met inside its
i2c_master_transfer() function and uses that function automatically
when applicable.


The current quirks flags only allows to limit the number of messages
to two in general. How to announce the behaviour correctly?


Kind regards

	Jan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAleJHPIACgkQzGZqmZvWQdkQFACfUYomuw8JYMdNqouP8sjpd6Nm
U5EAoJ+U6G2gDoZbJ+lGpIAGOxiTTJ52
=SCdT
-----END PGP SIGNATURE-----

  reply	other threads:[~2016-07-15 17:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13 10:07 Introducing a kernel driver for the DS28E17 Onewire to I2C master bridge; Feature request: introduce I2C_FUNC_STOP Jan Kandziora
2016-07-14  9:58 ` Wolfram Sang
2016-07-14 12:53   ` Jan Kandziora
2016-07-14 13:19     ` Wolfram Sang
2016-07-15 11:13       ` Jan Kandziora
2016-07-15 11:26         ` Wolfram Sang
2016-07-15 17:27           ` Jan Kandziora [this message]
2016-07-15 18:52           ` Jan Kandziora
2016-07-16  4:51             ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57891CF4.9010605@gmx.de \
    --to=jjj@gmx.de \
    --cc=linux-i2c@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.