From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO7Hn-0005j6-C3 for qemu-devel@nongnu.org; Fri, 15 Jul 2016 13:52:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bO7Hj-0005l3-9C for qemu-devel@nongnu.org; Fri, 15 Jul 2016 13:52:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO7Hj-0005kv-0y for qemu-devel@nongnu.org; Fri, 15 Jul 2016 13:52:23 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7E73C7F3F9 for ; Fri, 15 Jul 2016 17:52:22 +0000 (UTC) References: <1468576014-28788-1-git-send-email-stefanha@redhat.com> From: Eric Blake Message-ID: <578922D5.9010003@redhat.com> Date: Fri, 15 Jul 2016 11:52:21 -0600 MIME-Version: 1.0 In-Reply-To: <1468576014-28788-1-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jQH9GSh3Oi425j6QUaWgjdUnsDuJlnpaw" Subject: Re: [Qemu-devel] [PATCH] checkpatch: consider git extended headers valid patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Colin Lord This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jQH9GSh3Oi425j6QUaWgjdUnsDuJlnpaw From: Eric Blake To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Colin Lord Message-ID: <578922D5.9010003@redhat.com> Subject: Re: [Qemu-devel] [PATCH] checkpatch: consider git extended headers valid patches References: <1468576014-28788-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1468576014-28788-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/15/2016 03:46 AM, Stefan Hajnoczi wrote: > Renames look like this with git-diff(1) when diff.renames =3D true is s= et: >=20 > diff --git a/a b/b > similarity index 100% > rename from a > rename to b >=20 > This raises the "Does not appear to be a unified-diff format patch" > error because checkpatch.pl only considers a diff valid if it contains > at least one "@@" hunk. >=20 > This patch accepts renames and copies too so that checkpatch.pl exits > successfully when a diff only renames/copies files. The git diff > extended header format is described on the git-diff(1) man page. >=20 > Reported-by: Colin Lord > Signed-off-by: Stefan Hajnoczi > --- > scripts/checkpatch.pl | 5 +++++ > 1 file changed, 5 insertions(+) Reviewed-by: Eric Blake and especially nice since we recommend diff.renames =3D true in our patch= submission guidelines. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jQH9GSh3Oi425j6QUaWgjdUnsDuJlnpaw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXiSLVAAoJEKeha0olJ0NqKY4IAJ3XH4LC/rMilvuJqR+EoPt8 kT4lFI0n1tsICY8sw8cJTF2CH2EN6sXttdSOntDo+g8M1YBTG/3XHpi+BJdOYTzf bftEPOJsVk3PQSDkbqNgqnTR5MrUrDdCnRS7mzZ4mqjCk3GxhF3fJsXmkArRjagX F3rCTuQrLNSya1eznBgsIMt3aejVGKrGsxQjOOf4K6HUDSxtbWWF4uwkCVXCn46e qfAOuoW/qEXyZz0muSOt8aqqft/KZN//UxT8DusJ25eoJpmU3alPtFeuoEFw15/A wKNxMg4udqDtxHQ+94T/XnJSozWsZDjl/zKveo7T4ebrK2TRAk0Uv5IjIz1N9Fg= =YREl -----END PGP SIGNATURE----- --jQH9GSh3Oi425j6QUaWgjdUnsDuJlnpaw--