From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Topi Miettinen <toiwoton@gmail.com>, linux-kernel@vger.kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Balbir Singh <bsingharora@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Markus Elfring <elfring@users.sourceforge.net>,
Thomas Gleixner <tglx@linutronix.de>,
Rik van Riel <riel@redhat.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH 01/14] resource limits: foundation for resource highwater tracking
Date: Fri, 15 Jul 2016 19:57:10 +0200 [thread overview]
Message-ID: <578923F6.1070606@6wind.com> (raw)
In-Reply-To: <f76487c4-9d60-d402-10b2-2ff7c0525e78@gmail.com>
Le 15/07/2016 18:27, Topi Miettinen a écrit :
[snip]
>> Why playing with version number? It complexifies the (userland) code and
>> existing applications break when the kernel is updated.
>> Goal of netlink is to be easily extensible. By adding a new attribute, existing
>> userspace tools won't break.
>
> I just followed this text in taskstats.h. Does that give wrong advice?
>
> * The struct is versioned. Newer versions should only add fields to
> * the bottom of the struct to maintain backward compatibility.
> *
> *
> * To add new fields
> * a) bump up TASKSTATS_VERSION
> * b) add comment indicating new version number at end of struct
> * c) add new fields after version comment; maintain 64-bit alignment
I don't know taskstats well, but that is not how netlink works. There is no need
to manage a version with netlink, just add new attributes.
Regards,
Nicolas
next prev parent reply other threads:[~2016-07-15 17:57 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 10:35 [PATCH 00/14] Present useful limits to user (v2) Topi Miettinen
2016-07-15 10:35 ` Topi Miettinen
2016-07-15 10:35 ` Topi Miettinen
2016-07-15 10:35 ` Topi Miettinen
2016-07-15 10:35 ` Topi Miettinen
2016-07-15 10:35 ` [PATCH 01/14] resource limits: foundation for resource highwater tracking Topi Miettinen
2016-07-15 12:12 ` kbuild test robot
2016-07-15 12:49 ` Nicolas Dichtel
2016-07-15 16:27 ` Topi Miettinen
2016-07-15 17:57 ` Nicolas Dichtel [this message]
2016-07-15 10:35 ` [PATCH 02/14] resource limits: aggregate task highwater marks to cgroup level Topi Miettinen
2016-07-15 10:35 ` Topi Miettinen
2016-07-15 12:38 ` kbuild test robot
2016-07-15 14:10 ` Tejun Heo
2016-07-15 17:15 ` Topi Miettinen
2016-07-18 22:52 ` Tejun Heo
2016-07-19 16:57 ` Topi Miettinen
2016-07-19 18:18 ` Tejun Heo
2016-07-15 10:35 ` [PATCH 03/14] resource limits: track highwater mark of file sizes Topi Miettinen
2016-07-15 10:35 ` [PATCH 04/14] resource limits: track highwater mark of VM data segment Topi Miettinen
2016-07-15 10:35 ` Topi Miettinen
2016-07-15 10:35 ` Topi Miettinen
2016-07-15 10:35 ` [PATCH 05/14] resource limits: track highwater mark of stack size Topi Miettinen
2016-07-15 10:35 ` Topi Miettinen
2016-07-15 10:35 ` [PATCH 06/14] resource limits: track highwater mark of cores dumped Topi Miettinen
2016-07-15 10:35 ` [PATCH 07/14] resource limits: track highwater mark of user processes Topi Miettinen
2016-07-15 10:35 ` Topi Miettinen
2016-07-15 10:35 ` [PATCH 08/14] resource limits: track highwater mark of number of files Topi Miettinen
2016-07-15 10:35 ` [PATCH 09/14] resource limits: track highwater mark of locked memory Topi Miettinen
2016-07-15 10:35 ` Topi Miettinen
2016-07-15 10:35 ` Topi Miettinen
2016-07-15 15:14 ` Oleg Nesterov
2016-07-15 15:14 ` Oleg Nesterov
2016-07-15 15:14 ` Oleg Nesterov
2016-07-15 17:39 ` Topi Miettinen
2016-07-15 17:39 ` Topi Miettinen
2016-07-15 17:39 ` Topi Miettinen
2016-07-18 15:38 ` Oleg Nesterov
2016-07-18 15:38 ` Oleg Nesterov
2016-07-18 15:38 ` Oleg Nesterov
2016-07-15 17:45 ` Topi Miettinen
2016-07-15 10:35 ` [PATCH 10/14] resource limits: track highwater mark of address space size Topi Miettinen
2016-07-15 10:35 ` Topi Miettinen
2016-07-15 10:35 ` [PATCH 11/14] resource limits: track highwater mark of number of pending signals Topi Miettinen
2016-07-15 10:35 ` [PATCH 12/14] resource limits: track highwater mark of size of message queues Topi Miettinen
2016-07-15 10:36 ` [PATCH 13/14] resource limits: track highwater mark of niceness Topi Miettinen
2016-07-15 10:36 ` [PATCH 14/14] resource limits: track highwater mark of RT priority Topi Miettinen
2016-07-15 12:43 ` [PATCH 00/14] Present useful limits to user (v2) Peter Zijlstra
2016-07-15 12:43 ` Peter Zijlstra
2016-07-15 12:43 ` Peter Zijlstra
2016-07-15 13:52 ` Topi Miettinen
2016-07-15 13:52 ` Topi Miettinen
2016-07-15 13:52 ` Topi Miettinen
2016-07-15 13:59 ` Peter Zijlstra
2016-07-15 13:59 ` Peter Zijlstra
2016-07-15 13:59 ` Peter Zijlstra
2016-07-15 13:59 ` Peter Zijlstra
2016-07-15 13:59 ` Peter Zijlstra
2016-07-15 16:57 ` Topi Miettinen
2016-07-15 16:57 ` Topi Miettinen
2016-07-15 16:57 ` Topi Miettinen
2016-07-15 16:57 ` Topi Miettinen
2016-07-15 20:54 ` H. Peter Anvin
2016-07-15 20:54 ` H. Peter Anvin
2016-07-15 20:54 ` H. Peter Anvin
2016-07-15 20:54 ` H. Peter Anvin
2016-07-15 20:54 ` H. Peter Anvin
2016-07-18 13:00 ` Austin S. Hemmelgarn
[not found] ` <20160715135956.GA3115-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2016-07-15 20:54 ` H. Peter Anvin
2016-07-15 20:54 ` H. Peter Anvin
2016-07-15 20:54 ` H. Peter Anvin
2016-07-15 20:54 ` H. Peter Anvin
2016-07-15 13:04 ` Balbir Singh
2016-07-15 13:04 ` Balbir Singh
2016-07-15 13:04 ` Balbir Singh
2016-07-15 16:35 ` Topi Miettinen
2016-07-15 16:35 ` Topi Miettinen
2016-07-15 16:35 ` Topi Miettinen
2016-07-18 22:05 ` Doug Ledford
2016-07-18 22:05 ` Doug Ledford
2016-07-19 16:53 ` Topi Miettinen
2016-07-19 16:53 ` Topi Miettinen
2016-07-19 16:53 ` Topi Miettinen
2016-07-15 14:19 ` Richard Weinberger
2016-07-15 14:19 ` Richard Weinberger
2016-07-15 14:19 ` Richard Weinberger
2016-07-15 17:19 ` Topi Miettinen
2016-07-15 17:19 ` Topi Miettinen
2016-07-15 17:19 ` Topi Miettinen
2016-07-18 21:25 ` Doug Ledford
2016-07-18 21:25 ` Doug Ledford
2016-07-15 17:42 ` Topi Miettinen
2016-08-03 18:20 ` Topi Miettinen
2016-08-03 18:20 ` Topi Miettinen
2016-08-04 6:59 ` Fwd: " Topi Miettinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578923F6.1070606@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=bsingharora@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=elfring@users.sourceforge.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=toiwoton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.