From: Shanker Donthineni <shankerd@codeaurora.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel <xen-devel@lists.xensource.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH RESEND 2/4] xen: Add generic implementation of binary search
Date: Fri, 15 Jul 2016 13:18:29 -0500 [thread overview]
Message-ID: <578928F5.3060104@codeaurora.org> (raw)
In-Reply-To: <8f20c7f5-ee72-cc71-a258-1829e292ed95@citrix.com>
Hi Andrew,
On 07/15/2016 12:42 PM, Andrew Cooper wrote:
> On 15/07/16 18:35, Shanker Donthineni wrote:
>> This patch adds the generic implementation of binary search algorithm
>> whcih is copied from Linux kernel v4.7-rc7. No functional changes.
>>
>> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
>> ---
>> Resend to fix the In-Reply-To/References header feilds.
>>
>> xen/common/Makefile | 1 +
>> xen/common/bsearch.c | 51
> +++++++++++++++++++++++++++++++++++++++++++++++
>> xen/include/xen/bsearch.h | 9 +++++++++
> Having a header file for a single is silly (I have no idea why Linux
> does it like that).
>
> I would move it into xen/lib.h which contains a number of other
> stdlib.h-like functions.
>
> With that done, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
I'll follow your suggestion.
--
Shanker Donthineni
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-15 18:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 17:35 [PATCH RESEND 0/4] Change fixed mmio handlers to a variable number Shanker Donthineni
2016-07-15 17:35 ` [PATCH RESEND 1/4] arm/io: Use separate memory allocation for mmio handlers Shanker Donthineni
2016-07-15 17:35 ` [PATCH RESEND 2/4] xen: Add generic implementation of binary search Shanker Donthineni
2016-07-15 17:42 ` Andrew Cooper
2016-07-15 18:18 ` Shanker Donthineni [this message]
2016-07-15 17:35 ` [PATCH RESEND 3/4] xen/arm: io: Use binary search for mmio handler lookup Shanker Donthineni
2016-07-15 17:35 ` [PATCH RESEND 4/4] arm/vgic: Change fixed number of mmio handlers to variable number Shanker Donthineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578928F5.3060104@codeaurora.org \
--to=shankerd@codeaurora.org \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.