From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO8hQ-0000vF-PE for qemu-devel@nongnu.org; Fri, 15 Jul 2016 15:23:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bO8hM-0000na-E8 for qemu-devel@nongnu.org; Fri, 15 Jul 2016 15:22:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO8hM-0000nW-6p for qemu-devel@nongnu.org; Fri, 15 Jul 2016 15:22:56 -0400 References: <146860251243.30668.5165413432802957512.stgit@fimbulvetr.bsc.es> <146860252322.30668.18276041739086338328.stgit@fimbulvetr.bsc.es> From: Eric Blake Message-ID: <5789380E.1010005@redhat.com> Date: Fri, 15 Jul 2016 13:22:54 -0600 MIME-Version: 1.0 In-Reply-To: <146860252322.30668.18276041739086338328.stgit@fimbulvetr.bsc.es> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IWIM3whSu3eo5CB7fQNiaAoIiWOxk3NHC" Subject: Re: [Qemu-devel] [PATCH v3 2/2] trace: [bsd-user] Commandline arguments to control tracing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Llu=c3=ads_Vilanova?= , qemu-devel@nongnu.org Cc: Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IWIM3whSu3eo5CB7fQNiaAoIiWOxk3NHC From: Eric Blake To: =?UTF-8?Q?Llu=c3=ads_Vilanova?= , qemu-devel@nongnu.org Cc: Stefan Hajnoczi Message-ID: <5789380E.1010005@redhat.com> Subject: Re: [PATCH v3 2/2] trace: [bsd-user] Commandline arguments to control tracing References: <146860251243.30668.5165413432802957512.stgit@fimbulvetr.bsc.es> <146860252322.30668.18276041739086338328.stgit@fimbulvetr.bsc.es> In-Reply-To: <146860252322.30668.18276041739086338328.stgit@fimbulvetr.bsc.es> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/15/2016 11:08 AM, Llu=C3=ADs Vilanova wrote: > Signed-off-by: Llu=C3=ADs Vilanova > --- > bsd-user/main.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) >=20 > @@ -754,6 +760,8 @@ int main(int argc, char **argv) > =20 > cpu_model =3D NULL; > =20 > + qemu_add_opts(&qemu_trace_opts); > + > optind =3D 1; > for(;;) { Optional, but since you are in the area, you could add the missing space after 'for'. > if (optind >=3D argc) > @@ -840,6 +848,9 @@ int main(int argc, char **argv) > singlestep =3D 1; > } else if (!strcmp(r, "strace")) { > do_strace =3D 1; > + } else if (!strcmp(r, "trace")) { > + g_free(trace_file); > + trace_file =3D trace_opt_parse(optarg); > } else > { and fix the 'else {' to be on one line. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --IWIM3whSu3eo5CB7fQNiaAoIiWOxk3NHC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXiTgOAAoJEKeha0olJ0NqDr4H/i5Ge4zXIgzBRYXWyS8c9oyn qtj6CBF8alqaQfRbiDDNqNv9hscm1YrfmnIL3E1gnpCCP+d8PInRgjLxhXOHW/nH XJyJTC4RifXvwMpFEaiipPt41nuyIobMKHOTkKYHXz91T6uILjhcJjBjw6GGadBW V8+vJcb9GRvp4IF0tVrsGmo3yz7z0hlAOZcxL/Bz7k36qJmYdT2dWC/A+6Yewk4o 9lM9BD/AXNDTWKJJINpeoht3cb3o4WvIAKjuecNk04WSVZN059+YNEDi2Qd2HQqL O3fvgpzErUWEWi9hYMCtkPRBLZYDlD+Q0vM7xbu9VRJpyV/t2Ke/8K9aQvcU/ZQ= =4IOV -----END PGP SIGNATURE----- --IWIM3whSu3eo5CB7fQNiaAoIiWOxk3NHC--