Re: [meta-raspberrypi][PATCH v3 00/14] Support for VC4 graphics driver

[Carlos Alberto Lopez Perez <clopez@igalia.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2242 bytes --]

On 30/05/16 22:49, Herve Jourdain wrote:
> This v3 series addresses the following issues with the v2 series:
> a. patch rebased
> b. new revision of kernel, to get a version of the VC4 graphics driver that handles render nodes
> c. patch to the VC4 driver to enable proper working of the render nodes (need to add authorization for IOCTLs)
> 
> v2 series:
> a. Fix the 4.4.10 kernel revision
> b. Effectively add vc4-kms-v3d overlay to the list of overlays to build (forgotten previously)
> c. Make the parameter to the v4c-kms-v3d overlay configurable
> d. Add default values for the cma parameter to the v4c-kms-v3d overlay, depending on the board (and the memory it has)
> 
> This patch series enables the support for the VC4 graphics driver from Eric Anholt.
> There was a previous patch series by Javier Martinez Canillas, but it required use of a different kernel.
> VC4 is now supported in the raspberrypi official kernel, at least for 4.4.9+.
> The support in 4.1 exists, but it is NOT STABLE, so it has been deemed unreasonable to support VC4 with 4.1 kernels.
> 
> THEREFORE, VC4 graphics is supported ONLY for kernel versions 4.4.9 and later.
> 
> This patch series proposes to support VC4 by only adding 'vc4graphics' to MACHINE_FEATURES, for raspberrypi. If this is set, it will trigger all the necessary configuration/changes to use the VC4 driver, including mesa/wayland/weston currently, and adding the overlay required.
> In order for this series to work, some previous patches are needed (support for .dtbo, and fix of the mesa packaging when there is no DRI driver).
> The memory reserved for the VC4 driver has default values depending on the version of the board used, but it can be configured by setting VC4_CMA_SIZE to a value supported by the overlay ('cma-256', 'cma-192', 'cma-128', 'cma-96', 'cma-64').
> 'cma-256' is the recommended value, but it might not be possible on boards with 512MB or DRAM, or less...
> 'cma-64' is known to not being able to support FHD/1080p.
> 

Hi.

I tested this and works fine.

So +1 vote to merge this.


> It was tested with wayland/weston, without the support for X11.


I'm ataching here a minor patch that adds support for X11.

Regards!

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: vc4graphics-Support-X11-with-the-VC4-driver.patch --]
[-- Type: text/x-diff; name="vc4graphics-Support-X11-with-the-VC4-driver.patch", Size: 1487 bytes --]

From 7058846569c3769c3e3c8a4de25a123ab56a289f Mon Sep 17 00:00:00 2001
From: Carlos Alberto Lopez Perez <clopez@igalia.com>
Date: Fri, 15 Jul 2016 21:22:00 +0200
Subject: [PATCH] vc4graphics: Support X11 with the VC4 driver.

  * We need to use the X11 modesetting driver with VC4.

  * We need to build at least the mesa swrast DRI driver.
   (its already the default so don't overwrite it to empty)

Signed-off-by: Carlos Alberto Lopez Perez <clopez@igalia.com>
---
 conf/machine/include/rpi-base.inc     | 2 +-
 recipes-graphics/mesa/mesa_%.bbappend | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/conf/machine/include/rpi-base.inc b/conf/machine/include/rpi-base.inc
index 34b90e8..3311074 100644
--- a/conf/machine/include/rpi-base.inc
+++ b/conf/machine/include/rpi-base.inc
@@ -12,7 +12,7 @@ XSERVER = " \
     xf86-input-evdev \
     xf86-input-mouse \
     xf86-input-keyboard \
-    xf86-video-fbdev \
+    ${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "xf86-video-modesetting", "xf86-video-fbdev", d)} \
     "
 
 # Really supported starting from linux-raspberrypi 3.18.y only
diff --git a/recipes-graphics/mesa/mesa_%.bbappend b/recipes-graphics/mesa/mesa_%.bbappend
index b182388..9c5df99 100644
--- a/recipes-graphics/mesa/mesa_%.bbappend
+++ b/recipes-graphics/mesa/mesa_%.bbappend
@@ -1,4 +1,2 @@
 PACKAGECONFIG_append_rpi = " gallium"
 GALLIUMDRIVERS_rpi = "vc4"
-DRIDRIVERS_rpi = ""
-
-- 
2.1.4


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]