From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Longerbeam Subject: Re: [PATCH 07/16] gpu: ipu-v3: Add VDI input IDMAC channels Date: Fri, 15 Jul 2016 14:34:07 -0700 Message-ID: <578956CF.9020801@mentor.com> References: <1467932621-358-1-git-send-email-steve_longerbeam@mentor.com> <1467932621-358-8-git-send-email-steve_longerbeam@mentor.com> <1468586749.7213.33.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1468586749.7213.33.camel@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Philipp Zabel , Steve Longerbeam Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On 07/15/2016 05:45 AM, Philipp Zabel wrote: > Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: >> Adds the VDIC field input IDMAC channels. These channels >> transfer fields F(n-1), F(n), and F(N+1) from memory to >> the VDIC (channels 8, 9, 10 respectively). >> >> Signed-off-by: Steve Longerbeam >> --- >> include/video/imx-ipu-v3.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/include/video/imx-ipu-v3.h b/include/video/imx-ipu-v3.h >> index 586979e..2302fc5 100644 >> --- a/include/video/imx-ipu-v3.h >> +++ b/include/video/imx-ipu-v3.h >> @@ -107,6 +107,9 @@ enum ipu_channel_irq { >> #define IPUV3_CHANNEL_CSI2 2 >> #define IPUV3_CHANNEL_CSI3 3 >> #define IPUV3_CHANNEL_VDI_MEM_IC_VF 5 >> +#define IPUV3_CHANNEL_MEM_VDI_P 8 >> +#define IPUV3_CHANNEL_MEM_VDI 9 >> +#define IPUV3_CHANNEL_MEM_VDI_N 10 > I would prefer the names to be just a bit more descriptive: > > #define IPUV3_CHANNEL_MEM_VDI_PREV 8 > #define IPUV3_CHANNEL_MEM_VDI_CUR 9 > #define IPUV3_CHANNEL_MEM_VDI_NEXT 10 > > The reference manual states that the purposes of these channels are > "Previous field", "Current field", and "Next field" input to the VDIC, > respectively. right. Ok I will make that change in next version. Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751972AbcGOVeM (ORCPT ); Fri, 15 Jul 2016 17:34:12 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:39798 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893AbcGOVeJ (ORCPT ); Fri, 15 Jul 2016 17:34:09 -0400 Subject: Re: [PATCH 07/16] gpu: ipu-v3: Add VDI input IDMAC channels To: Philipp Zabel , Steve Longerbeam References: <1467932621-358-1-git-send-email-steve_longerbeam@mentor.com> <1467932621-358-8-git-send-email-steve_longerbeam@mentor.com> <1468586749.7213.33.camel@pengutronix.de> CC: , From: Steve Longerbeam Message-ID: <578956CF.9020801@mentor.com> Date: Fri, 15 Jul 2016 14:34:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1468586749.7213.33.camel@pengutronix.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/15/2016 05:45 AM, Philipp Zabel wrote: > Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: >> Adds the VDIC field input IDMAC channels. These channels >> transfer fields F(n-1), F(n), and F(N+1) from memory to >> the VDIC (channels 8, 9, 10 respectively). >> >> Signed-off-by: Steve Longerbeam >> --- >> include/video/imx-ipu-v3.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/include/video/imx-ipu-v3.h b/include/video/imx-ipu-v3.h >> index 586979e..2302fc5 100644 >> --- a/include/video/imx-ipu-v3.h >> +++ b/include/video/imx-ipu-v3.h >> @@ -107,6 +107,9 @@ enum ipu_channel_irq { >> #define IPUV3_CHANNEL_CSI2 2 >> #define IPUV3_CHANNEL_CSI3 3 >> #define IPUV3_CHANNEL_VDI_MEM_IC_VF 5 >> +#define IPUV3_CHANNEL_MEM_VDI_P 8 >> +#define IPUV3_CHANNEL_MEM_VDI 9 >> +#define IPUV3_CHANNEL_MEM_VDI_N 10 > I would prefer the names to be just a bit more descriptive: > > #define IPUV3_CHANNEL_MEM_VDI_PREV 8 > #define IPUV3_CHANNEL_MEM_VDI_CUR 9 > #define IPUV3_CHANNEL_MEM_VDI_NEXT 10 > > The reference manual states that the purposes of these channels are > "Previous field", "Current field", and "Next field" input to the VDIC, > respectively. right. Ok I will make that change in next version. Steve