From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Longerbeam Subject: Re: [PATCH 08/16] gpu: ipu-v3: Add ipu_csi_set_src() Date: Fri, 15 Jul 2016 14:45:11 -0700 Message-ID: <57895967.4010500@mentor.com> References: <1467932621-358-1-git-send-email-steve_longerbeam@mentor.com> <1467932621-358-9-git-send-email-steve_longerbeam@mentor.com> <1468586942.7213.37.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1468586942.7213.37.camel@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Philipp Zabel , Steve Longerbeam Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On 07/15/2016 05:49 AM, Philipp Zabel wrote: > Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: > >> +{ >> + ipu_set_csi_src_mux(csi->ipu, csi->id, select_mipi_csi2); >> + >> + return 0; >> +} >> +EXPORT_SYMBOL_GPL(ipu_csi_set_src); >> + > Couldn't you just replace ipu_set_csi_src_mux? Yeah. I guess I created this as a matter of code convenience, but not worth exporting another function. I will remove this patch in next version. Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751856AbcGOVpY (ORCPT ); Fri, 15 Jul 2016 17:45:24 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:40628 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751446AbcGOVpN (ORCPT ); Fri, 15 Jul 2016 17:45:13 -0400 Subject: Re: [PATCH 08/16] gpu: ipu-v3: Add ipu_csi_set_src() To: Philipp Zabel , Steve Longerbeam References: <1467932621-358-1-git-send-email-steve_longerbeam@mentor.com> <1467932621-358-9-git-send-email-steve_longerbeam@mentor.com> <1468586942.7213.37.camel@pengutronix.de> CC: , From: Steve Longerbeam Message-ID: <57895967.4010500@mentor.com> Date: Fri, 15 Jul 2016 14:45:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1468586942.7213.37.camel@pengutronix.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/15/2016 05:49 AM, Philipp Zabel wrote: > Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: > >> +{ >> + ipu_set_csi_src_mux(csi->ipu, csi->id, select_mipi_csi2); >> + >> + return 0; >> +} >> +EXPORT_SYMBOL_GPL(ipu_csi_set_src); >> + > Couldn't you just replace ipu_set_csi_src_mux? Yeah. I guess I created this as a matter of code convenience, but not worth exporting another function. I will remove this patch in next version. Steve